Skip to content

depends: bump libmultiprocess for CMake fixes #30490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2024
Merged

depends: bump libmultiprocess for CMake fixes #30490

merged 1 commit into from
Jul 20, 2024

Conversation

theuni
Copy link
Member

@theuni theuni commented Jul 19, 2024 •
edited by fanquake
Loading

Broken out of #30454 . Bumped even further after bitcoin-core/libmultiprocess#98 was merged upstream.

hebasto Presumably this approach works now with the CMake branch?

@DrahtBot
Copy link
Contributor

DrahtBot commented Jul 19, 2024 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK ryanofsky

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@theuni
Copy link
Member Author

theuni commented Jul 19, 2024

Ping @ryanofsky for a quick concept ACK for bumping to this particular commit.

ryanofsky
ryanofsky approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@ryanofsky ryanofsky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK d318c4e.

I haven't tested the cmake support, but I made the same version bump in 3e6c61f, which is part of #10102 and #30437

@fanquake fanquake merged commit efeb397 into bitcoin:master Jul 20, 2024
@hebasto
Copy link
Member

hebasto commented Jul 20, 2024 •
edited
Loading

Presumably this approach works now with the CMake branch?

Unfortunately, it doesn't.

The PR30454 branch rebased on the master branch @ efeb397 fails:

$ make -C depends NO_QT=1 NO_WALLET=1 NO_UPNP=1 NO_NATPMP=1 NO_ZMQ=1 NO_USDT=1 MULTIPROCESS=1
$ cmake -B build --toolchain depends/x86_64-pc-linux-gnu/toolchain.cmake
...
CMake Error at CMakeLists.txt:158 (find_package):
  Could not find a package configuration file provided by
  "LibmultiprocessGen" with any of the following names:

    LibmultiprocessGenConfig.cmake
    libmultiprocessgen-config.cmake

I will look for a solution in the upstream repository.

UPD. bitcoin-core/libmultiprocess#98 (comment)

This was referenced Jul 22, 2024
Closed
Merged
@hebasto hebasto mentioned this pull request Jul 23, 2024
Merged
@hebasto
Copy link
Member

hebasto commented Jul 23, 2024

Ported to the CMake-based build system in hebasto#277.

fanquake added a commit that referenced this pull request Jul 24, 2024
@fanquake
Merge #30513: depends: Bump libmultiprocess for CMake fixes
1518c08 
ec0e805 depends: Bump `libmultiprocess` for CMake fixes (Hennadii Stepanov)

Pull request description:

  This PR amends #30490 and bumps the upstream branch, which now includes a required CMake [fix](bitcoin-core/libmultiprocess#103).

  Addresses #30490 (comment).

  The CI logs are available in #29790 where the recent [push](https://github.com/hebasto/bitcoin/tree/pr29790-0723.2.mp) uses this PR implementation.

ACKs for top commit:
  ryanofsky:
    Code review ACK ec0e805
  theuni:
    utACK ec0e805.

Tree-SHA512: e300a27bcab80a63a518719e9af8e10a938294fc07289cadbf4a7744627c10b0e9541a36971d08b65152f3f7d0eb434e427274d9c9d9f0bdd216afd914027a0f
hebasto added a commit to hebasto/bitcoin that referenced this pull request Jul 24, 2024
@hebasto
Merge #277: cmake: Port PR30490 and PR30513 from the master branch
ead20f0 
1995169 fixup! cmake: Add `MULTIPROCESS` option (Hennadii Stepanov)
fbf9a64 fixup! build: Generate `toolchain.cmake` in depends (Hennadii Stepanov)
4ef9fc6 depends: Bump `libmultiprocess` for CMake fixes (Hennadii Stepanov)
ff3916c depends: bump libmultiprocess for CMake fixes (Cory Fields)
07f6cd7 Revert "depends: Bump libmultiprocess source" (Hennadii Stepanov)

Pull request description:

  This PR ports bitcoin#30490 and bitcoin#30513.

  The first commit ensures there are no conflicts when applying commits being ported.

Top commit has no ACKs.

Tree-SHA512: 6dbfc608aedcc3ab991b2983146a459f64b43f57f6612ffdaf1152b83591cb260a885e86dd8aed25c46869d197582a59fa780932c3fad1ffa150fe8aa4fee010
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 27, 2024
@fanquake @PastaPastaPasta
Merge bitcoin#30490: depends: bump libmultiprocess for CMake fixes
ec5338c 
d318c4e depends: bump libmultiprocess for CMake fixes (Cory Fields)

Pull request description:

  Broken out of bitcoin#30454 . Bumped [even further](bitcoin@4883197#r1684802528) after bitcoin-core/libmultiprocess#98 was merged upstream.

  hebasto Presumably this approach works now with the CMake branch?

ACKs for top commit:
  ryanofsky:
    Code review ACK d318c4e.

Tree-SHA512: 4b5491f73c0063d09e8339829cd831b1f4c441dd7b55a22037c9337c80cce19bb00a3e5cf925efa77d6d4e89ab45482f40f5799bc14948f8cabcbad3c3549430
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 27, 2024
@fanquake @PastaPastaPasta
Merge bitcoin#30490: depends: bump libmultiprocess for CMake fixes
c1ca6f2 
d318c4e depends: bump libmultiprocess for CMake fixes (Cory Fields)

Pull request description:

  Broken out of bitcoin#30454 . Bumped [even further](bitcoin@4883197#r1684802528) after bitcoin-core/libmultiprocess#98 was merged upstream.

  hebasto Presumably this approach works now with the CMake branch?

ACKs for top commit:
  ryanofsky:
    Code review ACK d318c4e.

Tree-SHA512: 4b5491f73c0063d09e8339829cd831b1f4c441dd7b55a22037c9337c80cce19bb00a3e5cf925efa77d6d4e89ab45482f40f5799bc14948f8cabcbad3c3549430
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 27, 2024
@fanquake @PastaPastaPasta
Merge bitcoin#30490: depends: bump libmultiprocess for CMake fixes
a6e391d 
d318c4e depends: bump libmultiprocess for CMake fixes (Cory Fields)

Pull request description:

  Broken out of bitcoin#30454 . Bumped [even further](bitcoin@4883197#r1684802528) after bitcoin-core/libmultiprocess#98 was merged upstream.

  hebasto Presumably this approach works now with the CMake branch?

ACKs for top commit:
  ryanofsky:
    Code review ACK d318c4e.

Tree-SHA512: 4b5491f73c0063d09e8339829cd831b1f4c441dd7b55a22037c9337c80cce19bb00a3e5cf925efa77d6d4e89ab45482f40f5799bc14948f8cabcbad3c3549430
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 28, 2024
@fanquake @PastaPastaPasta
Merge bitcoin#30490: depends: bump libmultiprocess for CMake fixes
2e97072 
d318c4e depends: bump libmultiprocess for CMake fixes (Cory Fields)

Pull request description:

  Broken out of bitcoin#30454 . Bumped [even further](bitcoin@4883197#r1684802528) after bitcoin-core/libmultiprocess#98 was merged upstream.

  hebasto Presumably this approach works now with the CMake branch?

ACKs for top commit:
  ryanofsky:
    Code review ACK d318c4e.

Tree-SHA512: 4b5491f73c0063d09e8339829cd831b1f4c441dd7b55a22037c9337c80cce19bb00a3e5cf925efa77d6d4e89ab45482f40f5799bc14948f8cabcbad3c3549430
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Oct 1, 2024
@fanquake @PastaPastaPasta
Merge bitcoin#30490: depends: bump libmultiprocess for CMake fixes
d46e16c 
d318c4e depends: bump libmultiprocess for CMake fixes (Cory Fields)

Pull request description:

  Broken out of bitcoin#30454 . Bumped [even further](bitcoin@4883197#r1684802528) after bitcoin-core/libmultiprocess#98 was merged upstream.

  hebasto Presumably this approach works now with the CMake branch?

ACKs for top commit:
  ryanofsky:
    Code review ACK d318c4e.

Tree-SHA512: 4b5491f73c0063d09e8339829cd831b1f4c441dd7b55a22037c9337c80cce19bb00a3e5cf925efa77d6d4e89ab45482f40f5799bc14948f8cabcbad3c3549430
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Oct 3, 2024
@fanquake @PastaPastaPasta
Merge bitcoin#30513: depends: Bump libmultiprocess for CMake fixes
50f31ae 
ec0e805 depends: Bump `libmultiprocess` for CMake fixes (Hennadii Stepanov)

Pull request description:

  This PR amends bitcoin#30490 and bumps the upstream branch, which now includes a required CMake [fix](bitcoin-core/libmultiprocess#103).

  Addresses bitcoin#30490 (comment).

  The CI logs are available in bitcoin#29790 where the recent [push](https://github.com/hebasto/bitcoin/tree/pr29790-0723.2.mp) uses this PR implementation.

ACKs for top commit:
  ryanofsky:
    Code review ACK ec0e805
  theuni:
    utACK ec0e805.

Tree-SHA512: e300a27bcab80a63a518719e9af8e10a938294fc07289cadbf4a7744627c10b0e9541a36971d08b65152f3f7d0eb434e427274d9c9d9f0bdd216afd914027a0f
PastaPastaPasta added a commit to dashpay/dash that referenced this pull request Oct 3, 2024
@PastaPastaPasta
Merge #6295: backport: cmake prereq 3
7c0d44c 
1b62294 Merge bitcoin#30743: depends: build libevent with `-D_GNU_SOURCE` (merge-script)
0f135dd Merge bitcoin#30522: ci: Add missing qttools5-dev install to Asan task (merge-script)
d46e16c Merge bitcoin#30490: depends: bump libmultiprocess for CMake fixes (merge-script)
7a63c20 Merge bitcoin#29276: depends: Update libmultiprocess library to fix C++20 macos build error (fanquake)
630e767 Merge bitcoin#28907: depends: bump libmultiprocess to fix capnproto deprecation warnings (fanquake)
318471d Merge bitcoin#28735: depends: Bump to capnproto-c++-1.0.1 (fanquake)
ad0c279 Merge bitcoin#26672: build: Update libmultiprocess library (fanquake)

Pull request description:

  ## Issue being fixed or feature implemented
  depends on #6294

  ## What was done?
  Batch of backports

  ## How Has This Been Tested?

  ## Breaking Changes

  ## Checklist:
    _Go over all the following points, and put an `x` in all the boxes that apply._
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  UdjinM6:
    utACK 1b62294

Tree-SHA512: a0a01b1b4844725aa6c96304a4cddae61ec29b677a760f35648e7f39fb36f6f462d3a6d5e411e99f4db1fa59c01f6fffd87158cbef5e1ba1edb43e68fc362c77
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Oct 3, 2024
@fanquake @PastaPastaPasta
Merge bitcoin#30513: depends: Bump libmultiprocess for CMake fixes
7cdacdc 
ec0e805 depends: Bump `libmultiprocess` for CMake fixes (Hennadii Stepanov)

Pull request description:

  This PR amends bitcoin#30490 and bumps the upstream branch, which now includes a required CMake [fix](bitcoin-core/libmultiprocess#103).

  Addresses bitcoin#30490 (comment).

  The CI logs are available in bitcoin#29790 where the recent [push](https://github.com/hebasto/bitcoin/tree/pr29790-0723.2.mp) uses this PR implementation.

ACKs for top commit:
  ryanofsky:
    Code review ACK ec0e805
  theuni:
    utACK ec0e805.

Tree-SHA512: e300a27bcab80a63a518719e9af8e10a938294fc07289cadbf4a7744627c10b0e9541a36971d08b65152f3f7d0eb434e427274d9c9d9f0bdd216afd914027a0f
@bitcoin bitcoin locked and limited conversation to collaborators Jul 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanofsky ryanofsky ryanofsky approved these changes

Assignees
No one assigned
Labels
Build system
Projects
No open projects
CMake
Status: ⭐ Prerequisites
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@theuni @DrahtBot @hebasto @ryanofsky @fanquake