Skip to content

Conversation

@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 9, 2022

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK ryanofsky

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Copy link
Contributor

@ryanofsky ryanofsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK 2a2dd0a.

Thanks for the version update. I do want to look into converting the library into a subtree so this step isn't necessary in the future.

Replacing `install` with `install-lib` and `install-bin` is not strictly
necessary just to update the library, but it takes advantage of recent
changes in the new version, and makes the build more minimal.
@hebasto
Copy link
Member Author

hebasto commented Dec 9, 2022

Updated 2a2dd0a -> 1986f12 (pr26672.01 -> pr26672.02, diff):

Copy link
Contributor

@ryanofsky ryanofsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK 1986f12

Just updated commit message since last review (thanks!)

@fanquake fanquake merged commit e1fb738 into bitcoin:master Dec 10, 2022
@hebasto hebasto deleted the 221209-mp branch December 10, 2022 10:58
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 10, 2022
1986f12 build: Update `libmultiprocess` library (Hennadii Stepanov)

Pull request description:

  This update in particular includes:
  - bitcoin-core/libmultiprocess#78 which is [required](bitcoin#25972 (comment)) for bitcoin#25972
  - bitcoin-core/libmultiprocess#74
  - bitcoin-core/libmultiprocess#70

ACKs for top commit:
  ryanofsky:
    Code review ACK 1986f12

Tree-SHA512: 2d9fa72df5de7d5be37d77d479702cba36c45e9fa9d9fc27e58aac0437c39e4a1054c0ac53b612cb43e830982e444d98c7d3e651d093ac68344e66f4734227bb
@bitcoin bitcoin locked and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants