Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Apr 2, 2024

This PR goal is to facilitate testing CI scripts migration to the CMake.

@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 2, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #30597 (doc: Drop no longer needed workaround for WSL by hebasto)
  • #30527 (Bump python minimum supported version to 3.10 by maflcko)
  • #30465 (depends: Set CMAKE_SYSTEM_VERSION for CMake builds by hebasto)
  • #29881 (guix: use GCC 13 to builds releases by fanquake)
  • #29868 (Reintroduce external signer support for Windows by hebasto)
  • #25573 ([POC] guix: produce a fully -static-pie bitcoind by fanquake)
  • #19461 (multiprocess: Add bitcoin-gui -ipcconnect option by ryanofsky)
  • #19460 (multiprocess: Add bitcoin-wallet -ipcconnect option by ryanofsky)
  • #10102 (Multiprocess bitcoin by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@hebasto hebasto force-pushed the 240402-cmake-DA branch 2 times, most recently from 2fa6fe0 to c26bd2a Compare April 2, 2024 16:04
@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 2, 2024

🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the
documentation.

Possibly this is due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.

Leave a comment here, if you need help tracking down a confusing failure.

Debug: https://github.com/bitcoin/bitcoin/runs/23353954951

@hebasto hebasto force-pushed the 240402-cmake-DA branch 2 times, most recently from b24c0aa to c393fa4 Compare April 3, 2024 11:30
fanquake added a commit that referenced this pull request Jul 24, 2024
ec0e805 depends: Bump `libmultiprocess` for CMake fixes (Hennadii Stepanov)

Pull request description:

  This PR amends #30490 and bumps the upstream branch, which now includes a required CMake [fix](bitcoin-core/libmultiprocess#103).

  Addresses #30490 (comment).

  The CI logs are available in #29790 where the recent [push](https://github.com/hebasto/bitcoin/tree/pr29790-0723.2.mp) uses this PR implementation.

ACKs for top commit:
  ryanofsky:
    Code review ACK ec0e805
  theuni:
    utACK ec0e805.

Tree-SHA512: e300a27bcab80a63a518719e9af8e10a938294fc07289cadbf4a7744627c10b0e9541a36971d08b65152f3f7d0eb434e427274d9c9d9f0bdd216afd914027a0f
@hebasto hebasto force-pushed the 240402-cmake-DA branch 2 times, most recently from e1086db to 1d0951e Compare July 31, 2024 09:47
@hebasto hebasto closed this Aug 8, 2024
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Oct 3, 2024
ec0e805 depends: Bump `libmultiprocess` for CMake fixes (Hennadii Stepanov)

Pull request description:

  This PR amends bitcoin#30490 and bumps the upstream branch, which now includes a required CMake [fix](bitcoin-core/libmultiprocess#103).

  Addresses bitcoin#30490 (comment).

  The CI logs are available in bitcoin#29790 where the recent [push](https://github.com/hebasto/bitcoin/tree/pr29790-0723.2.mp) uses this PR implementation.

ACKs for top commit:
  ryanofsky:
    Code review ACK ec0e805
  theuni:
    utACK ec0e805.

Tree-SHA512: e300a27bcab80a63a518719e9af8e10a938294fc07289cadbf4a7744627c10b0e9541a36971d08b65152f3f7d0eb434e427274d9c9d9f0bdd216afd914027a0f
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Oct 3, 2024
ec0e805 depends: Bump `libmultiprocess` for CMake fixes (Hennadii Stepanov)

Pull request description:

  This PR amends bitcoin#30490 and bumps the upstream branch, which now includes a required CMake [fix](bitcoin-core/libmultiprocess#103).

  Addresses bitcoin#30490 (comment).

  The CI logs are available in bitcoin#29790 where the recent [push](https://github.com/hebasto/bitcoin/tree/pr29790-0723.2.mp) uses this PR implementation.

ACKs for top commit:
  ryanofsky:
    Code review ACK ec0e805
  theuni:
    utACK ec0e805.

Tree-SHA512: e300a27bcab80a63a518719e9af8e10a938294fc07289cadbf4a7744627c10b0e9541a36971d08b65152f3f7d0eb434e427274d9c9d9f0bdd216afd914027a0f
@bitcoin bitcoin locked and limited conversation to collaborators Aug 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants