Skip to content

Conversation

fanquake
Copy link
Member

GCC 11.x or Clang 15.x are now required to compile Bitcoin Core.

@DrahtBot
Copy link
Contributor

DrahtBot commented Jun 10, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3d4ca62.

Build
-----

GCC 11.1 or later, or Clang 15+ or later,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: In the phrase "Clang 15+ or later" the plus sign seems redundant.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can fix it up in the follow-up #30263

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea. Will merge this now. If clang-16 happens, it can be updated, if not, it can be changed in the wiki.

@theuni
Copy link
Member

theuni commented Jun 11, 2024

Wait for #30263 ?

@fanquake fanquake merged commit 416e26c into bitcoin:master Jun 12, 2024
@fanquake fanquake deleted the release_notes_compilers branch June 12, 2024 09:23
kwvg added a commit to kwvg/dash that referenced this pull request Nov 10, 2024
kwvg added a commit to kwvg/dash that referenced this pull request Jan 7, 2025
kwvg added a commit to kwvg/dash that referenced this pull request Feb 5, 2025
PastaPastaPasta added a commit to dashpay/dash that referenced this pull request Feb 7, 2025
, bitcoin#24337, bitcoin#27682, bitcoin#29208, bitcoin#29091, bitcoin#29165, bitcoin#29934, bitcoin#30261, partial bitcoin#27662, bitcoin#28210, bitcoin#28348, bitcoin#30263 (bump minimum compiler)

0861692 partial bitcoin#30263: Bump clang minimum supported version to 16 (Kittywhiskers Van Gogh)
5e7e563 merge bitcoin#30261: add release note for 29091 and 29165 (Kittywhiskers Van Gogh)
4d10993 merge bitcoin#29934: add LLVM instruction for macOS < 13 (Kittywhiskers Van Gogh)
7e4614a merge bitcoin#29165: Bump clang minimum supported version to 15 (Kittywhiskers Van Gogh)
f397076 merge bitcoin#29091: Bump g++ minimum supported version to 11 (Kittywhiskers Van Gogh)
35d3357 merge bitcoin#29208: Bump clang minimum supported version to 14 (Kittywhiskers Van Gogh)
c71e3df partial bitcoin#28348: Bump g++ minimum supported version to 10 (Kittywhiskers Van Gogh)
b7da1ed partial bitcoin#28210: Bump clang minimum supported version to 13 (Kittywhiskers Van Gogh)
6b22832 partial bitcoin#27662: Bump minimum supported GCC to g++-9 (Kittywhiskers Van Gogh)
f677769 merge bitcoin#27682: Bump minimum supported Clang to clang-10 (Kittywhiskers Van Gogh)
f8e0339 docs: add `libgmp` as an optional dependency (Kittywhiskers Van Gogh)
ebba607 docs: update version used to match `depends` (Kittywhiskers Van Gogh)
39b6f4b merge bitcoin#24337: Do not define `PROVIDE_FUZZ_MAIN_FUNCTION` macro unconditionally (Kittywhiskers Van Gogh)
2bd8422 merge bitcoin#23565: rewrite dependencies.md (Kittywhiskers Van Gogh)
56989ec merge bitcoin#24164: Bump minimum required clang/libc++ to 8.0 (Kittywhiskers Van Gogh)
bac407f merge bitcoin#23060: increase minimum compiler and lib(std)c++ requirements (Kittywhiskers Van Gogh)

Pull request description:

  ## Additional Information

  * Dependent on #6516

  ## Breaking Changes

  GCC 11.1 or later, or Clang 16.0 or later, are now required to compile Dash Core.

  ## Checklist:

  - [x] I have performed a self-review of my own code
  - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)**
  - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)**
  - [x] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  PastaPastaPasta:
    utACK 0861692
  UdjinM6:
    utACK 0861692

Tree-SHA512: 6de3f8153482b4f379fd397dd3000688632356299c4f13a2f8af20d2f7337318bd3cd0b96182d6f378846b14981bc499ea32aa3d20cba6a0c7cf5f2a6e151937
@bitcoin bitcoin locked and limited conversation to collaborators Jun 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants