doc: add LLVM instruction for macOS < 13 #29934

Sjors · 2024-04-22T14:35:50Z

#29208 bumped clang to 14, which users of old macOS versions need to install manually. This PR adds instructions.

Xcode 14.3.1 ships clang 14.0.3 (14.0.0 is broken, see #29918):
https://en.wikipedia.org/wiki/Xcode#Xcode_11.0_-_14.x_(since_SwiftUI_framework)

The system requirements for that is macOS Ventura 13.0 or later: https://developer.apple.com/documentation/xcode-release-notes/xcode-14_3_1-release-notes#

Homebrew itself officially supports macOS 12 or later, but may still work on macOS 11: https://docs.brew.sh/Installation

Fwiw macOS 11 Big Sur last got an update in September 2023, so Apple has not entirely written it off: https://en.wikipedia.org/wiki/MacOS_Big_Sur

DrahtBot · 2024-04-22T14:35:54Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	maflcko, TheCharlatan
Concept ACK	ismaelsadeeq

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Sjors · 2024-04-22T14:43:53Z

I tested these instructions by installing llvm 14.0.6 on macOS 14.4.1.

I don't have a macOS 11 or 12 machine, so have not tested those. So there may be other issues, which we'll just have to find out if someone runs into them.

maflcko

lgtm

doc/build-osx.md

TheCharlatan · 2024-04-22T14:56:34Z

Will test shortly.

ismaelsadeeq · 2024-04-22T15:03:26Z

Concept ACK, I ran into this issue sometime ago

doc/build-osx.md

Sjors · 2024-04-23T18:51:26Z

I spun up a VM with macOS 11 Big Sur and installed the command line tools (I had to download them from Apple, because xcode-select --install got stuck, but that might be a VirtualBox issue).

I then installed Homebrew and did brew install llvm, which should install llvm 18. The openssl@3 install failed due to one broken test (update: worked fine on the second try). openssl@3 is needed by a lot of other things, like brew install ccache (which also needs llvm@17 at the moment).

I'll continue to test, but the VM is excruciatingly slow...

Will update to drop the @14 if that works.

(feel free to mark as draft, I can't find the button)

Sjors · 2024-04-25T09:52:44Z

I was able to build bitcoind (didn't try QT) with llvm@17, but not with the current llvm 18.1.4. See log: https://gist.github.com/Sjors/194eb5d67e2e1132df7ff86f103ba16b

It's probably fine to drop @14 anyway, and maybe suggest trying lower versions if building fails. But it would be nice if there's a simple fix for this.

Regarding QT, interestingly Homebrew seems to handle that differently on old macOS versions than on new ones:

qt@5: A full installation of Xcode.app is required to compile
this software. Installing just the Command Line Tools is not sufficient.

I didn't need to install Xcode on macOS 13.6.6. People can either do that or use depends (update: I tested the latter, and ran into a similar error for the default llvm, while it worked fine for llvm@17).

Sjors · 2024-04-29T08:26:16Z

I dropped the @14 from the default instruction, but added a hint to try @17 if that fails. That worked when I tested and I don't expect Homebrew formulas for older versions to change much moving forward, nor llvm 17 itself.

DrahtBot · 2024-04-29T08:27:44Z

🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the
documentation.

Possibly this is due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.

Leave a comment here, if you need help tracking down a confusing failure.

_{Debug: https://github.com/bitcoin/bitcoin/runs/24365135335}

maflcko · 2024-04-29T08:34:47Z

utACK 2257404

TheCharlatan

ACK 2257404

Github-Pull: bitcoin#29934 Rebased-From: 2257404

fanquake · 2024-05-02T07:30:01Z

Backported in #29888.

bd5860b [WIP] doc: release notes for 27.x (fanquake) 475aac4 doc: add LLVM instruction for macOS < 13 (Sjors Provoost) a995902 depends: Fix build of Qt for 32-bit platforms (laanwj) 0fcceef Fix #29767, set m_synced = true after Commit() (nanlour) ae9a2ed sign: don't assume we are parsing a sane Miniscript (Antoine Poinsot) a6a59cf rpc: Reword SighashFromStr error message (MarcoFalke) 364bf01 build: Fix false positive `CHECK_ATOMIC` test for clang-15 (Hennadii Stepanov) 9277793 test: Fix failing univalue float test (MarcoFalke) 5c09791 doc: archive 27.0 release notes (fanquake) 897e5af [rpc, bugfix] Enforce maximum value for setmocktime (dergoegge) 602cfd5 ci: Bump s390x to ubuntu:24.04 (MarcoFalke) 20e6e8d Change Luke Dashjr seed to dashjr-list-of-p2p-nodes.us (Luke Dashjr) a6862c5 depends: fix mingw-w64 Qt DEBUG=1 build (fanquake) Pull request description: Backports: * #29691 * #29747 * #29776 * #29853 * #29856 * #29859 * #29869 * #29870 * #29886 * #29892 * #29934 * #29985 ACKs for top commit: willcl-ark: reACK bd5860b stickies-v: re-ACK bd5860b TheCharlatan: ACK bd5860b Tree-SHA512: a1a40de70cf52b5fc01d9dcc772421751a18c6a48a726c4c05c0371c585a53a27902e17daed9e0d721ab7763c94bb32de05c146bd6bc73fd558edd08b31e8547

, bitcoin#24337, bitcoin#27682, bitcoin#29208, bitcoin#29091, bitcoin#29165, bitcoin#29934, bitcoin#30261, partial bitcoin#27662, bitcoin#28210, bitcoin#28348, bitcoin#30263 (bump minimum compiler) 0861692 partial bitcoin#30263: Bump clang minimum supported version to 16 (Kittywhiskers Van Gogh) 5e7e563 merge bitcoin#30261: add release note for 29091 and 29165 (Kittywhiskers Van Gogh) 4d10993 merge bitcoin#29934: add LLVM instruction for macOS < 13 (Kittywhiskers Van Gogh) 7e4614a merge bitcoin#29165: Bump clang minimum supported version to 15 (Kittywhiskers Van Gogh) f397076 merge bitcoin#29091: Bump g++ minimum supported version to 11 (Kittywhiskers Van Gogh) 35d3357 merge bitcoin#29208: Bump clang minimum supported version to 14 (Kittywhiskers Van Gogh) c71e3df partial bitcoin#28348: Bump g++ minimum supported version to 10 (Kittywhiskers Van Gogh) b7da1ed partial bitcoin#28210: Bump clang minimum supported version to 13 (Kittywhiskers Van Gogh) 6b22832 partial bitcoin#27662: Bump minimum supported GCC to g++-9 (Kittywhiskers Van Gogh) f677769 merge bitcoin#27682: Bump minimum supported Clang to clang-10 (Kittywhiskers Van Gogh) f8e0339 docs: add `libgmp` as an optional dependency (Kittywhiskers Van Gogh) ebba607 docs: update version used to match `depends` (Kittywhiskers Van Gogh) 39b6f4b merge bitcoin#24337: Do not define `PROVIDE_FUZZ_MAIN_FUNCTION` macro unconditionally (Kittywhiskers Van Gogh) 2bd8422 merge bitcoin#23565: rewrite dependencies.md (Kittywhiskers Van Gogh) 56989ec merge bitcoin#24164: Bump minimum required clang/libc++ to 8.0 (Kittywhiskers Van Gogh) bac407f merge bitcoin#23060: increase minimum compiler and lib(std)c++ requirements (Kittywhiskers Van Gogh) Pull request description: ## Additional Information * Dependent on #6516 ## Breaking Changes GCC 11.1 or later, or Clang 16.0 or later, are now required to compile Dash Core. ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)** - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)** - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK 0861692 UdjinM6: utACK 0861692 Tree-SHA512: 6de3f8153482b4f379fd397dd3000688632356299c4f13a2f8af20d2f7337318bd3cd0b96182d6f378846b14981bc499ea32aa3d20cba6a0c7cf5f2a6e151937

DrahtBot added the Docs label Apr 22, 2024

Sjors mentioned this pull request Apr 22, 2024

build: Bump clang minimum supported version to 15 #29165

Merged

maflcko approved these changes Apr 22, 2024

View reviewed changes

doc/build-osx.md Outdated Show resolved Hide resolved

maflcko added the Needs backport (27.x) label Apr 22, 2024

maflcko reviewed Apr 22, 2024

View reviewed changes

doc/build-osx.md Show resolved Hide resolved

DrahtBot added CI failed and removed CI failed labels Apr 22, 2024

fanquake marked this pull request as draft April 24, 2024 09:33

Sjors force-pushed the 2024/04/clang-14-osx-old branch from c8cf11f to 13e1c61 Compare April 29, 2024 08:24

Sjors marked this pull request as ready for review April 29, 2024 08:24

Sjors force-pushed the 2024/04/clang-14-osx-old branch from 13e1c61 to b52bf8a Compare April 29, 2024 08:27

DrahtBot added the CI failed label Apr 29, 2024

doc: add LLVM instruction for macOS < 13

2257404

Sjors force-pushed the 2024/04/clang-14-osx-old branch from b52bf8a to 2257404 Compare April 29, 2024 08:33

DrahtBot requested a review from ismaelsadeeq April 29, 2024 08:34

DrahtBot removed the CI failed label Apr 29, 2024

TheCharlatan approved these changes Apr 30, 2024

View reviewed changes

fanquake merged commit 9d1a286 into bitcoin:master May 2, 2024

fanquake pushed a commit to fanquake/bitcoin that referenced this pull request May 2, 2024

doc: add LLVM instruction for macOS < 13

475aac4

Github-Pull: bitcoin#29934 Rebased-From: 2257404

fanquake removed the Needs backport (27.x) label May 2, 2024

fanquake mentioned this pull request May 2, 2024

[27.x] Backports #29888

Merged

maflcko mentioned this pull request Aug 14, 2024

refactor: Replace ParseHex with consteval ""_hex literals #30377

Merged

kwvg added a commit to kwvg/dash that referenced this pull request Nov 10, 2024

merge bitcoin#29934: add LLVM instruction for macOS < 13

d97214c

kwvg added a commit to kwvg/dash that referenced this pull request Jan 7, 2025

merge bitcoin#29934: add LLVM instruction for macOS < 13

6f174d9

kwvg added a commit to kwvg/dash that referenced this pull request Feb 5, 2025

merge bitcoin#29934: add LLVM instruction for macOS < 13

4d10993

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

doc: add LLVM instruction for macOS < 13 #29934

doc: add LLVM instruction for macOS < 13 #29934

Uh oh!

Sjors commented Apr 22, 2024 •

edited

Loading

Uh oh!

DrahtBot commented Apr 22, 2024 •

edited

Loading

Uh oh!

Sjors commented Apr 22, 2024

Uh oh!

maflcko left a comment

Uh oh!

Uh oh!

TheCharlatan commented Apr 22, 2024

Uh oh!

ismaelsadeeq commented Apr 22, 2024

Uh oh!

Uh oh!

Sjors commented Apr 23, 2024 •

edited

Loading

Uh oh!

Sjors commented Apr 25, 2024 •

edited

Loading

Uh oh!

Sjors commented Apr 29, 2024

Uh oh!

DrahtBot commented Apr 29, 2024

Uh oh!

maflcko commented Apr 29, 2024

Uh oh!

TheCharlatan left a comment

Uh oh!

fanquake commented May 2, 2024

Uh oh!

Uh oh!

doc: add LLVM instruction for macOS < 13 #29934

doc: add LLVM instruction for macOS < 13 #29934

Uh oh!

Conversation

Sjors commented Apr 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Apr 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage

Reviews

Uh oh!

Sjors commented Apr 22, 2024

Uh oh!

maflcko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TheCharlatan commented Apr 22, 2024

Uh oh!

ismaelsadeeq commented Apr 22, 2024

Uh oh!

Uh oh!

Sjors commented Apr 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sjors commented Apr 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sjors commented Apr 29, 2024

Uh oh!

DrahtBot commented Apr 29, 2024

Uh oh!

maflcko commented Apr 29, 2024

Uh oh!

TheCharlatan left a comment

Choose a reason for hiding this comment

Uh oh!

fanquake commented May 2, 2024

Uh oh!

Uh oh!

Sjors commented Apr 22, 2024 •

edited

Loading

DrahtBot commented Apr 22, 2024 •

edited

Loading

Sjors commented Apr 23, 2024 •

edited

Loading

Sjors commented Apr 25, 2024 •

edited

Loading