build: Bump minimum required clang/libc++ to 8.0 #24164
Conversation
|
Concept ACK. |
|
Concept ACK On a side note, I was wondering about one thing. Would this PR remain unmerged until v23.0 finally releases on April 1st? |
Until branching 23.x off, I guess. |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
faf1a2c to
fa9abc9
Compare
|
Rebased to get fresh CI. Fun fact: I couldn't compile current master with clang-7 and system libs on Bionic, so this could theoretically even be merged before 23.0 |
Is it similar to #21294 (comment)? |
fa9abc9 to
fad4a08
Compare
fad4a08 to
fa89172
Compare
There was a problem hiding this comment.
ACK fae20e6 - I think this is fine to do. I would be surprised if in another 6 months time someone was stuck on a system we supported, needing to compile Core, and only had access to Clang 7 or older. As mentioned in the PR description, all systems we currently support, already support multiple newer versions of Clang.
| @@ -7,7 +7,7 @@ These are the dependencies currently used by Bitcoin Core. You can find instruct | |||
| | --- | --- | --- | --- | --- | --- | | |||
| | Berkeley DB | [4.8.30](https://www.oracle.com/technetwork/database/database-technologies/berkeleydb/downloads/index.html) | 4.8.x | No | | | | |||
| | Boost | [1.77.0](https://www.boost.org/users/download/) | [1.64.0](https://github.com/bitcoin/bitcoin/pull/22320) | No | | | | |||
| | Clang<sup>[ \* ](#note1)</sup> | | [7.0](https://releases.llvm.org/download.html) (C++17 & std::filesystem support) | | | | | |||
| | Clang | | [8.0](https://releases.llvm.org/download.html) (C++17 & std::filesystem support) | | | | | |||
There was a problem hiding this comment.
| | Clang | | [8.0](https://releases.llvm.org/download.html) (C++17 & std::filesystem support) | | | | | |
| | Clang | | [8.0](https://releases.llvm.org/download.html) (C++17, std::filesystem, and P0083R3 support) | | | | |
There was a problem hiding this comment.
I don't think mentioning a paper in the dependencies will give users any useful information. If they are interested in this, they can use https://en.cppreference.com/w/cpp/compiler_support or the documentation of their compiler. Practically they should only care about the minimum required version.
We no-longer support Clang 7 (bitcoin#24164). This reverts commit e9189a7.
We no-longer support Clang 7 (bitcoin#24164). This reverts commit e9189a7.
We no-longer support Clang 7 (bitcoin#24164). This reverts commit e9189a7.
…upport" a7973bf Revert "build: more robustly check for fcf-protection support" (fanquake) Pull request description: We no-longer support Clang 7 (#24164). Introduced in #20720. This reverts commit e9189a7. ACKs for top commit: hebasto: re-ACK a7973bf Tree-SHA512: 82559637f21a97434ab29f908ebda1aada08b0786cbbf0b4d11085241942314c3f04261a624c5cd2cb3c94c99046b56626830da6b9775981ab4ba10d5979f998
…ction support" a7973bf Revert "build: more robustly check for fcf-protection support" (fanquake) Pull request description: We no-longer support Clang 7 (bitcoin#24164). Introduced in bitcoin#20720. This reverts commit e9189a7. ACKs for top commit: hebasto: re-ACK a7973bf Tree-SHA512: 82559637f21a97434ab29f908ebda1aada08b0786cbbf0b4d11085241942314c3f04261a624c5cd2cb3c94c99046b56626830da6b9775981ab4ba10d5979f998
This is not for 23.0, but for 24.0. It comes with the following benefits:
This should be fine, given that all supported operating systems ship with at least clang-10: