Skip to content

doc: Fix walletdisplayaddress RPC doc #22979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2021
Merged

doc: Fix walletdisplayaddress RPC doc #22979

merged 1 commit into from
Sep 16, 2021
+3 −2

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Sep 15, 2021

Previously the description was empty

@fanquake fanquake added the Docs label Sep 15, 2021
@maflcko maflcko requested a review from Sjors September 15, 2021 12:15
@maflcko maflcko mentioned this pull request Sep 15, 2021
Merged
fanquake
fanquake approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa22ddc

-walletdisplayaddress bitcoin address to display
+walletdisplayaddress "address"
 Display address on an external signer for verification.
 Arguments:
-1. address    (string, required)
+1. address    (string, required) bitcoin address to display
 
 Result:
 {                       (json object)

@fanquake fanquake merged commit bd5670e into bitcoin:master Sep 16, 2021
@maflcko maflcko deleted the 2109-rpcDocWallet branch September 16, 2021 07:39
@Sjors
Copy link
Member

Sjors commented Sep 16, 2021

Thanks, that must have been broken in a rebase.

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Sep 19, 2021
@fanquake
Merge bitcoin#22979: doc: Fix walletdisplayaddress RPC doc
00274c2
fanquake added a commit that referenced this pull request Nov 18, 2021
@fanquake
Merge #22981: doc: Fix incorrect C++ named args
606e306 
fac4947 doc: Fix incorrect C++ named args (MarcoFalke)

Pull request description:

  Incorrect named args are source of bugs, like #22979.

  Fix that by correcting them and adjust the format, so that clang-tidy can check it.

ACKs for top commit:
  fanquake:
    ACK fac4947 - `run-clang-tidy` works for me now.

Tree-SHA512: 2694e17a1586394baf30bbc479a913e4bad361221e8470b8739caf30aacea736befc73820f3fe56f6207d9f5d969323278d43a647f58c3497e8e44cad79f8934
This was referenced Nov 18, 2021
Closed
Merged
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 19, 2021
@fanquake
Merge bitcoin#22981: doc: Fix incorrect C++ named args
b7fb4bf 
fac4947 doc: Fix incorrect C++ named args (MarcoFalke)

Pull request description:

  Incorrect named args are source of bugs, like bitcoin#22979.

  Fix that by correcting them and adjust the format, so that clang-tidy can check it.

ACKs for top commit:
  fanquake:
    ACK fac4947 - `run-clang-tidy` works for me now.

Tree-SHA512: 2694e17a1586394baf30bbc479a913e4bad361221e8470b8739caf30aacea736befc73820f3fe56f6207d9f5d969323278d43a647f58c3497e8e44cad79f8934
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 19, 2021
@fanquake
Merge bitcoin#22981: doc: Fix incorrect C++ named args
31add26 
fac4947 doc: Fix incorrect C++ named args (MarcoFalke)

Pull request description:

  Incorrect named args are source of bugs, like bitcoin#22979.

  Fix that by correcting them and adjust the format, so that clang-tidy can check it.

ACKs for top commit:
  fanquake:
    ACK fac4947 - `run-clang-tidy` works for me now.

Tree-SHA512: 2694e17a1586394baf30bbc479a913e4bad361221e8470b8739caf30aacea736befc73820f3fe56f6207d9f5d969323278d43a647f58c3497e8e44cad79f8934
fanquake added a commit that referenced this pull request Dec 1, 2021
@fanquake
Merge #23546: scripted-diff: Use clang-tidy syntax for C++ named argu…
205877e 
…ments (tests only)

fa00447 scripted-diff: Use clang-tidy syntax for C++ named arguments (MarcoFalke)
fae13c3 doc: Use clang-tidy comments in crypto_tests (MarcoFalke)

Pull request description:

  Incorrect named args are source of bugs, like #22979.

  To allow them being checked by `clang-tidy`, use a format it can understand.

ACKs for top commit:
  shaavan:
    ACK fa00447
  rajarshimaitra:
    ACK fa00447
  jonatack:
    ACK fa00447
  fanquake:
    ACK fa00447

Tree-SHA512: 4d23a8363da81dfea21a4cd8516ab5e0dc70119e4d503f3f240f38573218b2c2e84083b97e956c62942d78b2f17490f8b3b2e8077d257644fda1d901e2b80507
@maflcko maflcko mentioned this pull request Dec 8, 2021
Merged
fanquake added a commit that referenced this pull request Dec 9, 2021
@fanquake
Merge #23703: scripted-diff: Use named args in RPC docs
7908772 
fa9aaf8 scripted-diff: Use named args in RPC docs (MarcoFalke)

Pull request description:

  Incorrect named args are source of bugs, like #22979.

  To allow them being checked by `clang-tidy`, use a format it can understand.

ACKs for top commit:
  fanquake:
    ACK fa9aaf8 - checked `clang-tidy` and it's fine here, (but throwing errors in other files. i.e `wallet/test/wallet_tests.cpp`).

Tree-SHA512: e09dae8ee999a5c4819e6f848c12139593ca0e915e645c8fabeb97c379188fb9104d286c02c71f590abc64cdec125f78026735f83e016111976baa49d588a9bc
This was referenced Mar 24, 2022
Merged
Merged
fanquake added a commit to bitcoin-core/gui that referenced this pull request Mar 25, 2022
@fanquake
Merge bitcoin/bitcoin#24665: doc: document clang tidy named args
2f0f056 
7e22d80 addrman: fix incorrect named args (fanquake)
67f654e doc: Document clang-tidy in dev notes (MarcoFalke)

Pull request description:

  The documentation, and a single commit extracted from #24661.

  Motivation:
  > Incorrect named args are source of bugs, like bitcoin/bitcoin#22979.

  > To allow them being checked by clang-tidy, use a format it can understand.

ACKs for top commit:
  glozow:
    ACK 7e22d80

Tree-SHA512: 4037fcea59fdf583b171bce7ad350299fe5f9feb3c398413432168f3b9a185e51884d5b30e4b4ab9c6c5bb896c178cfaee1d78d5b4f0034cd70121c9ea4184b7
@fanquake fanquake mentioned this pull request Mar 25, 2022
Merged
maflcko pushed a commit to bitcoin-core/gui that referenced this pull request Mar 28, 2022
Merge bitcoin/bitcoin#24677: refactor: fix wallet and related named args
9d00406 
21db4eb test: fix incorrect named args in wallet tests (fanquake)
8b0e776 test: fix incorrect named args in coin_selection tests (fanquake)
6fc00f7 bench: fix incorrect named args in coin_selection bench (fanquake)

Pull request description:

  Should be one of the last changes split from #24661.

  Motivation:
  > Incorrect named args are source of bugs, like bitcoin/bitcoin#22979.

  > To allow them being checked by clang-tidy, use a format it can understand.

ACKs for top commit:
  MarcoFalke:
    Concept ACK 21db4eb

Tree-SHA512: c29743a70f6118cf73dc37b56b30f45da55b7d7b3b8ed36859ad59f602c3e6692eb755e05d9a4dd17f05085bcd6cb5b8c4007090a76e4fbfb053f925322cf985
@fanquake fanquake mentioned this pull request Mar 31, 2022
Merged
maflcko pushed a commit to bitcoin-core/gui that referenced this pull request Apr 1, 2022
Merge bitcoin/bitcoin#24724: test: fix incorrect named args in txpack…
7ab9fc3 
…age tests

bf77fea test: fix incorrect named args in txpackage tests (fanquake)

Pull request description:

  Final non-scripted-diff commit split from #24661.

  Could be tested with: `./autogen.sh && ./configure CC=clang-12 CXX=clang++-12 && make clean && bear make -j9 && ( cd ./src/ && run-clang-tidy-12 -j9 )`.

  Motivation:
  > Incorrect named args are source of bugs, like bitcoin/bitcoin#22979.

  > To allow them being checked by clang-tidy, use a format it can understand.

ACKs for top commit:
  ajtowns:
    ACK bf77fea

Tree-SHA512: a13bfb5fc70424b13fbeec7f164d7a0d3b72b27ebec11dfd4115b7782a0037f26e9349e06eef8a6b17b8f529e0c7f43ae37a9c252bde65706dd164704d207d5f
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 2, 2022
@fanquake
Merge bitcoin#24665: doc: document clang tidy named args
24a5e0f 
7e22d80 addrman: fix incorrect named args (fanquake)
67f654e doc: Document clang-tidy in dev notes (MarcoFalke)

Pull request description:

  The documentation, and a single commit extracted from bitcoin#24661.

  Motivation:
  > Incorrect named args are source of bugs, like bitcoin#22979.

  > To allow them being checked by clang-tidy, use a format it can understand.

ACKs for top commit:
  glozow:
    ACK 7e22d80

Tree-SHA512: 4037fcea59fdf583b171bce7ad350299fe5f9feb3c398413432168f3b9a185e51884d5b30e4b4ab9c6c5bb896c178cfaee1d78d5b4f0034cd70121c9ea4184b7
maflcko pushed a commit to bitcoin-core/gui that referenced this pull request Apr 4, 2022
Merge bitcoin/bitcoin#24661: refactor: Use clang-tidy syntax for C++ …
0da559e 
…named arguments

37a16ff refactor: fix clang-tidy named args usage (fanquake)

Pull request description:

  > Incorrect named args are source of bugs, like bitcoin/bitcoin#22979.

  > To allow them being checked by clang-tidy, use a format it can understand.

  Picks up #23545, with some additional changes and some feedback addressed.

  With these changes invoking `./autogen.sh && ./configure CC=clang-12 CXX=clang++-12 && make clean && bear make -j9 && ( cd ./src/ && run-clang-tidy-12 -j9 )` no-longer results in named argument errors out of `clang-tidy`.

  Ultimately I think we should just add `clang-tidy-*` jobs to the CI and automate things away.

ACKs for top commit:
  MarcoFalke:
    cr ACK 37a16ff

Tree-SHA512: 9bfc0d006eb187755b4fdb0bd92cee9266fc0816be42065ef7dcd885b9020ff12e3cdd7ca3a831613a56a0206d448e690ee4e1fa37628fa2013860e17f416ff3
@bitcoin bitcoin locked and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fanquake fanquake fanquake approved these changes

@Sjors Sjors Awaiting requested review from Sjors

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maflcko @Sjors @fanquake