Skip to content

test: fix incorrect named args in txpackage tests #24724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2022
Merged

test: fix incorrect named args in txpackage tests #24724

merged 1 commit into from
Apr 1, 2022

Conversation

fanquake
Copy link
Member

Final non-scripted-diff commit split from #24661.

Could be tested with: ./autogen.sh && ./configure CC=clang-12 CXX=clang++-12 && make clean && bear make -j9 && ( cd ./src/ && run-clang-tidy-12 -j9 ).

Motivation:

Incorrect named args are source of bugs, like #22979.

To allow them being checked by clang-tidy, use a format it can understand.

@fanquake fanquake requested review from maflcko and glozow March 31, 2022 15:35
@ajtowns
Copy link
Contributor

ajtowns commented Apr 1, 2022

ACK bf77fea

@maflcko maflcko merged commit 7ab9fc3 into bitcoin:master Apr 1, 2022
@fanquake fanquake deleted the txpackage_named_args branch April 1, 2022 07:26
@fanquake fanquake mentioned this pull request Apr 1, 2022
Merged
@fanquake fanquake removed request for maflcko and glozow April 1, 2022 08:51
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 3, 2022
Merge bitcoin#24724: test: fix incorrect named args in txpackage tests
85407b7
@bitcoin bitcoin locked and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fanquake @ajtowns @maflcko