Skip to content

refactor: fix wallet and related named args #24677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2022
Merged

refactor: fix wallet and related named args #24677

merged 3 commits into from
Mar 28, 2022

Conversation

fanquake
Copy link
Member

Should be one of the last changes split from #24661.

Motivation:

Incorrect named args are source of bugs, like #22979.

To allow them being checked by clang-tidy, use a format it can understand.

@fanquake fanquake requested a review from maflcko March 25, 2022 21:30
@maflcko
Copy link
Member

maflcko commented Mar 28, 2022

Concept ACK 21db4eb

@maflcko maflcko merged commit 9d00406 into bitcoin:master Mar 28, 2022
@fanquake fanquake deleted the fix_wallet_and_co_named_args branch March 28, 2022 13:01
@bitcoin bitcoin locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maflcko maflcko Awaiting requested review from maflcko

Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fanquake @maflcko