-
Notifications
You must be signed in to change notification settings - Fork 37.7k
doc: update tor.md, release notes with removal of tor v2 support #22172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ACK 83d75d2 |
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
ACK 83d75d2, looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 83d75d2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 83d75d2
doc/release-notes.md
Outdated
Tor version 0.4.6. Henceforth, Bitcoin Core ignores Tor v2 addresses; it | ||
neither rumors them over the network to other peers nor stores them in memory | ||
or to `peers.dat`. Tor v2 addresses are ignored by | ||
`contrib/seeds/generate-seeds.py` and have been removed from the hard-coded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think changes to maintainer-facing tools such as generate-seeds
need to be in the release notes. Not a big deal though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, removed.
FWIW if #22179 is merged, I planned to append its PR number to this entry manually in the wiki.
83d75d2
to
2ad034a
Compare
ACK 2ad034a |
Combination of upstream's bitcoin#19961, bitcoin#21753 and bitcoin#22172
Combination of upstream's bitcoin#19961, bitcoin#21753 and bitcoin#22172
Combination of upstream's bitcoin#19961, bitcoin#21753 and bitcoin#22172
Combination of upstream's bitcoin#19961, bitcoin#21753 and bitcoin#22172
Combination of upstream's bitcoin#19961, bitcoin#21753 and bitcoin#22172
Combination of upstream's bitcoin#19961, bitcoin#21753 and bitcoin#22172
Combination of upstream's bitcoin#19961, bitcoin#21753 and bitcoin#22172
Combination of upstream's bitcoin#19961, bitcoin#21753 and bitcoin#22172
Follow-up documentation to #22050 that removed support for Tor version 2 hidden services from Bitcoin Core.