Skip to content

Conversation

jonatack
Copy link
Member

@jonatack jonatack commented Jun 6, 2021

Follow-up documentation to #22050 that removed support for Tor version 2 hidden services from Bitcoin Core.

@DrahtBot DrahtBot added the Docs label Jun 6, 2021
@jarolrod
Copy link
Member

jarolrod commented Jun 6, 2021

ACK 83d75d2

@DrahtBot
Copy link
Contributor

DrahtBot commented Jun 6, 2021

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@Zero-1729
Copy link
Contributor

Zero-1729 commented Jun 7, 2021

ACK 83d75d2, looks good.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 83d75d2

Copy link
Contributor

@klementtan klementtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 83d75d2

Tor version 0.4.6. Henceforth, Bitcoin Core ignores Tor v2 addresses; it
neither rumors them over the network to other peers nor stores them in memory
or to `peers.dat`. Tor v2 addresses are ignored by
`contrib/seeds/generate-seeds.py` and have been removed from the hard-coded
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think changes to maintainer-facing tools such as generate-seeds need to be in the release notes. Not a big deal though.

Copy link
Member Author

@jonatack jonatack Jun 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, removed.

FWIW if #22179 is merged, I planned to append its PR number to this entry manually in the wiki.

@jonatack jonatack force-pushed the tor-v2-removal-documentation branch from 83d75d2 to 2ad034a Compare June 12, 2021 10:09
@laanwj
Copy link
Member

laanwj commented Jun 12, 2021

ACK 2ad034a

@laanwj laanwj merged commit 4bff49b into bitcoin:master Jun 12, 2021
@jonatack jonatack deleted the tor-v2-removal-documentation branch June 12, 2021 10:26
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 13, 2021
furszy added a commit to furszy/bitcoin-core that referenced this pull request Jul 29, 2021
furszy added a commit to furszy/bitcoin-core that referenced this pull request Jul 30, 2021
furszy added a commit to furszy/bitcoin-core that referenced this pull request Jul 31, 2021
furszy added a commit to furszy/bitcoin-core that referenced this pull request Aug 1, 2021
furszy added a commit to furszy/bitcoin-core that referenced this pull request Aug 4, 2021
furszy added a commit to furszy/bitcoin-core that referenced this pull request Aug 5, 2021
furszy added a commit to furszy/bitcoin-core that referenced this pull request Aug 8, 2021
furszy added a commit to furszy/bitcoin-core that referenced this pull request Aug 10, 2021
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants