Skip to content

Conversation

jonatack
Copy link
Member

Follow-up to #21595.

@fanquake fanquake added the Docs label Apr 22, 2021
Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

Add addrinfo to the list of options

- in the output of the CLI `-netinfo` peer connections dashboard

  - in the output of the CLI `-netinfo` peer connections dashboard
+ - in the output of the CLI `-addrinfo` command

Then your paragraph is an explanation of this option much like lines 15&16 are for the debug log option.

@jonatack
Copy link
Member Author

Concept ACK

Add addrinfo to the list of options

Thanks for having a look! That list is of ways to see your local onion address, so it seems to me that this is a different topic and use context and doesn't belong in that list.

@jarolrod
Copy link
Member

ACK 65f30e4

That list is of ways to see your local onion address, so it seems to me that this is a different topic and use context and doesn't belong in that list.

Right, whoops! 🥃

Copy link
Contributor

@RiccardoMasutti RiccardoMasutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@practicalswift
Copy link
Contributor

ACK 65f30e4

Thanks for improving documentation!

Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
ACK 65f30e4

@DrahtBot
Copy link
Contributor

DrahtBot commented May 3, 2021

🕵️ @harding has been requested to review this pull request as specified in the REVIEWERS file.

@0xB10C
Copy link
Contributor

0xB10C commented May 5, 2021

ACK 65f30e4

@laanwj laanwj merged commit 23109cc into bitcoin:master May 5, 2021
@jonatack jonatack deleted the tor-doc-addrinfo branch May 5, 2021 13:54
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 5, 2021
65f30e4 doc: add -addrinfo troubleshooting section to tor.md (Jon Atack)

Pull request description:

  Follow-up to bitcoin#21595.

ACKs for top commit:
  jarolrod:
    ACK 65f30e4
  practicalswift:
    ACK 65f30e4
  0xB10C:
    ACK 65f30e4
  theStack:
    ACK 65f30e4

Tree-SHA512: d17fa007106b8f877d2632c99273c663a24f025febe52faec9b197c561df808fd6a92bb27992ccbf5c3cc0d82058a8c4b82a2f1b99325f0ddfdac5ef703ac7d7
furszy added a commit to furszy/bitcoin-core that referenced this pull request Jul 29, 2021
furszy added a commit to furszy/bitcoin-core that referenced this pull request Jul 30, 2021
furszy added a commit to furszy/bitcoin-core that referenced this pull request Jul 31, 2021
furszy added a commit to furszy/bitcoin-core that referenced this pull request Aug 1, 2021
furszy added a commit to furszy/bitcoin-core that referenced this pull request Aug 4, 2021
furszy added a commit to furszy/bitcoin-core that referenced this pull request Aug 5, 2021
furszy added a commit to furszy/bitcoin-core that referenced this pull request Aug 8, 2021
furszy added a commit to furszy/bitcoin-core that referenced this pull request Aug 10, 2021
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Mar 5, 2022
65f30e4 doc: add -addrinfo troubleshooting section to tor.md (Jon Atack)

Pull request description:

  Follow-up to bitcoin#21595.

ACKs for top commit:
  jarolrod:
    ACK 65f30e4
  practicalswift:
    ACK 65f30e4
  0xB10C:
    ACK 65f30e4
  theStack:
    ACK 65f30e4

Tree-SHA512: d17fa007106b8f877d2632c99273c663a24f025febe52faec9b197c561df808fd6a92bb27992ccbf5c3cc0d82058a8c4b82a2f1b99325f0ddfdac5ef703ac7d7
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Mar 5, 2022
65f30e4 doc: add -addrinfo troubleshooting section to tor.md (Jon Atack)

Pull request description:

  Follow-up to bitcoin#21595.

ACKs for top commit:
  jarolrod:
    ACK 65f30e4
  practicalswift:
    ACK 65f30e4
  0xB10C:
    ACK 65f30e4
  theStack:
    ACK 65f30e4

Tree-SHA512: d17fa007106b8f877d2632c99273c663a24f025febe52faec9b197c561df808fd6a92bb27992ccbf5c3cc0d82058a8c4b82a2f1b99325f0ddfdac5ef703ac7d7
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Mar 5, 2022
65f30e4 doc: add -addrinfo troubleshooting section to tor.md (Jon Atack)

Pull request description:

  Follow-up to bitcoin#21595.

ACKs for top commit:
  jarolrod:
    ACK 65f30e4
  practicalswift:
    ACK 65f30e4
  0xB10C:
    ACK 65f30e4
  theStack:
    ACK 65f30e4

Tree-SHA512: d17fa007106b8f877d2632c99273c663a24f025febe52faec9b197c561df808fd6a92bb27992ccbf5c3cc0d82058a8c4b82a2f1b99325f0ddfdac5ef703ac7d7
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants