-
Notifications
You must be signed in to change notification settings - Fork 37.8k
doc: add -addrinfo to tor docs #21753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK
Add addrinfo
to the list of options
Line 13 in 65f30e4
- in the output of the CLI `-netinfo` peer connections dashboard |
- in the output of the CLI `-netinfo` peer connections dashboard
+ - in the output of the CLI `-addrinfo` command
Then your paragraph is an explanation of this option much like lines 15&16 are for the debug log option.
Thanks for having a look! That list is of ways to see your local onion address, so it seems to me that this is a different topic and use context and doesn't belong in that list. |
ACK 65f30e4
Right, whoops! 🥃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
ACK 65f30e4 Thanks for improving documentation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
ACK 65f30e4
🕵️ @harding has been requested to review this pull request as specified in the REVIEWERS file. |
ACK 65f30e4 |
65f30e4 doc: add -addrinfo troubleshooting section to tor.md (Jon Atack) Pull request description: Follow-up to bitcoin#21595. ACKs for top commit: jarolrod: ACK 65f30e4 practicalswift: ACK 65f30e4 0xB10C: ACK 65f30e4 theStack: ACK 65f30e4 Tree-SHA512: d17fa007106b8f877d2632c99273c663a24f025febe52faec9b197c561df808fd6a92bb27992ccbf5c3cc0d82058a8c4b82a2f1b99325f0ddfdac5ef703ac7d7
Combination of upstream's bitcoin#19961, bitcoin#21753 and bitcoin#22172
Combination of upstream's bitcoin#19961, bitcoin#21753 and bitcoin#22172
Combination of upstream's bitcoin#19961, bitcoin#21753 and bitcoin#22172
Combination of upstream's bitcoin#19961, bitcoin#21753 and bitcoin#22172
Combination of upstream's bitcoin#19961, bitcoin#21753 and bitcoin#22172
Combination of upstream's bitcoin#19961, bitcoin#21753 and bitcoin#22172
Combination of upstream's bitcoin#19961, bitcoin#21753 and bitcoin#22172
Combination of upstream's bitcoin#19961, bitcoin#21753 and bitcoin#22172
65f30e4 doc: add -addrinfo troubleshooting section to tor.md (Jon Atack) Pull request description: Follow-up to bitcoin#21595. ACKs for top commit: jarolrod: ACK 65f30e4 practicalswift: ACK 65f30e4 0xB10C: ACK 65f30e4 theStack: ACK 65f30e4 Tree-SHA512: d17fa007106b8f877d2632c99273c663a24f025febe52faec9b197c561df808fd6a92bb27992ccbf5c3cc0d82058a8c4b82a2f1b99325f0ddfdac5ef703ac7d7
65f30e4 doc: add -addrinfo troubleshooting section to tor.md (Jon Atack) Pull request description: Follow-up to bitcoin#21595. ACKs for top commit: jarolrod: ACK 65f30e4 practicalswift: ACK 65f30e4 0xB10C: ACK 65f30e4 theStack: ACK 65f30e4 Tree-SHA512: d17fa007106b8f877d2632c99273c663a24f025febe52faec9b197c561df808fd6a92bb27992ccbf5c3cc0d82058a8c4b82a2f1b99325f0ddfdac5ef703ac7d7
65f30e4 doc: add -addrinfo troubleshooting section to tor.md (Jon Atack) Pull request description: Follow-up to bitcoin#21595. ACKs for top commit: jarolrod: ACK 65f30e4 practicalswift: ACK 65f30e4 0xB10C: ACK 65f30e4 theStack: ACK 65f30e4 Tree-SHA512: d17fa007106b8f877d2632c99273c663a24f025febe52faec9b197c561df808fd6a92bb27992ccbf5c3cc0d82058a8c4b82a2f1b99325f0ddfdac5ef703ac7d7
Follow-up to #21595.