Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Apr 3, 2024

It was overlooked in #29787.

@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 3, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #29790 ([DO NOT MERGE] cmake: Migrate CI scripts to CMake-based build system -- WIP by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@fanquake
Copy link
Member

fanquake commented Apr 3, 2024

Guix Build (aarch64):

8e7bddb8fa49c857bc9a815a7f27f2d60f8a2f8955966eff467ee86c0d0776f6  guix-build-3cb80febb876/output/aarch64-linux-gnu/SHA256SUMS.part
de0c0624b55418b6638b4852cbe4527c5fb4a2ccbb82d442e5dff0febc947a70  guix-build-3cb80febb876/output/aarch64-linux-gnu/bitcoin-3cb80febb876-aarch64-linux-gnu-debug.tar.gz
5f37064b7496125b90f7df1fda7df3e6545149274bf737361579c0e9be94f6f8  guix-build-3cb80febb876/output/aarch64-linux-gnu/bitcoin-3cb80febb876-aarch64-linux-gnu.tar.gz
02ad1363865d1d8254341aa6419937f6b4babab1d04c9c4fbccff073dc7df37a  guix-build-3cb80febb876/output/arm-linux-gnueabihf/SHA256SUMS.part
ba6f698492dd465dec6fc487a0fbf535975783b1a45871efb108f57d62d64229  guix-build-3cb80febb876/output/arm-linux-gnueabihf/bitcoin-3cb80febb876-arm-linux-gnueabihf-debug.tar.gz
46f04ccbe91189187d8e4e469cf4510bd69333b56a11f222a6af9b0ebb000059  guix-build-3cb80febb876/output/arm-linux-gnueabihf/bitcoin-3cb80febb876-arm-linux-gnueabihf.tar.gz
63bbcfbd6121b54363b2bb1f051a8575272bb201b30235791615b37461121c39  guix-build-3cb80febb876/output/arm64-apple-darwin/SHA256SUMS.part
21588e308b9abf4a13fa2372473ef67a466e8228b9c2b2b08261e20579f91831  guix-build-3cb80febb876/output/arm64-apple-darwin/bitcoin-3cb80febb876-arm64-apple-darwin-unsigned.tar.gz
8def823db7a58971b4481a0d088cdaaf7269f254e950d0375565eb8afd9fa479  guix-build-3cb80febb876/output/arm64-apple-darwin/bitcoin-3cb80febb876-arm64-apple-darwin-unsigned.zip
a12ee832928a41fcfac9cca34cebc70f4699af478f216118bc1de564ea4d5454  guix-build-3cb80febb876/output/arm64-apple-darwin/bitcoin-3cb80febb876-arm64-apple-darwin.tar.gz
75fc5fe9a4358bc19258a46190231622d6b6c62009200fa574ea50188eb89f5d  guix-build-3cb80febb876/output/dist-archive/bitcoin-3cb80febb876.tar.gz
1a738ee302c99aca5fe9bc74e798116480682968a10a272fc86a4c8ff0ae7d42  guix-build-3cb80febb876/output/powerpc64-linux-gnu/SHA256SUMS.part
331ad9c0d4a898bc7cc97a3832e9b5dc22c026837e5eae52db1c840344651cc8  guix-build-3cb80febb876/output/powerpc64-linux-gnu/bitcoin-3cb80febb876-powerpc64-linux-gnu-debug.tar.gz
b19a08f11bff557e838a9b2ea1a6f6b814d392ba27d72f871236eb208fbb1278  guix-build-3cb80febb876/output/powerpc64-linux-gnu/bitcoin-3cb80febb876-powerpc64-linux-gnu.tar.gz
fc17d0a502a13e24ebd38eb614675d355e4d6c16855eb620fec7ef3272e2da6d  guix-build-3cb80febb876/output/riscv64-linux-gnu/SHA256SUMS.part
77516f1ff1dbb19ced4c7c3290c64af654e014c25a60c539758671b84176951c  guix-build-3cb80febb876/output/riscv64-linux-gnu/bitcoin-3cb80febb876-riscv64-linux-gnu-debug.tar.gz
26c5395f45f7f683943390d87292dbce9027aba6a2a8fcee10c7140e13620312  guix-build-3cb80febb876/output/riscv64-linux-gnu/bitcoin-3cb80febb876-riscv64-linux-gnu.tar.gz
78e086c38287aa74e9a3733fda125d06467a0be4518435f3cd1852011966f8b3  guix-build-3cb80febb876/output/x86_64-apple-darwin/SHA256SUMS.part
48ad5212c75f4aeb1d743b775d4febc561f544829e06c0bc27a03f6e4a353185  guix-build-3cb80febb876/output/x86_64-apple-darwin/bitcoin-3cb80febb876-x86_64-apple-darwin-unsigned.tar.gz
2058426b5e4dc03876b2e7b842d4d2d34c5a03b22bac24440c302e70e25738be  guix-build-3cb80febb876/output/x86_64-apple-darwin/bitcoin-3cb80febb876-x86_64-apple-darwin-unsigned.zip
fa5dafe5f852e43a2e88ffc8f3d7bd0c05d2d798c05491a6e09ab218fa3982ae  guix-build-3cb80febb876/output/x86_64-apple-darwin/bitcoin-3cb80febb876-x86_64-apple-darwin.tar.gz
f4d09e96be98dd628dde208c98d238a2f8c605f2a40f37164219d9feecf62cfc  guix-build-3cb80febb876/output/x86_64-linux-gnu/SHA256SUMS.part
d1fca2b29b95ea00ea5e0397dde818f69ac0765ccce19b09aa1a2dafd574f5fb  guix-build-3cb80febb876/output/x86_64-linux-gnu/bitcoin-3cb80febb876-x86_64-linux-gnu-debug.tar.gz
c51f71904b832031cdc7172082f1b2ebd13dd1d4ac97fd5acc8b0ebc1075ea19  guix-build-3cb80febb876/output/x86_64-linux-gnu/bitcoin-3cb80febb876-x86_64-linux-gnu.tar.gz
6aff9c64b0e1430cf85b7ae1b15276983db6e7249345fd1bc8bba6072fa06fcc  guix-build-3cb80febb876/output/x86_64-w64-mingw32/SHA256SUMS.part
25a581e77997c050ffd6a0e3d3a323359c83462d619bed162744b02d58d66bea  guix-build-3cb80febb876/output/x86_64-w64-mingw32/bitcoin-3cb80febb876-win64-debug.zip
2e81ebfdda16e2c93f4e543856c2c420d9783d27ff5c2346a9d07b92f3725af3  guix-build-3cb80febb876/output/x86_64-w64-mingw32/bitcoin-3cb80febb876-win64-setup-unsigned.exe
26b81d0debf5d07350fd27cf9f7786f11c0b729b60573439644a3c06dced2f6f  guix-build-3cb80febb876/output/x86_64-w64-mingw32/bitcoin-3cb80febb876-win64-unsigned.tar.gz
dae9a21bb764608444ceda8e5008911c046f8a3f522a485fe65c5ac636ca1250  guix-build-3cb80febb876/output/x86_64-w64-mingw32/bitcoin-3cb80febb876-win64.zip

Copy link
Contributor

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3cb80fe

Guix build (x86_64):

8e7bddb8fa49c857bc9a815a7f27f2d60f8a2f8955966eff467ee86c0d0776f6  guix-build-3cb80febb876/output/aarch64-linux-gnu/SHA256SUMS.part
de0c0624b55418b6638b4852cbe4527c5fb4a2ccbb82d442e5dff0febc947a70  guix-build-3cb80febb876/output/aarch64-linux-gnu/bitcoin-3cb80febb876-aarch64-linux-gnu-debug.tar.gz
5f37064b7496125b90f7df1fda7df3e6545149274bf737361579c0e9be94f6f8  guix-build-3cb80febb876/output/aarch64-linux-gnu/bitcoin-3cb80febb876-aarch64-linux-gnu.tar.gz
02ad1363865d1d8254341aa6419937f6b4babab1d04c9c4fbccff073dc7df37a  guix-build-3cb80febb876/output/arm-linux-gnueabihf/SHA256SUMS.part
ba6f698492dd465dec6fc487a0fbf535975783b1a45871efb108f57d62d64229  guix-build-3cb80febb876/output/arm-linux-gnueabihf/bitcoin-3cb80febb876-arm-linux-gnueabihf-debug.tar.gz
46f04ccbe91189187d8e4e469cf4510bd69333b56a11f222a6af9b0ebb000059  guix-build-3cb80febb876/output/arm-linux-gnueabihf/bitcoin-3cb80febb876-arm-linux-gnueabihf.tar.gz
63bbcfbd6121b54363b2bb1f051a8575272bb201b30235791615b37461121c39  guix-build-3cb80febb876/output/arm64-apple-darwin/SHA256SUMS.part
21588e308b9abf4a13fa2372473ef67a466e8228b9c2b2b08261e20579f91831  guix-build-3cb80febb876/output/arm64-apple-darwin/bitcoin-3cb80febb876-arm64-apple-darwin-unsigned.tar.gz
8def823db7a58971b4481a0d088cdaaf7269f254e950d0375565eb8afd9fa479  guix-build-3cb80febb876/output/arm64-apple-darwin/bitcoin-3cb80febb876-arm64-apple-darwin-unsigned.zip
a12ee832928a41fcfac9cca34cebc70f4699af478f216118bc1de564ea4d5454  guix-build-3cb80febb876/output/arm64-apple-darwin/bitcoin-3cb80febb876-arm64-apple-darwin.tar.gz
75fc5fe9a4358bc19258a46190231622d6b6c62009200fa574ea50188eb89f5d  guix-build-3cb80febb876/output/dist-archive/bitcoin-3cb80febb876.tar.gz
1a738ee302c99aca5fe9bc74e798116480682968a10a272fc86a4c8ff0ae7d42  guix-build-3cb80febb876/output/powerpc64-linux-gnu/SHA256SUMS.part
331ad9c0d4a898bc7cc97a3832e9b5dc22c026837e5eae52db1c840344651cc8  guix-build-3cb80febb876/output/powerpc64-linux-gnu/bitcoin-3cb80febb876-powerpc64-linux-gnu-debug.tar.gz
b19a08f11bff557e838a9b2ea1a6f6b814d392ba27d72f871236eb208fbb1278  guix-build-3cb80febb876/output/powerpc64-linux-gnu/bitcoin-3cb80febb876-powerpc64-linux-gnu.tar.gz
fc17d0a502a13e24ebd38eb614675d355e4d6c16855eb620fec7ef3272e2da6d  guix-build-3cb80febb876/output/riscv64-linux-gnu/SHA256SUMS.part
77516f1ff1dbb19ced4c7c3290c64af654e014c25a60c539758671b84176951c  guix-build-3cb80febb876/output/riscv64-linux-gnu/bitcoin-3cb80febb876-riscv64-linux-gnu-debug.tar.gz
26c5395f45f7f683943390d87292dbce9027aba6a2a8fcee10c7140e13620312  guix-build-3cb80febb876/output/riscv64-linux-gnu/bitcoin-3cb80febb876-riscv64-linux-gnu.tar.gz
78e086c38287aa74e9a3733fda125d06467a0be4518435f3cd1852011966f8b3  guix-build-3cb80febb876/output/x86_64-apple-darwin/SHA256SUMS.part
48ad5212c75f4aeb1d743b775d4febc561f544829e06c0bc27a03f6e4a353185  guix-build-3cb80febb876/output/x86_64-apple-darwin/bitcoin-3cb80febb876-x86_64-apple-darwin-unsigned.tar.gz
2058426b5e4dc03876b2e7b842d4d2d34c5a03b22bac24440c302e70e25738be  guix-build-3cb80febb876/output/x86_64-apple-darwin/bitcoin-3cb80febb876-x86_64-apple-darwin-unsigned.zip
fa5dafe5f852e43a2e88ffc8f3d7bd0c05d2d798c05491a6e09ab218fa3982ae  guix-build-3cb80febb876/output/x86_64-apple-darwin/bitcoin-3cb80febb876-x86_64-apple-darwin.tar.gz
f4d09e96be98dd628dde208c98d238a2f8c605f2a40f37164219d9feecf62cfc  guix-build-3cb80febb876/output/x86_64-linux-gnu/SHA256SUMS.part
d1fca2b29b95ea00ea5e0397dde818f69ac0765ccce19b09aa1a2dafd574f5fb  guix-build-3cb80febb876/output/x86_64-linux-gnu/bitcoin-3cb80febb876-x86_64-linux-gnu-debug.tar.gz
c51f71904b832031cdc7172082f1b2ebd13dd1d4ac97fd5acc8b0ebc1075ea19  guix-build-3cb80febb876/output/x86_64-linux-gnu/bitcoin-3cb80febb876-x86_64-linux-gnu.tar.gz
6aff9c64b0e1430cf85b7ae1b15276983db6e7249345fd1bc8bba6072fa06fcc  guix-build-3cb80febb876/output/x86_64-w64-mingw32/SHA256SUMS.part
25a581e77997c050ffd6a0e3d3a323359c83462d619bed162744b02d58d66bea  guix-build-3cb80febb876/output/x86_64-w64-mingw32/bitcoin-3cb80febb876-win64-debug.zip
2e81ebfdda16e2c93f4e543856c2c420d9783d27ff5c2346a9d07b92f3725af3  guix-build-3cb80febb876/output/x86_64-w64-mingw32/bitcoin-3cb80febb876-win64-setup-unsigned.exe
26b81d0debf5d07350fd27cf9f7786f11c0b729b60573439644a3c06dced2f6f  guix-build-3cb80febb876/output/x86_64-w64-mingw32/bitcoin-3cb80febb876-win64-unsigned.tar.gz
dae9a21bb764608444ceda8e5008911c046f8a3f522a485fe65c5ac636ca1250  guix-build-3cb80febb876/output/x86_64-w64-mingw32/bitcoin-3cb80febb876-win64.zip

@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 4, 2024

Guix builds (on x86_64)

File commit 0d509ba
(master)
commit 1f28087
(master and this pull)
SHA256SUMS.part 57367c5046548ab7... e3d96d2500499909...
*-aarch64-linux-gnu-debug.tar.gz 6fc0d9eb907cbe3b... 8978b3ad8832aa9b...
*-aarch64-linux-gnu.tar.gz 510ba1e2d2fed935... 418a4e8ab271bc4b...
*-arm-linux-gnueabihf-debug.tar.gz a63e94885251d908... 28cc239eedfda159...
*-arm-linux-gnueabihf.tar.gz 10a97e1dbda0e903... 91d2424d85614787...
*-arm64-apple-darwin-unsigned.tar.gz 026da693ccfde1b9... 8cd78b0df970139c...
*-arm64-apple-darwin-unsigned.zip 5faab1eac8d985f9... 79286a9887eaf26f...
*-arm64-apple-darwin.tar.gz b598e13c6fc87fd0... be04bf2d5d46cd36...
*-powerpc64-linux-gnu-debug.tar.gz 4dabd4d9c17aeff0... f1f9cf7cc0676945...
*-powerpc64-linux-gnu.tar.gz ca12511db36e1b1e... ce02ea903ad45fe2...
*-riscv64-linux-gnu-debug.tar.gz c270ec189d5c018f... aefbb1a1c124eda3...
*-riscv64-linux-gnu.tar.gz ffbbfc24eb22e259... 16332419080ff229...
*-x86_64-apple-darwin-unsigned.tar.gz ea74ca7bbad9099f... e936cd16b1dda91f...
*-x86_64-apple-darwin-unsigned.zip 3e7fb5c0fe93a09e... 5ab08756284dd8ba...
*-x86_64-apple-darwin.tar.gz 77a25a618e292e32... 118f20469df04d0e...
*-x86_64-linux-gnu-debug.tar.gz 8fc0abe925283ef5... 19a3bf35e0548e7a...
*-x86_64-linux-gnu.tar.gz 86fa98de83cf8825... f516eb9623003bb0...
*.tar.gz 85d0a019efccd991... 25785e9fde397513...
guix_build.log 6473b4b331c5f65a... baf609ec7ad50598...
guix_build.log.diff 8400e8a57f31525c...

@fanquake fanquake merged commit 3900854 into bitcoin:master Apr 4, 2024
@hebasto hebasto deleted the 240403-clean-guix branch April 4, 2024 09:09
Pttn added a commit to RiecoinTeam/Riecoin that referenced this pull request Apr 13, 2024
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Oct 25, 2024
3cb80fe guix: Remove another leftover from bitcoin#29648 (Hennadii Stepanov)

Pull request description:

  It was overlooked in bitcoin#29787.

ACKs for top commit:
  TheCharlatan:
    ACK 3cb80fe

Tree-SHA512: c4eae65ffa0a79f4d57ba07730effee6aeff9d9625bc00a4534ffe46d3a16ae56bc8753e3fec93d7ff81ea7be39662282c631861a21ea8a9dc5d31b79acb231d
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Feb 22, 2025
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Feb 24, 2025
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Feb 26, 2025
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Feb 28, 2025
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Mar 5, 2025
@bitcoin bitcoin locked and limited conversation to collaborators Apr 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants