guix: remove errant leftover from #29648 #29787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
We no longer build a lib, so a non-existent dir is causing builds to fail.
d83b2ef to
fd8527a
Compare
Dropped, thanks. |
|
I didn't study the change itself, but tested that the Succeeds with fd8527a): |
|
ACK fd8527a Verified the failure, reviewed the change and running a guix build now without any issues (will post the results once it's finished). |
josibake
approved these changes
Apr 2, 2024
|
Guix Build (aarch64) 2b06bbafa2cc5291e9afa1b16751cfb467923e6f7fa4e07faaef41f8dd625524 guix-build-fd8527a20ebc/output/aarch64-linux-gnu/SHA256SUMS.part
3808ccae790057898ff275942b888443fa43f908aa6945057119f4705d7238b4 guix-build-fd8527a20ebc/output/aarch64-linux-gnu/bitcoin-fd8527a20ebc-aarch64-linux-gnu-debug.tar.gz
6c3542f09a01dfdb1817657172e747ba0953732866737ad12d5a79c768f89bc7 guix-build-fd8527a20ebc/output/aarch64-linux-gnu/bitcoin-fd8527a20ebc-aarch64-linux-gnu.tar.gz
727d848697a067a519f30c23cba959248e704a6afa1371ece2e05dc8969fec8f guix-build-fd8527a20ebc/output/arm-linux-gnueabihf/SHA256SUMS.part
d7088d53dce500428aee057d53f513ab75bc711408a7b103d457d87a8819ca5f guix-build-fd8527a20ebc/output/arm-linux-gnueabihf/bitcoin-fd8527a20ebc-arm-linux-gnueabihf-debug.tar.gz
44a07109440c2481cb4c6f35d4cee77a3a574f2d6331bd0f201f51b97a5bf904 guix-build-fd8527a20ebc/output/arm-linux-gnueabihf/bitcoin-fd8527a20ebc-arm-linux-gnueabihf.tar.gz
75fa532c8322952c9c017af5b755d1bc358e309037a75db6f06cd73bd70b59eb guix-build-fd8527a20ebc/output/arm64-apple-darwin/SHA256SUMS.part
deaaad2df2aa22f96fa9bba880d12ddcfbc2a4916c830ab2a98d57175e30d068 guix-build-fd8527a20ebc/output/arm64-apple-darwin/bitcoin-fd8527a20ebc-arm64-apple-darwin-unsigned.tar.gz
1bfd42a0e6825e61106105fe48f6e166020dbebde27294f9e067292bf16d0bea guix-build-fd8527a20ebc/output/arm64-apple-darwin/bitcoin-fd8527a20ebc-arm64-apple-darwin-unsigned.zip
983f60c3fa18849ff69ae6ac2449a701aad6aa6c9bd2758a0e3cb7dd14284f66 guix-build-fd8527a20ebc/output/arm64-apple-darwin/bitcoin-fd8527a20ebc-arm64-apple-darwin.tar.gz
cd51658c038c87b457b0a2ff2720abb53a3fa5ea896d0d559066be875dc48a0d guix-build-fd8527a20ebc/output/dist-archive/bitcoin-fd8527a20ebc.tar.gz
60d4cba856e49703ca377a82d2f6a6179046b611b6b0fd70b5a5aa192abd25d1 guix-build-fd8527a20ebc/output/powerpc64-linux-gnu/SHA256SUMS.part
901dacb17ebff333f0e2720520d28bce36df915a66e1fdd680d7c4392ba7f173 guix-build-fd8527a20ebc/output/powerpc64-linux-gnu/bitcoin-fd8527a20ebc-powerpc64-linux-gnu-debug.tar.gz
88b6fdd2d573c93328ab368dc2e6922dfda5d8246dc3ab43a28163fb1da89d55 guix-build-fd8527a20ebc/output/powerpc64-linux-gnu/bitcoin-fd8527a20ebc-powerpc64-linux-gnu.tar.gz
0ecc39d997fbfa364e367bcbfabffeb51540a7d43f4a478fba44ba615e03e232 guix-build-fd8527a20ebc/output/riscv64-linux-gnu/SHA256SUMS.part
6e4af7c7412af2350113677a0451a635d9f01c54b445396b79978e3c342fc4fc guix-build-fd8527a20ebc/output/riscv64-linux-gnu/bitcoin-fd8527a20ebc-riscv64-linux-gnu-debug.tar.gz
52efbf78b9366878fc05a0ed583fe757a2607b4638aee7ffde78fd7ea0f973e8 guix-build-fd8527a20ebc/output/riscv64-linux-gnu/bitcoin-fd8527a20ebc-riscv64-linux-gnu.tar.gz
32ff7f85bd2bdc18998d347f2f4ea72563c73d9710464001fb4b3213802da506 guix-build-fd8527a20ebc/output/x86_64-apple-darwin/SHA256SUMS.part
2ae54495c7acae2b7232a9e89f3cafc346eab6f0cbdc9e6fc244efb6eb298e14 guix-build-fd8527a20ebc/output/x86_64-apple-darwin/bitcoin-fd8527a20ebc-x86_64-apple-darwin-unsigned.tar.gz
00dee1e2496e23ecbff2416565634ee531bf5473dcccd8a3685ae6ab0f114fef guix-build-fd8527a20ebc/output/x86_64-apple-darwin/bitcoin-fd8527a20ebc-x86_64-apple-darwin-unsigned.zip
b0cbc4b4a68111a2559cfb189d3499b47f55cccbbe76fb8bc2d12437aeb7ef15 guix-build-fd8527a20ebc/output/x86_64-apple-darwin/bitcoin-fd8527a20ebc-x86_64-apple-darwin.tar.gz
5508f99217d723c8876655f340413187eea532a07014dc41855e521dc8450b11 guix-build-fd8527a20ebc/output/x86_64-linux-gnu/SHA256SUMS.part
bb01706c389841a165b13b425bd3a0e21de757c7e103b3cc391a832d614b338d guix-build-fd8527a20ebc/output/x86_64-linux-gnu/bitcoin-fd8527a20ebc-x86_64-linux-gnu-debug.tar.gz
bdffa7c54b0da04b9f5252d228af657e760d0f4ecb61692e4525dd2e0665e610 guix-build-fd8527a20ebc/output/x86_64-linux-gnu/bitcoin-fd8527a20ebc-x86_64-linux-gnu.tar.gz
bbda5f35bf0e929c437811ed5745a6743a1e023d4786435c0250e09c5dfd9cec guix-build-fd8527a20ebc/output/x86_64-w64-mingw32/SHA256SUMS.part
c76ea713cbfde351d83bc7fb591105cbdf7df37bfeafc9bad2da330db42da6c6 guix-build-fd8527a20ebc/output/x86_64-w64-mingw32/bitcoin-fd8527a20ebc-win64-debug.zip
e4acc7033348c2a5e0579012b0d97c3b54da1877fc84284d640484be33bb2b4b guix-build-fd8527a20ebc/output/x86_64-w64-mingw32/bitcoin-fd8527a20ebc-win64-setup-unsigned.exe
b4ead1d72ffd7f22acf40488af33281f8d9557f81c49cbbd63af1004d7dbc646 guix-build-fd8527a20ebc/output/x86_64-w64-mingw32/bitcoin-fd8527a20ebc-win64-unsigned.tar.gz
d41102726fc28d1cead8f211873e3261cd380fa574164daf31c0a1b0d7070ea1 guix-build-fd8527a20ebc/output/x86_64-w64-mingw32/bitcoin-fd8527a20ebc-win64.zip |
|
My Guix builds: |
hebasto
approved these changes
Apr 2, 2024
TheCharlatan
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
ACK fd8527a
Guix builds (x86_64):
2b06bbafa2cc5291e9afa1b16751cfb467923e6f7fa4e07faaef41f8dd625524 guix-build-fd8527a20ebc/output/aarch64-linux-gnu/SHA256SUMS.part
3808ccae790057898ff275942b888443fa43f908aa6945057119f4705d7238b4 guix-build-fd8527a20ebc/output/aarch64-linux-gnu/bitcoin-fd8527a20ebc-aarch64-linux-gnu-debug.tar.gz
6c3542f09a01dfdb1817657172e747ba0953732866737ad12d5a79c768f89bc7 guix-build-fd8527a20ebc/output/aarch64-linux-gnu/bitcoin-fd8527a20ebc-aarch64-linux-gnu.tar.gz
727d848697a067a519f30c23cba959248e704a6afa1371ece2e05dc8969fec8f guix-build-fd8527a20ebc/output/arm-linux-gnueabihf/SHA256SUMS.part
d7088d53dce500428aee057d53f513ab75bc711408a7b103d457d87a8819ca5f guix-build-fd8527a20ebc/output/arm-linux-gnueabihf/bitcoin-fd8527a20ebc-arm-linux-gnueabihf-debug.tar.gz
44a07109440c2481cb4c6f35d4cee77a3a574f2d6331bd0f201f51b97a5bf904 guix-build-fd8527a20ebc/output/arm-linux-gnueabihf/bitcoin-fd8527a20ebc-arm-linux-gnueabihf.tar.gz
75fa532c8322952c9c017af5b755d1bc358e309037a75db6f06cd73bd70b59eb guix-build-fd8527a20ebc/output/arm64-apple-darwin/SHA256SUMS.part
deaaad2df2aa22f96fa9bba880d12ddcfbc2a4916c830ab2a98d57175e30d068 guix-build-fd8527a20ebc/output/arm64-apple-darwin/bitcoin-fd8527a20ebc-arm64-apple-darwin-unsigned.tar.gz
1bfd42a0e6825e61106105fe48f6e166020dbebde27294f9e067292bf16d0bea guix-build-fd8527a20ebc/output/arm64-apple-darwin/bitcoin-fd8527a20ebc-arm64-apple-darwin-unsigned.zip
983f60c3fa18849ff69ae6ac2449a701aad6aa6c9bd2758a0e3cb7dd14284f66 guix-build-fd8527a20ebc/output/arm64-apple-darwin/bitcoin-fd8527a20ebc-arm64-apple-darwin.tar.gz
cd51658c038c87b457b0a2ff2720abb53a3fa5ea896d0d559066be875dc48a0d guix-build-fd8527a20ebc/output/dist-archive/bitcoin-fd8527a20ebc.tar.gz
60d4cba856e49703ca377a82d2f6a6179046b611b6b0fd70b5a5aa192abd25d1 guix-build-fd8527a20ebc/output/powerpc64-linux-gnu/SHA256SUMS.part
901dacb17ebff333f0e2720520d28bce36df915a66e1fdd680d7c4392ba7f173 guix-build-fd8527a20ebc/output/powerpc64-linux-gnu/bitcoin-fd8527a20ebc-powerpc64-linux-gnu-debug.tar.gz
88b6fdd2d573c93328ab368dc2e6922dfda5d8246dc3ab43a28163fb1da89d55 guix-build-fd8527a20ebc/output/powerpc64-linux-gnu/bitcoin-fd8527a20ebc-powerpc64-linux-gnu.tar.gz
0ecc39d997fbfa364e367bcbfabffeb51540a7d43f4a478fba44ba615e03e232 guix-build-fd8527a20ebc/output/riscv64-linux-gnu/SHA256SUMS.part
6e4af7c7412af2350113677a0451a635d9f01c54b445396b79978e3c342fc4fc guix-build-fd8527a20ebc/output/riscv64-linux-gnu/bitcoin-fd8527a20ebc-riscv64-linux-gnu-debug.tar.gz
52efbf78b9366878fc05a0ed583fe757a2607b4638aee7ffde78fd7ea0f973e8 guix-build-fd8527a20ebc/output/riscv64-linux-gnu/bitcoin-fd8527a20ebc-riscv64-linux-gnu.tar.gz
32ff7f85bd2bdc18998d347f2f4ea72563c73d9710464001fb4b3213802da506 guix-build-fd8527a20ebc/output/x86_64-apple-darwin/SHA256SUMS.part
2ae54495c7acae2b7232a9e89f3cafc346eab6f0cbdc9e6fc244efb6eb298e14 guix-build-fd8527a20ebc/output/x86_64-apple-darwin/bitcoin-fd8527a20ebc-x86_64-apple-darwin-unsigned.tar.gz
00dee1e2496e23ecbff2416565634ee531bf5473dcccd8a3685ae6ab0f114fef guix-build-fd8527a20ebc/output/x86_64-apple-darwin/bitcoin-fd8527a20ebc-x86_64-apple-darwin-unsigned.zip
b0cbc4b4a68111a2559cfb189d3499b47f55cccbbe76fb8bc2d12437aeb7ef15 guix-build-fd8527a20ebc/output/x86_64-apple-darwin/bitcoin-fd8527a20ebc-x86_64-apple-darwin.tar.gz
5508f99217d723c8876655f340413187eea532a07014dc41855e521dc8450b11 guix-build-fd8527a20ebc/output/x86_64-linux-gnu/SHA256SUMS.part
bb01706c389841a165b13b425bd3a0e21de757c7e103b3cc391a832d614b338d guix-build-fd8527a20ebc/output/x86_64-linux-gnu/bitcoin-fd8527a20ebc-x86_64-linux-gnu-debug.tar.gz
bdffa7c54b0da04b9f5252d228af657e760d0f4ecb61692e4525dd2e0665e610 guix-build-fd8527a20ebc/output/x86_64-linux-gnu/bitcoin-fd8527a20ebc-x86_64-linux-gnu.tar.gz
bbda5f35bf0e929c437811ed5745a6743a1e023d4786435c0250e09c5dfd9cec guix-build-fd8527a20ebc/output/x86_64-w64-mingw32/SHA256SUMS.part
c76ea713cbfde351d83bc7fb591105cbdf7df37bfeafc9bad2da330db42da6c6 guix-build-fd8527a20ebc/output/x86_64-w64-mingw32/bitcoin-fd8527a20ebc-win64-debug.zip
e4acc7033348c2a5e0579012b0d97c3b54da1877fc84284d640484be33bb2b4b guix-build-fd8527a20ebc/output/x86_64-w64-mingw32/bitcoin-fd8527a20ebc-win64-setup-unsigned.exe
b4ead1d72ffd7f22acf40488af33281f8d9557f81c49cbbd63af1004d7dbc646 guix-build-fd8527a20ebc/output/x86_64-w64-mingw32/bitcoin-fd8527a20ebc-win64-unsigned.tar.gz
d41102726fc28d1cead8f211873e3261cd380fa574164daf31c0a1b0d7070ea1 guix-build-fd8527a20ebc/output/x86_64-w64-mingw32/bitcoin-fd8527a20ebc-win64.zip
|
Post-merge: Guix builds (x86_64): |
Guix builds (on x86_64)
|
When you say you are running a guix build, do you mean you are running the guix operating system on a separate machine? |
Guix builds describe this project's method for compiling reproducible binaries (see https://reproducible-builds.org/). It is the same method that is used for Bitcoin Core release binaries. Guix is the package and build environment manager used for this process. In this context guix is installed on existing systems and not run separately from its own distribution. There is extensive documentation for how to setup and use guix for Bitcoin Core builds on an existing linux hosts here: https://github.com/bitcoin/bitcoin/blob/master/contrib/guix/README.md. |
fanquake
added a commit
that referenced
this pull request
Apr 4, 2024
3cb80fe guix: Remove another leftover from #29648 (Hennadii Stepanov) Pull request description: It was overlooked in #29787. ACKs for top commit: TheCharlatan: ACK 3cb80fe Tree-SHA512: c4eae65ffa0a79f4d57ba07730effee6aeff9d9625bc00a4534ffe46d3a16ae56bc8753e3fec93d7ff81ea7be39662282c631861a21ea8a9dc5d31b79acb231d
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Oct 25, 2024
3cb80fe guix: Remove another leftover from bitcoin#29648 (Hennadii Stepanov) Pull request description: It was overlooked in bitcoin#29787. ACKs for top commit: TheCharlatan: ACK 3cb80fe Tree-SHA512: c4eae65ffa0a79f4d57ba07730effee6aeff9d9625bc00a4534ffe46d3a16ae56bc8753e3fec93d7ff81ea7be39662282c631861a21ea8a9dc5d31b79acb231d
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Oct 25, 2024
fd8527a guix: remove errant leftover from bitcoin#29648 (fanquake) Pull request description: We no longer build a lib, so a non-existent dir is causing builds to fail. ACKs for top commit: josibake: ACK bitcoin@fd8527a hebasto: ACK fd8527a. TheCharlatan: ACK fd8527a Tree-SHA512: 9175a0de3f95f56939b3eaa3e89dca2cfae4996bcd84ef6b8e2872672bef39cb0550c9f4a79475d887eb8fac92c15dfa8c352648ff167d54a0b736978412226c
Pttn
added a commit
to Pttn/Bitcoin
that referenced
this pull request
Jan 10, 2025
luke-jr
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Feb 22, 2025
This reverts commit fd8527a (bitcoin#29787)
luke-jr
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Feb 24, 2025
This reverts commit fd8527a (bitcoin#29787)
luke-jr
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Feb 26, 2025
This reverts commit fd8527a (bitcoin#29787)
luke-jr
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Feb 28, 2025
This reverts commit fd8527a (bitcoin#29787)
luke-jr
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Mar 5, 2025
This reverts commit fd8527a (bitcoin#29787)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer build a lib, so a non-existent dir is causing builds to fail.