fuzz: set `nMaxOutboundLimit` in connman target #29172

brunoerg · 2024-01-03T20:15:44Z

Setting nMaxOutboundLimit (-maxuploadtarget) will make fuzz to reach more coverage in connman target. This value is used in GetMaxOutboundTimeLeftInCycle, OutboundTargetReached and GetOutboundTargetBytesLeft.

DrahtBot · 2024-01-03T20:15:47Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	dergoegge, jonatack
Stale ACK	maflcko

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#28584 (Fuzz: extend CConnman tests by vasild)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

brunoerg · 2024-01-03T20:41:22Z

CI failure is unrelated to this PR.

maflcko · 2024-01-04T09:06:32Z

lgtm ACK 46d7113

brunoerg · 2024-01-04T19:53:03Z

friendly ping: @dergoegge

src/test/fuzz/connman.cpp

brunoerg · 2024-01-05T15:52:06Z

Thanks, @dergoegge for your review. Force-pushed addressing: #29172 (comment) and #29172 (comment).

dergoegge

utACK e5b9ee0

jonatack

ACK e5b9ee0

achow101 · 2024-01-09T18:09:58Z

New compiler warning, using gcc 13.2.1

test/fuzz/connman.cpp: In function ‘void connman_fuzz_target(FuzzBufferType)’:
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::vSeedNodes’ [-Werror=missing-field-initializers]
   43 |     connman.Init({ .nMaxOutboundLimit = max_outbound_limit });
      |     ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::vWhitelistedRange’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::vWhiteBinds’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::vBinds’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::onion_binds’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::bind_on_any’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::vSeedNodes’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::vWhitelistedRange’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::vWhiteBinds’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::vBinds’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::onion_binds’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::bind_on_any’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::m_specified_outgoing’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::m_added_nodes’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::m_i2p_accept_incoming’ [-Werror=missing-field-initializers]

brunoerg · 2024-01-09T18:13:28Z

New compiler warning, using gcc 13.2.1

I'm checking it atm.

e84dc36 fuzz: fix `connman` initialization (brunoerg) Pull request description: Fixes #29172 (comment) ACKs for top commit: achow101: ACK e84dc36 Tree-SHA512: e5f3c378cfe367cc4c387fa1b13663a74d8b667a5d130d62919e21455861cfb9383b63ef4ebe56daab7b2c09e3b5031acc463065455f71607c5fb9e3c370d3ad

e5b9ee0 fuzz: set `nMaxOutboundLimit` in connman target (brunoerg) Pull request description: Setting `nMaxOutboundLimit` (`-maxuploadtarget`) will make fuzz to reach more coverage in connman target. This value is used in `GetMaxOutboundTimeLeftInCycle`, `OutboundTargetReached` and `GetOutboundTargetBytesLeft`. ACKs for top commit: dergoegge: utACK e5b9ee0 jonatack: ACK e5b9ee0 Tree-SHA512: d19c83602b0a487e6da0e3be539aa2abc95b8bbf36cf9a3e391a4af53b959f68ca38548a96d27d56742e3b772f648da04e2bf8973dfc0ab1cdabf4f2e8d44de6

e84dc36 fuzz: fix `connman` initialization (brunoerg) Pull request description: Fixes bitcoin#29172 (comment) ACKs for top commit: achow101: ACK e84dc36 Tree-SHA512: e5f3c378cfe367cc4c387fa1b13663a74d8b667a5d130d62919e21455861cfb9383b63ef4ebe56daab7b2c09e3b5031acc463065455f71607c5fb9e3c370d3ad

e5b9ee0 fuzz: set `nMaxOutboundLimit` in connman target (brunoerg) Pull request description: Setting `nMaxOutboundLimit` (`-maxuploadtarget`) will make fuzz to reach more coverage in connman target. This value is used in `GetMaxOutboundTimeLeftInCycle`, `OutboundTargetReached` and `GetOutboundTargetBytesLeft`. ACKs for top commit: dergoegge: utACK e5b9ee0 jonatack: ACK e5b9ee0 Tree-SHA512: d19c83602b0a487e6da0e3be539aa2abc95b8bbf36cf9a3e391a4af53b959f68ca38548a96d27d56742e3b772f648da04e2bf8973dfc0ab1cdabf4f2e8d44de6

e84dc36 fuzz: fix `connman` initialization (brunoerg) Pull request description: Fixes bitcoin#29172 (comment) ACKs for top commit: achow101: ACK e84dc36 Tree-SHA512: e5f3c378cfe367cc4c387fa1b13663a74d8b667a5d130d62919e21455861cfb9383b63ef4ebe56daab7b2c09e3b5031acc463065455f71607c5fb9e3c370d3ad

e5b9ee0 fuzz: set `nMaxOutboundLimit` in connman target (brunoerg) Pull request description: Setting `nMaxOutboundLimit` (`-maxuploadtarget`) will make fuzz to reach more coverage in connman target. This value is used in `GetMaxOutboundTimeLeftInCycle`, `OutboundTargetReached` and `GetOutboundTargetBytesLeft`. ACKs for top commit: dergoegge: utACK e5b9ee0 jonatack: ACK e5b9ee0 Tree-SHA512: d19c83602b0a487e6da0e3be539aa2abc95b8bbf36cf9a3e391a4af53b959f68ca38548a96d27d56742e3b772f648da04e2bf8973dfc0ab1cdabf4f2e8d44de6

e84dc36 fuzz: fix `connman` initialization (brunoerg) Pull request description: Fixes bitcoin#29172 (comment) ACKs for top commit: achow101: ACK e84dc36 Tree-SHA512: e5f3c378cfe367cc4c387fa1b13663a74d8b667a5d130d62919e21455861cfb9383b63ef4ebe56daab7b2c09e3b5031acc463065455f71607c5fb9e3c370d3ad

8bf1d06 Merge bitcoin#29308: doc: update `BroadcastTransaction` comment (glozow) 2a77808 Merge bitcoin-core/gui#789: Avoid non-self-contained Windows header (Hennadii Stepanov) da371b8 Merge bitcoin#28870: depends: Include `config.guess` and `config.sub` into `meta_depends` (fanquake) 2e41562 Merge bitcoin#29219: fuzz: Improve fuzzing stability for ellswift_roundtrip harness (fanquake) b091329 Merge bitcoin#29211: fuzz: fix `connman` initialization (Ava Chow) df42d41 Merge bitcoin#29200: net: create I2P sessions using both ECIES-X25519 and ElGamal encryption (fanquake) 4cdd1a8 Merge bitcoin#29172: fuzz: set `nMaxOutboundLimit` in connman target (fanquake) 97012ea Merge bitcoin#28962: doc: Rework guix docs after 1.4 release (fanquake) c70ff5d Merge bitcoin#28844: contrib: drop GCC MAX_VERSION to 4.3.0 in symbol-check (fanquake) e6f19e7 Merge bitcoin#29068: test: Actually fail when a python unit test fails (fanquake) 75e0334 Merge bitcoin#28989: test: Fix test by checking the actual exception instance (Andrew Chow) 8cd85d3 Merge bitcoin#28852: script, assumeutxo: Enhance validations in utxo_snapshot.sh (Ryan Ofsky) fd2e88d Merge bitcoin#26077: guix: switch from `guix environment` to `guix shell` (fanquake) 02741a7 Merge bitcoin#28913: coins: make sure PoolAllocator uses the correct alignment (fanquake) dfd53da Merge bitcoin#28902: doc: Simplify guix install doc, after 1.4 release (fanquake) Pull request description: ## Issue being fixed or feature implemented Batch of trivial backports ## What was done? See commits ## How Has This Been Tested? built locally; large combined merge passed tests locally ## Breaking Changes Should be none ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK 8bf1d06 knst: utACK 8bf1d06 Tree-SHA512: 506273e5a188f9ca74edf656e3cd338992192e6e97f68c89fc43e34be20fb7f211b48e4dfa8693727839a7920da8284509413c722f55774a428939c296dad517

DrahtBot added the Tests label Jan 3, 2024

DrahtBot mentioned this pull request Jan 4, 2024

Fuzz: extend CConnman tests #28584

Open

dergoegge reviewed Jan 5, 2024

View reviewed changes

src/test/fuzz/connman.cpp Outdated Show resolved Hide resolved

dergoegge reviewed Jan 5, 2024

View reviewed changes

src/test/fuzz/connman.cpp Outdated Show resolved Hide resolved

fuzz: set nMaxOutboundLimit in connman target

e5b9ee0

brunoerg force-pushed the 2024-fuzz-connman-maxuploadtarget branch from 46d7113 to e5b9ee0 Compare January 5, 2024 15:44

dergoegge approved these changes Jan 5, 2024

View reviewed changes

DrahtBot requested a review from maflcko January 5, 2024 17:24

jonatack reviewed Jan 8, 2024

View reviewed changes

fanquake merged commit f921d94 into bitcoin:master Jan 9, 2024

brunoerg mentioned this pull request Jan 9, 2024

fuzz: fix connman initialization #29211

Merged

bitcoin locked and limited conversation to collaborators Jan 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fuzz: set `nMaxOutboundLimit` in connman target #29172

fuzz: set `nMaxOutboundLimit` in connman target #29172

Uh oh!

brunoerg commented Jan 3, 2024

Uh oh!

DrahtBot commented Jan 3, 2024 •

edited

Loading

Uh oh!

brunoerg commented Jan 3, 2024

Uh oh!

maflcko commented Jan 4, 2024

Uh oh!

brunoerg commented Jan 4, 2024

Uh oh!

Uh oh!

Uh oh!

brunoerg commented Jan 5, 2024

Uh oh!

dergoegge left a comment

Uh oh!

jonatack left a comment

Uh oh!

achow101 commented Jan 9, 2024

Uh oh!

brunoerg commented Jan 9, 2024

Uh oh!

Uh oh!

fuzz: set nMaxOutboundLimit in connman target #29172

fuzz: set nMaxOutboundLimit in connman target #29172

Uh oh!

Conversation

brunoerg commented Jan 3, 2024

Uh oh!

DrahtBot commented Jan 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage

Reviews

Conflicts

Uh oh!

brunoerg commented Jan 3, 2024

Uh oh!

maflcko commented Jan 4, 2024

Uh oh!

brunoerg commented Jan 4, 2024

Uh oh!

Uh oh!

Uh oh!

brunoerg commented Jan 5, 2024

Uh oh!

dergoegge left a comment

Choose a reason for hiding this comment

Uh oh!

jonatack left a comment

Choose a reason for hiding this comment

Uh oh!

achow101 commented Jan 9, 2024

Uh oh!

brunoerg commented Jan 9, 2024

Uh oh!

Uh oh!

fuzz: set `nMaxOutboundLimit` in connman target #29172

fuzz: set `nMaxOutboundLimit` in connman target #29172

DrahtBot commented Jan 3, 2024 •

edited

Loading