Skip to content

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Sep 13, 2022

See https://guix.gnu.org/manual/devel/en/html_node/Invoking-guix-environment.html.

Deprecation warning: The guix environment command is deprecated
in favor of guix shell, which performs similar functions but is more convenient to use. See Invoking guix shell.

Being deprecated, guix environment is slated for eventual removal,
but the Guix project is committed to keeping it until May 1st, 2023. Please get in touch with us at guix-devel@gnu.org if you would like to discuss it.

See also https://guix.gnu.org/blog/2021/from-guix-environment-to-guix-shell/ for a blog post and additional details.

Guix shell was added to Guix ~1 year ago, in this commit, https://git.savannah.gnu.org/cgit/guix.git/commit/?id=80edb7df6586464aa40e84e103f0045452de95db, which isn't part of the 1.3.0 release binaries out of the box, but invoking a guix pull, and updating will make it available. i.e:

bash-5.1# guix --version
guix (GNU Guix) 1.3.0
Copyright (C) 2021 the Guix authors
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

bash-5.1# guix shell
guix: shell: command not found
Try 'guix --help' for more information.

bash-5.1# guix pull
Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.org/git/guix.git'...
Authenticating channel 'guix', commits 9edb3f6 to 7a980bb (6,278 new commits)...
Building from this channel:
  guix      https://git.savannah.gnu.org/git/guix.git	7a980bb
< snip >
building /gnu/store/2wwwsczxcw61m05p4mv0kf0advx4fqsb-inferior-script.scm.drv...
building package cache...
building profile with 1 package...
New in this revision:
  6,866 new packages: a2jmidid, abjad,

bash-5.1# guix help shell
Usage: guix shell [OPTION] PACKAGES... [-- COMMAND...]
Build an environment that includes PACKAGES and execute COMMAND or an
interactive shell in that environment.

@maflcko
Copy link
Member

maflcko commented Sep 13, 2022

Seems a bit early to accommodate for a removed feature that was replaced by something that hasn't ever been released in a release. Do you expect everyone to run the development branch of guix? Everyone running the latest release of guix should be fine without the changes here.

@fanquake
Copy link
Member Author

Do you expect everyone to run the development branch of guix?

No. I don't see running guix pull (Download and deploy the latest version of Guix.) as running a development branch. It's much more equivalent to running apt/dnf/brew update; giving you access to updated versions of packages to install, new features in Guix, bug fixes, support for new platforms/hardware etc. Fwiw I'd consider the core-updates branch to be the "development branch" of Guix.

Everyone running the latest release of guix should be fine without the changes here.

Sometime prior to May (assuming the command is removed as stated) our scripts will have to change, as we'll need to accomodate builders who keep their Guix updated. Once we make that change, anyone who's not runguix pull will no-longer be able to build (master at least), as guix shell wont exist in their Guix binary.

This will also effect any other branch still using guix environment, and then this change would need to be backported, so it can continue to be Guix built.

I'm not trying to force anything on Guix builders early, but I also don't see the benefit in leaving this until later, or right up until the point that things might break; especially if currently the only trade-off is accomodating builders who don't want to update their package manager.

@maflcko
Copy link
Member

maflcko commented Sep 13, 2022

Ok, then maybe guix pull should be documented as required/expected before starting the build?

@fanquake
Copy link
Member Author

replaced by something that hasn't ever been released in a release.

In regards to this point, it's not currently clear to me what the schedule is for the next Guix release. The most recent Release v1.4? discussions on the guix-devel list seem to have died out in June: https://lists.gnu.org/archive/html/guix-devel/2022-06/msg00364.html.

A 1.4.0 branch does exist, https://git.savannah.gnu.org/cgit/guix.git/log/?h=version-1.4.0, but also hasn't been updated since January this year.

@jarolrod
Copy link
Member

jarolrod commented Sep 13, 2022

GUIX hashes

x86:

b7e03ec169a26a394ad39e22604d49025339b58a7baae7e8253880341189657f  guix-build-a0e577e01fe6/output/aarch64-linux-gnu/SHA256SUMS.part
8934d52c5a35297620892f5bbcd0511d2398e02498a95f75141800e990800bc1  guix-build-a0e577e01fe6/output/aarch64-linux-gnu/bitcoin-a0e577e01fe6-aarch64-linux-gnu-debug.tar.gz
27b2593052ab3626de342438a7edd14b6f48c1796038611999b8429eded0124f  guix-build-a0e577e01fe6/output/aarch64-linux-gnu/bitcoin-a0e577e01fe6-aarch64-linux-gnu.tar.gz
81edc8131e229698bd5c3b86c7b7705f24eea311c3b4b5b02332b95e1699cc17  guix-build-a0e577e01fe6/output/arm-linux-gnueabihf/SHA256SUMS.part
0a48cd3a12ea4871acb0a2d698efd049cd0f5c0e86dbecfdf3915149d7621173  guix-build-a0e577e01fe6/output/arm-linux-gnueabihf/bitcoin-a0e577e01fe6-arm-linux-gnueabihf-debug.tar.gz
f262eae397a6c813ea95f1fa12990a16daf004229c26b14304a76c8d50242e42  guix-build-a0e577e01fe6/output/arm-linux-gnueabihf/bitcoin-a0e577e01fe6-arm-linux-gnueabihf.tar.gz
f6b69b36e6d5c644130de85dabb55e8938e48e414a51192e95c1d5ebe7a67522  guix-build-a0e577e01fe6/output/arm64-apple-darwin/SHA256SUMS.part
6f63bc18c2af8d54694ebca5dba4f1ce5bf9bec5d8638e5fc874d8ab93b56d6f  guix-build-a0e577e01fe6/output/arm64-apple-darwin/bitcoin-a0e577e01fe6-arm64-apple-darwin-unsigned.dmg
5ebeece42a1a34fd80ba82cc57a3ed703f9930031ed29f6c3d4f9d9b9f3fa53b  guix-build-a0e577e01fe6/output/arm64-apple-darwin/bitcoin-a0e577e01fe6-arm64-apple-darwin-unsigned.tar.gz
862f1f65d849a3834cd9ca6296a23e506c4b1dab1c6eda23f865e2227415a5b6  guix-build-a0e577e01fe6/output/arm64-apple-darwin/bitcoin-a0e577e01fe6-arm64-apple-darwin.tar.gz
c996d704b70b1347054c53053c084b49aa7b85c5a16a6cfc8dc97528cd47822f  guix-build-a0e577e01fe6/output/dist-archive/bitcoin-a0e577e01fe6.tar.gz
26f7fe6339e88d5045deb4385d0def248e534db918c4fc15428295b80bdb3c2d  guix-build-a0e577e01fe6/output/powerpc64-linux-gnu/SHA256SUMS.part
aa3fa63c7150148b23f86fc57cf5a5802dafafcac3d6f8e570674beff64d86a4  guix-build-a0e577e01fe6/output/powerpc64-linux-gnu/bitcoin-a0e577e01fe6-powerpc64-linux-gnu-debug.tar.gz
d3e2f40b0d7bf921d475e670269c055a807ba02206635b3b07af57252337d201  guix-build-a0e577e01fe6/output/powerpc64-linux-gnu/bitcoin-a0e577e01fe6-powerpc64-linux-gnu.tar.gz
f7c7fc4f85da09125240870004769f52eb4b655d0cdfbaa543972e7f5b6934d3  guix-build-a0e577e01fe6/output/powerpc64le-linux-gnu/SHA256SUMS.part
3268b1ae1c52c727a34ac1ee7937efb694118f1a06831922399893efaea6f034  guix-build-a0e577e01fe6/output/powerpc64le-linux-gnu/bitcoin-a0e577e01fe6-powerpc64le-linux-gnu-debug.tar.gz
f9b5e8bef5b9b5258f5f0c22de3b62cf1db67072259fd8f70f9e8463d3a76035  guix-build-a0e577e01fe6/output/powerpc64le-linux-gnu/bitcoin-a0e577e01fe6-powerpc64le-linux-gnu.tar.gz
17ca025672519d0e49394c98fee13514466eaaa89b8fa6d3bbc3bccec52bb5d9  guix-build-a0e577e01fe6/output/riscv64-linux-gnu/SHA256SUMS.part
a1432d3777cf29cd7f085f2d7dbd389e97fdab55ee64e45651258838700a79c7  guix-build-a0e577e01fe6/output/riscv64-linux-gnu/bitcoin-a0e577e01fe6-riscv64-linux-gnu-debug.tar.gz
0bd6f26626113aaa2cd198b133281793166ffe923a0bf2039e83ba1b4e3f7c43  guix-build-a0e577e01fe6/output/riscv64-linux-gnu/bitcoin-a0e577e01fe6-riscv64-linux-gnu.tar.gz
5446cd7a4657ed0e9c9483221c7b8e8f0c0146f629e4f37413159cfdcef9a2ac  guix-build-a0e577e01fe6/output/x86_64-apple-darwin/SHA256SUMS.part
e48a5e6cb756fa5ac893212a88766932f300d5f9d1083b4b4aca32836e17d0ee  guix-build-a0e577e01fe6/output/x86_64-apple-darwin/bitcoin-a0e577e01fe6-x86_64-apple-darwin-unsigned.dmg
d0f7cf99c1744c0b428c527249408735906cedc772bf99e6ad8da2ad04a0ee4d  guix-build-a0e577e01fe6/output/x86_64-apple-darwin/bitcoin-a0e577e01fe6-x86_64-apple-darwin-unsigned.tar.gz
444b5f9ad51e4b6699ac449035b200141b18c085b69ea0faf7c52f1fc600f983  guix-build-a0e577e01fe6/output/x86_64-apple-darwin/bitcoin-a0e577e01fe6-x86_64-apple-darwin.tar.gz
995688006a26a1bc4b343f5457e7ab307e6e02f95d7b0c0f6eae8b3e27a9f4f5  guix-build-a0e577e01fe6/output/x86_64-linux-gnu/SHA256SUMS.part
d872d6912854a15b486c51f2e888b646baa18d4994071b143687f51e25fd0791  guix-build-a0e577e01fe6/output/x86_64-linux-gnu/bitcoin-a0e577e01fe6-x86_64-linux-gnu-debug.tar.gz
ac918f5619c8cc8ab43d5c9a8eda57cb152cea379ad655430883676c32ad29d1  guix-build-a0e577e01fe6/output/x86_64-linux-gnu/bitcoin-a0e577e01fe6-x86_64-linux-gnu.tar.gz
a5f3b285472998ad2b6ec2320b892884883acf6628ada4aa96957dda00f9da74  guix-build-a0e577e01fe6/output/x86_64-w64-mingw32/SHA256SUMS.part
f3c5387f1713a268f4cae26606138243a691e2e124bd9fe9f1f35804572c7942  guix-build-a0e577e01fe6/output/x86_64-w64-mingw32/bitcoin-a0e577e01fe6-win64-debug.zip
c93133abbb61d5d1997bab844c90b1689475eb23040c49838bd76660d85942f2  guix-build-a0e577e01fe6/output/x86_64-w64-mingw32/bitcoin-a0e577e01fe6-win64-setup-unsigned.exe
6e1b4837ef31841ba55928d45bd0ec8eee47a5f8e594db234691315a018b00e7  guix-build-a0e577e01fe6/output/x86_64-w64-mingw32/bitcoin-a0e577e01fe6-win64-unsigned.tar.gz
3a9cfa0bab9e2aa1bea32e3d867782a56329dde16445b26cb8b01bb9cd8846fd  guix-build-a0e577e01fe6/output/x86_64-w64-mingw32/bitcoin-a0e577e01fe6-win64.zip

arm64:


@hebasto
Copy link
Member

hebasto commented Sep 13, 2022

Guix shell was added to Guix ~1 year ago, in this commit, https://git.savannah.gnu.org/cgit/guix.git/commit/?id=80edb7df6586464aa40e84e103f0045452de95db, which isn't part of the 1.3.0 release binaries out of the box, but invoking a guix pull

Just a reminder, that guix pull failed in certain conditions in the past (just search in https://issues.guix.gnu.org). I don't think we can rely on it.

@fanquake
Copy link
Member Author

Ok, then maybe guix pull should be documented as required/expected before starting the build?

I'll add some additional documentation.

Just a reminder, that guix pull failed in certain conditions in the past (just search in https://issues.guix.gnu.org/). I don't think we can rely on it.

Can you point to some specific instances of bugs that would effect us, and are still relevant for a recent Guix release? What are the certain conditions?

@fanquake
Copy link
Member Author

Looks like there is at least some movement on the Guix 1.4.0 release front. A commit this morning added: * NEWS: Update entries for v1.4.0..

@hebasto
Copy link
Member

hebasto commented Sep 15, 2022

Just a reminder, that guix pull failed in certain conditions in the past (just search in https://issues.guix.gnu.org/). I don't think we can rely on it.

Can you point to some specific instances of bugs that would effect us, and are still relevant for a recent Guix release? What are the certain conditions?

By "certain conditions" I mean a combination of a local repo head commit and a remote repo head commit. Nothing specific to us. If it happened before, I see no reasons why it can't happen again.

@maflcko
Copy link
Member

maflcko commented Sep 16, 2022

Once there is a 1.4 release, it seems more acceptable to say this is also the minimum required version

@fanquake
Copy link
Member Author

fanquake commented Sep 16, 2022

Once there is a 1.4 release, it seems more acceptable to say this is also the minimum required version

Yes, possibly, although that will also depend on how fast distros are too adopt it.

The changes here will still be needed for all maintained branches (or will have to backport a change to say they can't be built with newer Guix), and the guix pull instructions will be required for users updating from their current binaries (unless the expectation is for everyone to download and overwrite their existing binaries).

@hebasto
Copy link
Member

hebasto commented Sep 16, 2022

After an offline discussion with @fanquake I concept ACK.

#26077 (comment):

Ok, then maybe guix pull should be documented as required/expected before starting the build?

+1

@maflcko
Copy link
Member

maflcko commented Sep 16, 2022

I don't see why this needs to be rushed. It should be fine to do nothing for almost a year and then backport this to all branches on May 2nd, or when 1.4 has been released, whichever happens earlier

@fanquake
Copy link
Member Author

and then backport this to all branches on May 2nd,

This doesn't make tagged / released versions buildable. They will start failing to build for anyone using a Guix that no-longer has environment. I'm not advocating rushing, but I also don't see the point of leaving this until much later / the last minute, and then having things broken that otherwise wouldn't have needed to be. In any case, we don't have to do this last-minute for 24.0.

or when 1.4 has been released

When released, this binary will, as far as I can tell, still have both commands, so it's release date (if it's much earlier than May) won't really factor into when we change things here.

@DrahtBot
Copy link
Contributor

Guix builds

File commit 718304d
(master)
commit bd46c4a
(master and this pull)
SHA256SUMS.part 9bec9188aaf76cc8... 04c328b9c618d508...
*-aarch64-linux-gnu-debug.tar.gz 38920666c178264e... 2fc5b6f46a7c6a94...
*-aarch64-linux-gnu.tar.gz 6f10fd80ef5b3b75... 9ca9e950ef3783ae...
*-arm-linux-gnueabihf-debug.tar.gz 75731aecf792b91d... 54eeafbdbcb86bd2...
*-arm-linux-gnueabihf.tar.gz 584f8e93bd37d4d3... 4e3fdaf7b83c1c86...
*-arm64-apple-darwin-unsigned.dmg f7a66a55299e6513... 19b2e9fcb46b3bb7...
*-arm64-apple-darwin-unsigned.tar.gz e4b2dcace31a5f6a... 1cec4da74b7715a5...
*-arm64-apple-darwin.tar.gz fb60192ea0407221... 645dffd7e922c49d...
*-powerpc64-linux-gnu-debug.tar.gz 2faf767dd5f32d56... bb978fa8006689fa...
*-powerpc64-linux-gnu.tar.gz 46ee5975c0cb15d5... 59c7541455a3f727...
*-powerpc64le-linux-gnu-debug.tar.gz 6ed78a4b8441aa28... f17aa4eada465352...
*-powerpc64le-linux-gnu.tar.gz 050a085d63786095... cb73ea1bd5a1d9e2...
*-riscv64-linux-gnu-debug.tar.gz ec79d5e118799e22... e362609d5cd44680...
*-riscv64-linux-gnu.tar.gz 39b382c6b98cf0a2... a058be9394a8a549...
*-win64-debug.zip c613ed3c3732be80... fd544d08f2f7f4dd...
*-win64-setup-unsigned.exe 2bc47b956d6e28aa... 039547ece69b990c...
*-win64-unsigned.tar.gz c345b9ce8df61ac0... 9349a2c4d2a2d4e4...
*-win64.zip 386f9c6cde049558... 7a7ebb987dbda579...
*-x86_64-apple-darwin-unsigned.dmg 4f6210d11825e254... 4b78147f2e9f2926...
*-x86_64-apple-darwin-unsigned.tar.gz be2bad76648ed0b3... a43d1343949c041e...
*-x86_64-apple-darwin.tar.gz c842d8d0351fe929... 0c1b9a3aa93e3416...
*-x86_64-linux-gnu-debug.tar.gz 3fa7ceb834428845... edc8e302d295fc55...
*-x86_64-linux-gnu.tar.gz 5c516c31e3deece4... a68e64a0ded56d82...
*.tar.gz 76edccbd72647e9b... 01be212c17e56b90...
guix_build.log 6e341a8e5f321eae... e923948b61a498a1...
guix_build.log.diff 2fc36899e9eaa5a8...

@luke-jr
Copy link
Member

luke-jr commented Sep 19, 2022

Looking at this PR, it seems like it should be trivial to accommodate both commands? Try guix shell first, and if that fails, try guix environment...

@DrahtBot
Copy link
Contributor

DrahtBot commented Sep 23, 2022

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK TheCharlatan
Concept ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

No conflicts as of last run.

@TheCharlatan
Copy link
Contributor

Concept ACK

Guix 1.4.0 was released in December, they still paint May 2023 has a potential deprecation target for guix environment in their release blog post: https://guix.gnu.org/en/blog/2022/gnu-guix-1.4.0-released/ .

Guix hashes (built with a 1.4.0 release):

14af0889d50b276d2552e9e4a286751b29bb835cf2d6c568b0ab3e00d13a997a  guix-build-0bd5162f8e73/output/aarch64-linux-gnu/SHA256SUMS.part
e7971b5e89b4440c865acba54242bb3c21e0fb51597ab57df85d9eec49c41fdb  guix-build-0bd5162f8e73/output/aarch64-linux-gnu/bitcoin-0bd5162f8e73-aarch64-linux-gnu-debug.tar.gz
4c361dddf559ad52bce5b1f93cd612d9951ed41f7bcc2449705ad83c33f8b9b8  guix-build-0bd5162f8e73/output/aarch64-linux-gnu/bitcoin-0bd5162f8e73-aarch64-linux-gnu.tar.gz
08b384613febec9414bd2fef03f98fe2bd45c5d7656017b05a589a765bb8983f  guix-build-0bd5162f8e73/output/arm-linux-gnueabihf/SHA256SUMS.part
c1757a0789663da8e844ac376fb4c66728653076f499054112304efbe6227b62  guix-build-0bd5162f8e73/output/arm-linux-gnueabihf/bitcoin-0bd5162f8e73-arm-linux-gnueabihf-debug.tar.gz
f0c875d9a072ca7b97b10ed71b7f8edc01032cb48aa4db722fae8230f50718fa  guix-build-0bd5162f8e73/output/arm-linux-gnueabihf/bitcoin-0bd5162f8e73-arm-linux-gnueabihf.tar.gz
fa6b69d3cec6f0cf8b7371777cb40581008bdbd8ddb4e9edd7af05a44a9789b6  guix-build-0bd5162f8e73/output/arm64-apple-darwin/SHA256SUMS.part
23129cbaed8b4cd3c9ea6ecb414f0885dc0e244eabee25b4e5848f6f9c7232c9  guix-build-0bd5162f8e73/output/arm64-apple-darwin/bitcoin-0bd5162f8e73-arm64-apple-darwin-unsigned.dmg
6b87a6e98020884ac598e42b98df3c77723f8dd2a829d3261240642c844262f0  guix-build-0bd5162f8e73/output/arm64-apple-darwin/bitcoin-0bd5162f8e73-arm64-apple-darwin-unsigned.tar.gz
12f2e92cc609a45f18b7ddf64a38a66e372b103051651948c1d013f355603174  guix-build-0bd5162f8e73/output/arm64-apple-darwin/bitcoin-0bd5162f8e73-arm64-apple-darwin.tar.gz
1b79b5d406524acfe9d6353c4d4011ee212cbb211b2d11bc1596c575d43299ae  guix-build-0bd5162f8e73/output/dist-archive/bitcoin-0bd5162f8e73.tar.gz
b75eddcee748e1f8ead8b5e2f1b2a2956dcce33faae0292dc157c507e4d238bc  guix-build-0bd5162f8e73/output/powerpc64-linux-gnu/SHA256SUMS.part
f3bcb70031c8634689eff00dc16849aa9ba26171471121fc3cf304a45f5d3c5d  guix-build-0bd5162f8e73/output/powerpc64-linux-gnu/bitcoin-0bd5162f8e73-powerpc64-linux-gnu-debug.tar.gz
dac92ec1e2335cf17efc978b3c4426138ed0c8bf5e8bd8ed2a82525093719907  guix-build-0bd5162f8e73/output/powerpc64-linux-gnu/bitcoin-0bd5162f8e73-powerpc64-linux-gnu.tar.gz
852f951d203e0ea8d8eaf65432cc9301651d25143929a5c00d1a1f06b7b17d9a  guix-build-0bd5162f8e73/output/powerpc64le-linux-gnu/SHA256SUMS.part
d2e71465cbffac7f46a1f7169904d33d157a0aa1c0de632701307431f4f52cd8  guix-build-0bd5162f8e73/output/powerpc64le-linux-gnu/bitcoin-0bd5162f8e73-powerpc64le-linux-gnu-debug.tar.gz
1a048d680a10651a79ca5005fa238bbf669d8ad70313c498e0218d10bd5565fa  guix-build-0bd5162f8e73/output/powerpc64le-linux-gnu/bitcoin-0bd5162f8e73-powerpc64le-linux-gnu.tar.gz
08503a3513a8d56b91b5b2942eb2ab54de09346390e90ba8cd8cb0188fab5939  guix-build-0bd5162f8e73/output/riscv64-linux-gnu/SHA256SUMS.part
279ef5692047c2efacd21f5eca29ca377571ac0c1a23ecdbdcb345a55ec2b09c  guix-build-0bd5162f8e73/output/riscv64-linux-gnu/bitcoin-0bd5162f8e73-riscv64-linux-gnu-debug.tar.gz
d244f82d3de2c7ad85b26c5b6d5dd02b2f15c00632c47b59628d11705efe8c2a  guix-build-0bd5162f8e73/output/riscv64-linux-gnu/bitcoin-0bd5162f8e73-riscv64-linux-gnu.tar.gz
21ea0318d54940f3fed26ded1738b1e91ea8b703243baf7d02decf6cb7159859  guix-build-0bd5162f8e73/output/x86_64-apple-darwin/SHA256SUMS.part
2f621374d7351ecc63b97585a33111fcda1e80644e2dd15c3058e4433d2ab13c  guix-build-0bd5162f8e73/output/x86_64-apple-darwin/bitcoin-0bd5162f8e73-x86_64-apple-darwin-unsigned.dmg
244347af756e595380ed965fa7e63ffe670026600dad820d21436a46e9801129  guix-build-0bd5162f8e73/output/x86_64-apple-darwin/bitcoin-0bd5162f8e73-x86_64-apple-darwin-unsigned.tar.gz
8e26b527cee40a96b7a1bd85529114bedd0524a70f6f5c7c2e8cf56f44cf9d6f  guix-build-0bd5162f8e73/output/x86_64-apple-darwin/bitcoin-0bd5162f8e73-x86_64-apple-darwin.tar.gz
815f8468a6953c01daf7712bf7b8c70515de47a33ab3616945b2c4111e367954  guix-build-0bd5162f8e73/output/x86_64-linux-gnu/SHA256SUMS.part
14967568b389c2f2692ad31c0d1fe538a8cc56a2309073f369e4e5b915f6cd41  guix-build-0bd5162f8e73/output/x86_64-linux-gnu/bitcoin-0bd5162f8e73-x86_64-linux-gnu-debug.tar.gz
0d223150ccefcfed563ca900c01f9730dd5e2f446042518fb8144bb9ec2fa658  guix-build-0bd5162f8e73/output/x86_64-linux-gnu/bitcoin-0bd5162f8e73-x86_64-linux-gnu.tar.gz
b4818c32dd2bce3e525edf02a0396738fdd943490778ff657df90b6261681bd1  guix-build-0bd5162f8e73/output/x86_64-w64-mingw32/SHA256SUMS.part
0bee28242cb9e913ffe0490164dbb39190917885ca8be6595155106fe905cfa5  guix-build-0bd5162f8e73/output/x86_64-w64-mingw32/bitcoin-0bd5162f8e73-win64-debug.zip
33a77389546371adbf4bb73e8a1c2638dc59dccb9b7c1a92feb5839a8c273d5e  guix-build-0bd5162f8e73/output/x86_64-w64-mingw32/bitcoin-0bd5162f8e73-win64-setup-unsigned.exe
abbec5d12d7f8facfb7ca220c1b66d07ffdf8f3470a829c789f875582c029200  guix-build-0bd5162f8e73/output/x86_64-w64-mingw32/bitcoin-0bd5162f8e73-win64-unsigned.tar.gz
40af9455183d68aa83da30fe58e70de937a11127b8d77c4a227176b335887b49  guix-build-0bd5162f8e73/output/x86_64-w64-mingw32/bitcoin-0bd5162f8e73-win64.zip

@fanquake fanquake force-pushed the guix_shell_over_environment branch from 0bd5162 to a0e577e Compare March 3, 2023 14:32
@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 8, 2023

There hasn't been much activity lately. What is the status here?

Finding reviewers may take time. However, if the patch is no longer relevant, please close this pull request. If the author lost interest or time to work on this, please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

@maflcko
Copy link
Member

maflcko commented Aug 8, 2023

lgtm, but you'll have to document the minimum guix version to be 1.4, no?

@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 8, 2023

Guix builds

File commit b565485
(master)
commit 9d831b2
(master and this pull)
SHA256SUMS.part 81eca795dfe6c075... cecfd5a03aa77384...
*-aarch64-linux-gnu-debug.tar.gz e8523bfd37bbe229... 551b2c2880b01a66...
*-aarch64-linux-gnu.tar.gz 32930c35a1b50445... fe509669be7cc2a0...
*-arm-linux-gnueabihf-debug.tar.gz 9d37d55e13934ee6... 20abbb439c3e0a38...
*-arm-linux-gnueabihf.tar.gz 9ed03b86767c0e2e... 18ef88486e29895f...
*-arm64-apple-darwin-unsigned.dmg 13ec56efe89e12f5... a25814d74ea595d3...
*-arm64-apple-darwin-unsigned.tar.gz 8a288b5945554b1e... 98d123f9c5d3ec9f...
*-arm64-apple-darwin.tar.gz f35a25ad6878bfda... a2104eeac37beae9...
*-powerpc64-linux-gnu-debug.tar.gz 75534a15f123851e... 4e1a1e35659ffa79...
*-powerpc64-linux-gnu.tar.gz b668a1f3ea46a7d5... afee81dcd4b2f965...
*-powerpc64le-linux-gnu-debug.tar.gz cc284c096f7e3a47... 0b8982167a715741...
*-powerpc64le-linux-gnu.tar.gz caca004e957a53f1... af18930bd411398f...
*-riscv64-linux-gnu-debug.tar.gz ced6f3fcac17caa7... 4052c2d57173cc9a...
*-riscv64-linux-gnu.tar.gz 7abde8498c60a63b... b45b2c442800d65f...
*-x86_64-apple-darwin-unsigned.dmg a1810c4719a393f3... ceb4d5cb81b20c1e...
*-x86_64-apple-darwin-unsigned.tar.gz d667fc587bde7b79... ac4a9f9b116d95f8...
*-x86_64-apple-darwin.tar.gz 6fb77d275635caf3... cecf038802838f18...
*-x86_64-linux-gnu-debug.tar.gz 89105d42ca0ffbb9... 1f4b197ec8b23ed6...
*-x86_64-linux-gnu.tar.gz 6eda70507077bd53... 949d53959ef24e11...
*.tar.gz 4004008d0c37167d... 51f5248ac964fc91...
guix_build.log 259be68439bac020... 02a68079b451eefb...
guix_build.log.diff 734b215261b3298f...

@fanquake
Copy link
Member Author

lgtm, but you'll have to document the minimum guix version to be 1.4, no?

Yea we'll have to update docs in some capacity. Going to draft for now, until we've bumped the time-machine (27897), and then come back to this.

@fanquake fanquake marked this pull request as draft August 18, 2023 09:37
@maflcko
Copy link
Member

maflcko commented Nov 29, 2023

Is this even a breaking change? I just tested this locally with guix v1.3 and it works:

# guix --version && guix time-machine --commit=77386bdbfe6b0c649c05ab37f08051d1ab3e5074 -- shell 
guix (GNU Guix) 1.3.0
Copyright (C) 2021 the Guix authors
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
accepted connection from pid 6284, user root
guix shell: warning: no packages specified; creating an empty environment
hint: Consider passing the `--check' option once to make sure your shell does not clobber environment variables.

guix shell: warning: no packages specified; creating an empty environment
# 

See https://guix.gnu.org/manual/devel/en/html_node/Invoking-guix-environment.html.

> Deprecation warning: The guix environment command is deprecated
in favor of guix shell, which performs similar functions but is more
convenient to use. See Invoking guix shell.

> Being deprecated, guix environment is slated for eventual removal,
but the Guix project is committed to keeping it until May 1st, 2023.
Please get in touch with us at guix-devel@gnu.org if you would like
to discuss it.

See also https://guix.gnu.org/blog/2021/from-guix-environment-to-guix-shell/
for a blog post and additional details.

Guix shell was added to guix in this commit,
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=80edb7df6586464aa40e84e103f0045452de95db
which isn't part of the 1.3.0 release binaries out of the box, but
invoking a guix pull, and updating will make it available for all
builders.
@fanquake fanquake force-pushed the guix_shell_over_environment branch from a0e577e to 66c4b58 Compare November 29, 2023 21:25
@fanquake fanquake marked this pull request as ready for review November 29, 2023 21:26
@fanquake
Copy link
Member Author

I just tested this locally with guix v1.3 and it works:

I tried the same with 1.2.0:

fa242307e656:/bitcoin# guix --version
/gnu/store/7sfbiqh21h90bc6zi8br1xh60m6qgdd5-bash-minimal-5.0.16/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
guix (GNU Guix) 1.2.0
Copyright (C) 2020 the Guix authors
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
fa242307e656:/bitcoin# guix time-machine --commit=77386bdbfe6b0c649c05ab37f08051d1ab3e5074 -- shell
/gnu/store/7sfbiqh21h90bc6zi8br1xh60m6qgdd5-bash-minimal-5.0.16/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.org/git/guix.git'...
guix shell: warning: no packages specified; creating an empty environment
hint: Consider passing the '--check' option once to make sure your shell does not clobber environment variables.

guix shell: warning: no packages specified; creating an empty environment
substitute: /gnu/store/7sfbiqh21h90bc6zi8br1xh60m6qgdd5-bash-minimal-5.0.16/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
The following derivations will be built:
  /gnu/store/wkvzmn03nc2p0ym7vpp0hri0fvd6c8vf-profile.drv
  /gnu/store/f0cq09h6rn52zcmvn4khrl8wcan63v2j-module-import-compiled.drv

applying 7 grafts for guile-3.0.9 ...
building /gnu/store/f0cq09h6rn52zcmvn4khrl8wcan63v2j-module-import-compiled.drv...
building profile with 0 packages...

Copy link
Contributor

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 66c4b58

Guix builds (x86):

b4a8c955fb5df71df94a0c754aec564ebe43e38055c6b41a271466b4573fe53f  guix-build-66c4b58e518a/output/aarch64-linux-gnu/SHA256SUMS.part
0d0a7612863ddd41d26b1d43fff827a2b8d118106a037e82c4111ce37fa7e857  guix-build-66c4b58e518a/output/aarch64-linux-gnu/bitcoin-66c4b58e518a-aarch64-linux-gnu-debug.tar.gz
b251292b681ec36bdb3c331c76afa7389671f9942cd6afadb4e303a803711415  guix-build-66c4b58e518a/output/aarch64-linux-gnu/bitcoin-66c4b58e518a-aarch64-linux-gnu.tar.gz
74b41731eddcb68b157d9a526c94c8e19e58ee676104b44f92bf8ef99e14b258  guix-build-66c4b58e518a/output/arm-linux-gnueabihf/SHA256SUMS.part
4b515a6ff49606cdb1451510699fcff87394ed5c650e9d7db22c783c666010d1  guix-build-66c4b58e518a/output/arm-linux-gnueabihf/bitcoin-66c4b58e518a-arm-linux-gnueabihf-debug.tar.gz
55db0db7df0a9f13c79eaf309c61f44c73fb37d26e4a1cf265eef7881321fec1  guix-build-66c4b58e518a/output/arm-linux-gnueabihf/bitcoin-66c4b58e518a-arm-linux-gnueabihf.tar.gz
eb62791c4acb8a46c3631fa90f346be72f38c1c3ee38346a7a92883aecd8e170  guix-build-66c4b58e518a/output/arm64-apple-darwin/SHA256SUMS.part
b2a89ac099f39155a58ef566cb111b2c38bcbbd9d0d0df226c9661b9fac4fd1f  guix-build-66c4b58e518a/output/arm64-apple-darwin/bitcoin-66c4b58e518a-arm64-apple-darwin-unsigned.tar.gz
642578b1750ba067b93d7ad716d3e5cecdb3be0071cd88984eb68af670247070  guix-build-66c4b58e518a/output/arm64-apple-darwin/bitcoin-66c4b58e518a-arm64-apple-darwin-unsigned.zip
23cedc5f89d7a3514aa1718d74851fa53f21acd89e4c4994b4e4864f92e41366  guix-build-66c4b58e518a/output/arm64-apple-darwin/bitcoin-66c4b58e518a-arm64-apple-darwin.tar.gz
58ccdddb213b92ee2b18fba9960298cfa45c5fb23972eb2f73c4652f89a026ba  guix-build-66c4b58e518a/output/dist-archive/bitcoin-66c4b58e518a.tar.gz
fd31e0439b48bcc896deb1ecf5fabbaede91f47f065da6df360e1eca222323bd  guix-build-66c4b58e518a/output/powerpc64-linux-gnu/SHA256SUMS.part
558ea3ad15d08c4e57af66cdccd6ae5fd02be8878880bb898870d3b13443acdb  guix-build-66c4b58e518a/output/powerpc64-linux-gnu/bitcoin-66c4b58e518a-powerpc64-linux-gnu-debug.tar.gz
112936fb96bf22097a046ef1a2b1ea23e91d2bba9e3b54a819a4a33811efab07  guix-build-66c4b58e518a/output/powerpc64-linux-gnu/bitcoin-66c4b58e518a-powerpc64-linux-gnu.tar.gz
a408de2a12852cfae0b6dd19ee6bbcdeabcc0223ce3554727ce0e0f440d8f2f9  guix-build-66c4b58e518a/output/powerpc64le-linux-gnu/SHA256SUMS.part
389d9654743cd307a875e753dafc3a40aa5d7c94eca1efba33e4d18bf6c66748  guix-build-66c4b58e518a/output/powerpc64le-linux-gnu/bitcoin-66c4b58e518a-powerpc64le-linux-gnu-debug.tar.gz
5fe15013c4e60f6fa4b9679664a8c3296ade2461e5b999ca3f748d25199ce454  guix-build-66c4b58e518a/output/powerpc64le-linux-gnu/bitcoin-66c4b58e518a-powerpc64le-linux-gnu.tar.gz
61b579e1e8174ae85c2b6e1372d4a0f7d728731032795ba50ff8b5fafef0e48b  guix-build-66c4b58e518a/output/riscv64-linux-gnu/SHA256SUMS.part
309378ea24e1c4029608263fb9a6310b8457047083c86d209cb2b39fbceb7cc5  guix-build-66c4b58e518a/output/riscv64-linux-gnu/bitcoin-66c4b58e518a-riscv64-linux-gnu-debug.tar.gz
b8c15e6f32097abc00a26a13af64213de98ffe7cde081f247e0ce2f91b5864bb  guix-build-66c4b58e518a/output/riscv64-linux-gnu/bitcoin-66c4b58e518a-riscv64-linux-gnu.tar.gz
baab1c7ae5a75add97602f77136a9d5a6df4c4e76528561de8fa26f5a284413b  guix-build-66c4b58e518a/output/x86_64-apple-darwin/SHA256SUMS.part
0bcb35054d1b3e40d33a270f86905157ac7507fc15fdfc2d006825791040099d  guix-build-66c4b58e518a/output/x86_64-apple-darwin/bitcoin-66c4b58e518a-x86_64-apple-darwin-unsigned.tar.gz
b308c7715814ee546f2f3b66f42fced1cde38e29979a6551e1be615d3cc42f84  guix-build-66c4b58e518a/output/x86_64-apple-darwin/bitcoin-66c4b58e518a-x86_64-apple-darwin-unsigned.zip
444ac5eeb627391e09dc7ef07b53b359f0a20c795e6bc9af2dae6142da36ed09  guix-build-66c4b58e518a/output/x86_64-apple-darwin/bitcoin-66c4b58e518a-x86_64-apple-darwin.tar.gz
e0604482cad9d85f22ee388e371219643fd862b5a3498575c833adb205c59d52  guix-build-66c4b58e518a/output/x86_64-linux-gnu/SHA256SUMS.part
c6011195f0e2ae34c2f8433145c1595b89a2ad4cecd479472d6776d567607a1a  guix-build-66c4b58e518a/output/x86_64-linux-gnu/bitcoin-66c4b58e518a-x86_64-linux-gnu-debug.tar.gz
4b1a86f447217b5dec9ce957049dbcd96bd5b8470f31d972d1fd483a58f18d32  guix-build-66c4b58e518a/output/x86_64-linux-gnu/bitcoin-66c4b58e518a-x86_64-linux-gnu.tar.gz
96ed252f85c9d7cb98b3020dcab184b8dcac11746dfc11b96101daeabb1f9530  guix-build-66c4b58e518a/output/x86_64-w64-mingw32/SHA256SUMS.part
c57be6253f755ea4d3b08f0348c3d6210dbf3884a52835ed06d0aebea3edee59  guix-build-66c4b58e518a/output/x86_64-w64-mingw32/bitcoin-66c4b58e518a-win64-debug.zip
58173b97084ae070576d447c5ee4673457e197da352a84684b1fbc9fb977349f  guix-build-66c4b58e518a/output/x86_64-w64-mingw32/bitcoin-66c4b58e518a-win64-setup-unsigned.exe
40463c75f29bec4de2e29c0d1ed1b2c8ee1a49111ebfc411799455e44b9d773a  guix-build-66c4b58e518a/output/x86_64-w64-mingw32/bitcoin-66c4b58e518a-win64-unsigned.tar.gz
022ef6e06743afe0c976150e6179ca75104dee1762591cd494b366d66cecca50  guix-build-66c4b58e518a/output/x86_64-w64-mingw32/bitcoin-66c4b58e518a-win64.zip

@DrahtBot DrahtBot requested a review from hebasto November 29, 2023 23:08
@DrahtBot
Copy link
Contributor

Guix builds (on x86_64)

File commit 7bc8c53
(master)
commit 9a648d0
(master and this pull)
SHA256SUMS.part 41271913616f9e9d... 592b05a960c0ac30...
*-aarch64-linux-gnu-debug.tar.gz 9a462abbea92c408... 619b4b168f4b5df4...
*-aarch64-linux-gnu.tar.gz 408db0ba23377e9a... 34a3a3f1461355a4...
*-arm-linux-gnueabihf-debug.tar.gz 24d5ac17eb43a3fe... 3e803291be9ecb43...
*-arm-linux-gnueabihf.tar.gz 8efa0df8138de545... 7a11ce03d3702672...
*-arm64-apple-darwin-unsigned.tar.gz d12354115312adc9... ec44e70391c09f15...
*-arm64-apple-darwin-unsigned.zip 66fda86732a6f7c7... 91c49388148caca8...
*-arm64-apple-darwin.tar.gz 541a0c4df8c6ab1e... 252f90c574f07df5...
*-powerpc64-linux-gnu-debug.tar.gz 91da457635c06939... be26289cf22bf8e3...
*-powerpc64-linux-gnu.tar.gz 6de43a525fd613e7... aa662b7fa188e858...
*-powerpc64le-linux-gnu-debug.tar.gz 3f196e043c6f3862... 000d8f08b35118a5...
*-powerpc64le-linux-gnu.tar.gz a28c3cdb9bcd51bc... 74f2fcbb771f4a17...
*-riscv64-linux-gnu-debug.tar.gz a5c07b18a9841847... de96b085804d7aa5...
*-riscv64-linux-gnu.tar.gz 6d6a7cbe184dc569... 4260c86424ca88ad...
*-x86_64-apple-darwin-unsigned.tar.gz f5e938e597ca6761... ac16bf12af179912...
*-x86_64-apple-darwin-unsigned.zip 04a57f310fdfd88d... 96f9160542cecf03...
*-x86_64-apple-darwin.tar.gz a4c8d9f8a4235bbc... 6986fad53b616da8...
*-x86_64-linux-gnu-debug.tar.gz 04323b5a3a67a1b4... 3b7227262d327e8d...
*-x86_64-linux-gnu.tar.gz ebf0412dba79f62e... 2bc8bfe1f4747060...
*.tar.gz f8419b5b77cf3fe3... 10f36ffa9bdcf4a4...
guix_build.log 55c8d661d0b2d707... ee636589ba089283...
guix_build.log.diff ef278e764358e5f8...

@fanquake fanquake merged commit c4d47d2 into bitcoin:master Nov 30, 2023
@fanquake fanquake deleted the guix_shell_over_environment branch November 30, 2023 14:53
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Feb 21, 2024
Summary:
See https://guix.gnu.org/manual/devel/en/html_node/Invoking-guix-environment.html.

> Deprecation warning: The guix environment command is deprecated in favor of guix shell, which performs similar functions but is more convenient to use. See Invoking guix shell.
>
> Being deprecated, guix environment is slated for eventual removal, but the Guix project is committed to keeping it until May 1st, 2023. Please get in touch with us at guix-devel@gnu.org if you would like to discuss it.

See also https://guix.gnu.org/blog/2021/from-guix-environment-to-guix-shell/
for a blog post and additional details.

Guix shell was added to guix in this commit, https://git.savannah.gnu.org/cgit/guix.git/commit/?id=80edb7df6586464aa40e84e103f0045452de95db which isn't part of the 1.3.0 release binaries out of the box, but invoking a guix pull, and updating will make it available for all builders.

This is a backport of [[bitcoin/bitcoin#26077 | core#26077]]

Backport note: since this PR there was a new guix release so the `shell` option is now available even without `guix pull`

Test Plan: `HOSTS="x86_64-linux-gnu" contrib/guix/guix-build`

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D15503
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Oct 24, 2024
…ell`

66c4b58 guix: switch from guix environment to guix shell (fanquake)

Pull request description:

  See https://guix.gnu.org/manual/devel/en/html_node/Invoking-guix-environment.html.

  > Deprecation warning: The guix environment command is deprecated
  in favor of guix shell, which performs similar functions but is more convenient to use. See Invoking guix shell.

  > Being deprecated, guix environment is slated for eventual removal,
  but the Guix project is committed to keeping it until May 1st, 2023. Please get in touch with us at guix-devel@gnu.org if you would like to discuss it.

  See also https://guix.gnu.org/blog/2021/from-guix-environment-to-guix-shell/ for a blog post and additional details.

  Guix `shell` was added to Guix ~1 year ago, in this commit, https://git.savannah.gnu.org/cgit/guix.git/commit/?id=80edb7df6586464aa40e84e103f0045452de95db, which isn't part of the 1.3.0 release binaries out of the box, but invoking a `guix pull`, and updating will make it available. i.e:
  ```bash
  bash-5.1# guix --version
  guix (GNU Guix) 1.3.0
  Copyright (C) 2021 the Guix authors
  License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
  This is free software: you are free to change and redistribute it.
  There is NO WARRANTY, to the extent permitted by law.

  bash-5.1# guix shell
  guix: shell: command not found
  Try 'guix --help' for more information.

  bash-5.1# guix pull
  Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.org/git/guix.git'...
  Authenticating channel 'guix', commits 9edb3f6 to 7a980bb (6,278 new commits)...
  Building from this channel:
    guix      https://git.savannah.gnu.org/git/guix.git7a980bb
  < snip >
  building /gnu/store/2wwwsczxcw61m05p4mv0kf0advx4fqsb-inferior-script.scm.drv...
  building package cache...
  building profile with 1 package...
  New in this revision:
    6,866 new packages: a2jmidid, abjad,

  bash-5.1# guix help shell
  Usage: guix shell [OPTION] PACKAGES... [-- COMMAND...]
  Build an environment that includes PACKAGES and execute COMMAND or an
  interactive shell in that environment.
  ```

ACKs for top commit:
  TheCharlatan:
    ACK 66c4b58

Tree-SHA512: caa3fd2ca8d0f261c50ecdda3728a75389d24d89b51293dedc704ee77ab1342b2bb08ca8c871dcb4646229f056ec86cb15500934ded1b0c501a3ffc25aaa8ae6
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Oct 24, 2024
…ell`

66c4b58 guix: switch from guix environment to guix shell (fanquake)

Pull request description:

  See https://guix.gnu.org/manual/devel/en/html_node/Invoking-guix-environment.html.

  > Deprecation warning: The guix environment command is deprecated
  in favor of guix shell, which performs similar functions but is more convenient to use. See Invoking guix shell.

  > Being deprecated, guix environment is slated for eventual removal,
  but the Guix project is committed to keeping it until May 1st, 2023. Please get in touch with us at guix-devel@gnu.org if you would like to discuss it.

  See also https://guix.gnu.org/blog/2021/from-guix-environment-to-guix-shell/ for a blog post and additional details.

  Guix `shell` was added to Guix ~1 year ago, in this commit, https://git.savannah.gnu.org/cgit/guix.git/commit/?id=80edb7df6586464aa40e84e103f0045452de95db, which isn't part of the 1.3.0 release binaries out of the box, but invoking a `guix pull`, and updating will make it available. i.e:
  ```bash
  bash-5.1# guix --version
  guix (GNU Guix) 1.3.0
  Copyright (C) 2021 the Guix authors
  License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
  This is free software: you are free to change and redistribute it.
  There is NO WARRANTY, to the extent permitted by law.

  bash-5.1# guix shell
  guix: shell: command not found
  Try 'guix --help' for more information.

  bash-5.1# guix pull
  Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.org/git/guix.git'...
  Authenticating channel 'guix', commits 9edb3f6 to 7a980bb (6,278 new commits)...
  Building from this channel:
    guix      https://git.savannah.gnu.org/git/guix.git7a980bb
  < snip >
  building /gnu/store/2wwwsczxcw61m05p4mv0kf0advx4fqsb-inferior-script.scm.drv...
  building package cache...
  building profile with 1 package...
  New in this revision:
    6,866 new packages: a2jmidid, abjad,

  bash-5.1# guix help shell
  Usage: guix shell [OPTION] PACKAGES... [-- COMMAND...]
  Build an environment that includes PACKAGES and execute COMMAND or an
  interactive shell in that environment.
  ```

ACKs for top commit:
  TheCharlatan:
    ACK 66c4b58

Tree-SHA512: caa3fd2ca8d0f261c50ecdda3728a75389d24d89b51293dedc704ee77ab1342b2bb08ca8c871dcb4646229f056ec86cb15500934ded1b0c501a3ffc25aaa8ae6
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Oct 24, 2024
…ell`

66c4b58 guix: switch from guix environment to guix shell (fanquake)

Pull request description:

  See https://guix.gnu.org/manual/devel/en/html_node/Invoking-guix-environment.html.

  > Deprecation warning: The guix environment command is deprecated
  in favor of guix shell, which performs similar functions but is more convenient to use. See Invoking guix shell.

  > Being deprecated, guix environment is slated for eventual removal,
  but the Guix project is committed to keeping it until May 1st, 2023. Please get in touch with us at guix-devel@gnu.org if you would like to discuss it.

  See also https://guix.gnu.org/blog/2021/from-guix-environment-to-guix-shell/ for a blog post and additional details.

  Guix `shell` was added to Guix ~1 year ago, in this commit, https://git.savannah.gnu.org/cgit/guix.git/commit/?id=80edb7df6586464aa40e84e103f0045452de95db, which isn't part of the 1.3.0 release binaries out of the box, but invoking a `guix pull`, and updating will make it available. i.e:
  ```bash
  bash-5.1# guix --version
  guix (GNU Guix) 1.3.0
  Copyright (C) 2021 the Guix authors
  License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
  This is free software: you are free to change and redistribute it.
  There is NO WARRANTY, to the extent permitted by law.

  bash-5.1# guix shell
  guix: shell: command not found
  Try 'guix --help' for more information.

  bash-5.1# guix pull
  Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.org/git/guix.git'...
  Authenticating channel 'guix', commits 9edb3f6 to 7a980bb (6,278 new commits)...
  Building from this channel:
    guix      https://git.savannah.gnu.org/git/guix.git7a980bb
  < snip >
  building /gnu/store/2wwwsczxcw61m05p4mv0kf0advx4fqsb-inferior-script.scm.drv...
  building package cache...
  building profile with 1 package...
  New in this revision:
    6,866 new packages: a2jmidid, abjad,

  bash-5.1# guix help shell
  Usage: guix shell [OPTION] PACKAGES... [-- COMMAND...]
  Build an environment that includes PACKAGES and execute COMMAND or an
  interactive shell in that environment.
  ```

ACKs for top commit:
  TheCharlatan:
    ACK 66c4b58

Tree-SHA512: caa3fd2ca8d0f261c50ecdda3728a75389d24d89b51293dedc704ee77ab1342b2bb08ca8c871dcb4646229f056ec86cb15500934ded1b0c501a3ffc25aaa8ae6
PastaPastaPasta added a commit to dashpay/dash that referenced this pull request Oct 24, 2024
8bf1d06 Merge bitcoin#29308: doc: update `BroadcastTransaction` comment (glozow)
2a77808 Merge bitcoin-core/gui#789: Avoid non-self-contained Windows header (Hennadii Stepanov)
da371b8 Merge bitcoin#28870: depends: Include `config.guess` and `config.sub` into `meta_depends` (fanquake)
2e41562 Merge bitcoin#29219: fuzz: Improve fuzzing stability for ellswift_roundtrip harness (fanquake)
b091329 Merge bitcoin#29211: fuzz: fix `connman` initialization (Ava Chow)
df42d41 Merge bitcoin#29200: net: create I2P sessions using both ECIES-X25519 and ElGamal encryption (fanquake)
4cdd1a8 Merge bitcoin#29172: fuzz: set `nMaxOutboundLimit` in connman target (fanquake)
97012ea Merge bitcoin#28962: doc: Rework guix docs after 1.4 release (fanquake)
c70ff5d Merge bitcoin#28844: contrib: drop GCC MAX_VERSION to 4.3.0 in symbol-check (fanquake)
e6f19e7 Merge bitcoin#29068: test: Actually fail when a python unit test fails (fanquake)
75e0334 Merge bitcoin#28989: test: Fix test by checking the actual exception instance (Andrew Chow)
8cd85d3 Merge bitcoin#28852: script, assumeutxo: Enhance validations in utxo_snapshot.sh (Ryan Ofsky)
fd2e88d Merge bitcoin#26077: guix: switch from `guix environment` to `guix shell` (fanquake)
02741a7 Merge bitcoin#28913: coins: make sure PoolAllocator uses the correct alignment (fanquake)
dfd53da Merge bitcoin#28902: doc: Simplify guix install doc, after 1.4 release (fanquake)

Pull request description:

  ## Issue being fixed or feature implemented
  Batch of trivial backports

  ## What was done?
  See commits

  ## How Has This Been Tested?
  built locally; large combined merge passed tests locally

  ## Breaking Changes
  Should be none

  ## Checklist:
    _Go over all the following points, and put an `x` in all the boxes that apply._
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  UdjinM6:
    utACK 8bf1d06
  knst:
    utACK 8bf1d06

Tree-SHA512: 506273e5a188f9ca74edf656e3cd338992192e6e97f68c89fc43e34be20fb7f211b48e4dfa8693727839a7920da8284509413c722f55774a428939c296dad517
@bitcoin bitcoin locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants