test: add ripemd160 to test framework modules list #27542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
lgtm ACK 768ae17 |
maflcko
reviewed
May 2, 2023
Currently test runner doesn't execute the unit tests of the ripemd160 module, so add it to the list. All other framework modules that contain unit tests are included, as can be easily checked via `git grep unittest.TestCase ./test/functional/test_framework/` This is a late follow-up to PR bitcoin#23716 (commit ad3e9e1).
768ae17 to
82e6e3c
Compare
|
lgtm ACK 82e6e3c |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 4, 2023
82e6e3c test: add ripemd160 to test framework modules list (Sebastian Falbesoner) Pull request description: Currently test runner doesn't execute the unit tests of the ripemd160 module, so add it to the list. All other framework modules that contain unit tests are included, as can be easily checked via `$ git grep unittest.TestCase ./test/functional/test_framework/` This is a late follow-up to PR bitcoin#23716 (commit ad3e9e1). ACKs for top commit: MarcoFalke: lgtm ACK 82e6e3c Tree-SHA512: 10940e215f728291c7149931a356bfc42795c098bda76d760dfa68f86443a3755e1cd35cb9a8a7b2f48880beb53f3bee3842de2d74bcadd45c7b05c13ff04203
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Aug 16, 2023
Currently test runner doesn't execute the unit tests of the ripemd160 module, so add it to the list. All other framework modules that contain unit tests are included, as can be easily checked via `git grep unittest.TestCase ./test/functional/test_framework/` This is a late follow-up to PR bitcoin#23716 (commit ad3e9e1). Github-Pull: bitcoin#27542 Rebased-From: 82e6e3c
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Feb 14, 2024
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Feb 14, 2024
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Feb 14, 2024
5 tasks
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Feb 15, 2024
PastaPastaPasta
pushed a commit
to kwvg/dash
that referenced
this pull request
Feb 19, 2024
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Feb 19, 2024
backport: merge bitcoin#22029, bitcoin#27538, bitcoin#21100, bitcoin#27542, bitcoin#24005, partial bitcoin#19953, bitcoin#23394, bitcoin#20292, bitcoin#20161, bitcoin#20842, bitcoin#26222 (secp256k1 tests)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently test runner doesn't execute the unit tests of the ripemd160 module, so add it to the list. All other framework modules that contain unit tests are included, as can be easily checked via
$ git grep unittest.TestCase ./test/functional/test_framework/This is a late follow-up to PR #23716 (commit ad3e9e1).