test: Remove modinv python util helper function #27538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Concept ACK |
maflcko
reviewed
Apr 28, 2023
|
Concept ACK also did a grep for modinv in /test and looks like you got all them |
theStack
approved these changes
Apr 28, 2023
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 1, 2023
stratospher
added a commit
to stratospher/bitcoin
that referenced
this pull request
Jun 9, 2023
remove util also since unit tests there were removed in bitcoin#27538 Co-authored-by: theStack <sebastian.falbesoner@gmail.com>
stratospher
added a commit
to stratospher/bitcoin
that referenced
this pull request
Jun 28, 2023
remove util also since unit tests there were removed in bitcoin#27538 Co-authored-by: theStack <sebastian.falbesoner@gmail.com>
stratospher
added a commit
to stratospher/bitcoin
that referenced
this pull request
Jun 29, 2023
remove util also since unit tests there were removed in bitcoin#27538 Co-authored-by: theStack <sebastian.falbesoner@gmail.com>
stratospher
added a commit
to stratospher/bitcoin
that referenced
this pull request
Jun 29, 2023
remove util also since unit tests there were removed in bitcoin#27538 Co-authored-by: theStack <sebastian.falbesoner@gmail.com>
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Feb 14, 2024
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Feb 14, 2024
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Feb 14, 2024
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Feb 15, 2024
PastaPastaPasta
pushed a commit
to kwvg/dash
that referenced
this pull request
Feb 19, 2024
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Feb 19, 2024
backport: merge bitcoin#22029, bitcoin#27538, bitcoin#21100, bitcoin#27542, bitcoin#24005, partial bitcoin#19953, bitcoin#23394, bitcoin#20292, bitcoin#20161, bitcoin#20842, bitcoin#26222 (secp256k1 tests)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #27483 was merged the
modinv()body is just one line calling pythons own implementation ofpow(). We can just remove the function as it doesn't seem to add any value. Additionally the comment in the function is now outdated and the test is only testing two ways of doing modular inverse but both using python'spow()function.