test: add python implementation of Elligator swift #24005

stratospher · 2022-01-07T16:33:19Z

Built on top of #26222.

This PR introduces Elligator swift encoding and decoding in the functional test framework. It's used in #24748 for writing p2p encryption tests.

sipa

Cool! Nice to see this works.

I've left a number of comments to simplify the code.

test/functional/test_framework/key.py

test/functional/test_framework/ellsq.py

stratospher · 2022-01-08T14:47:46Z

Thanks for your really nice review @sipa! I’ve addressed your comments. Ready for further review.

test/functional/test_framework/key.py

test/functional/test_framework/ellsq.py

stratospher · 2022-01-08T15:40:20Z

Thanks again @sipa! I’ve addressed your comments. Ready for further review.

DrahtBot · 2022-01-08T18:42:18Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	theStack, sipa

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#27452 (test: cover addrv2 anchors by adding TorV3 to CAddress in messages.py by pinheadmz)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

test/functional/test_framework/ellsq.py

stratospher · 2022-01-08T21:23:54Z

Thanks again @sipa! I’ve addressed your comments. Ready for further review.

stratospher · 2022-02-03T19:33:11Z

Made some changes to simplify the Elligator squared interface

interact with pubkeys instead of group elements. (added get_group_element() and set_from_curve_point() in ECPubkey for this purpose)
rename encode_bytes() to ellsq_encode() and decode_bytes() to ellsq_decode()
sort TEST_FRAMEWORK_MODULES in alphabetical order

stratospher · 2022-04-02T15:21:07Z

Updated the elligator squared encoding function signature from ellsq_encode(pubkey) to ellsq_encode(pubkey, randombytes) in order to test the BIP 324 test vectors in python.

test/functional/test_framework/ellsq.py

theStack · 2022-07-17T18:14:51Z

Concept ACK

stratospher · 2022-10-03T19:20:48Z

updates include:
- elligator swift instead of elligator squared
- built on top of Introduce secp256k1 module with field and group classes to test framework #26222
references - ElligatorSwift + integrated x-only DH bitcoin-core/secp256k1#1129, https://github.com/sipa/bitcoin/tree/202209_ellswift_py
for test/BIP324: functional tests for v2 P2P encryption #24748, we'd want to keep the entropy derivations(like for u, j, in ellswift_create()) similar to how it's done in PR 1129

test/functional/test_framework/ellswift.py

sipa · 2023-06-28T17:52:02Z

@stratospher Want to rebase? It'd be good to get rid of the merge commit in this PR's history.

stratospher · 2023-06-28T18:51:55Z

Rebased on master, updated to address review comment and to just use commits from 26222 which this depends on.

maflcko · 2023-06-29T06:43:44Z

Are you sure you rebased on current master?

sipa

Code review ACK afd762a

test/functional/test_framework/ellswift.py

theStack

Code-review ACK afd762a

Regarding #24005 (comment), I've prepared at least adding the BIP324 decoding test vectors today (theStack@06c9424). Feel free to pick it up either in this PR or a follow-up.

test/functional/test_framework/ellswift.py

Co-authored-by: Pieter Wuille <pieter.wuille@gmail.com>

remove util also since unit tests there were removed in bitcoin#27538 Co-authored-by: theStack <sebastian.falbesoner@gmail.com>

The test vector input file is taken from: 1. https://github.com/bitcoin/bips/blob/master/bip-0324/xswiftec_inv_test_vectors.csv 2. https://github.com/bitcoin/bips/blob/master/bip-0324/ellswift_decode_test_vectors.csv Co-authored-by: theStack <sebastian.falbesoner@gmail.com>

stratospher · 2023-06-29T18:23:55Z

Thanks @sipa, @theStack! I've updated to include ellswift test vectors from BIP 324 + addressed review comments.

theStack

ACK 4f4d039 🐊

Checked that since my previous ACK, review suggestions were tackled and the ellswift encoding/decoding test vectors were added (nice, wasn't aware of csv.DictReader)! Also verified that the added .csv files are identical to the ones from the BIP repository.

sipa · 2023-06-30T18:16:49Z

ACK 4f4d039

4f4d039 test: add ellswift test vectors from BIP324 (stratospher) a312877 test: Add ellswift unit tests (stratospher) 714fb2c test: Add python ellswift implementation to test framework (stratospher) Pull request description: Built on top of bitcoin#26222. This PR introduces Elligator swift encoding and decoding in the functional test framework. It's used in bitcoin#24748 for writing p2p encryption tests. ACKs for top commit: sipa: ACK 4f4d039 theStack: ACK 4f4d039 🐊 Tree-SHA512: 32bc8e88f715f2cd67dc04cd38db92680872072cb3775478e2c30da89aa2da2742992779ea14da2f1faca09228942cfbd86d6957402b24bf560244b389e03540

backport: merge bitcoin#22029, bitcoin#27538, bitcoin#21100, bitcoin#27542, bitcoin#24005, partial bitcoin#19953, bitcoin#23394, bitcoin#20292, bitcoin#20161, bitcoin#20842, bitcoin#26222 (secp256k1 tests)

DrahtBot added the Tests label Jan 7, 2022

sipa reviewed Jan 7, 2022

View reviewed changes

stratospher force-pushed the py-ellsq branch 2 times, most recently from 8cdf579 to e755867 Compare January 8, 2022 14:32

sipa reviewed Jan 8, 2022

View reviewed changes

stratospher force-pushed the py-ellsq branch from e755867 to 90d044f Compare January 8, 2022 15:36

sipa reviewed Jan 8, 2022

View reviewed changes

stratospher force-pushed the py-ellsq branch from 90d044f to ff16f37 Compare January 8, 2022 21:19

DrahtBot mentioned this pull request Jan 8, 2022

[WIP] Add Python ChaCha20 and bindings for CPP ChaCha20 #22851

Closed

stratospher force-pushed the py-ellsq branch from ff16f37 to f8e8a8d Compare February 3, 2022 19:30

stratospher force-pushed the py-ellsq branch from f8e8a8d to 6936ae2 Compare February 4, 2022 04:08

stratospher force-pushed the py-ellsq branch from 6936ae2 to 3fbe690 Compare April 2, 2022 15:20

stratospher force-pushed the py-ellsq branch from 3fbe690 to 0650f1f Compare April 2, 2022 17:14

stratospher mentioned this pull request Apr 3, 2022

test/BIP324: functional tests for v2 P2P encryption #24748

Merged

KevinMusgrave reviewed Apr 4, 2022

View reviewed changes

test/functional/test_framework/ellsq.py Outdated Show resolved Hide resolved

rage-proof reviewed May 9, 2022

View reviewed changes

test/functional/test_framework/ellsq.py Outdated Show resolved Hide resolved

DrahtBot mentioned this pull request Oct 1, 2022

Introduce secp256k1 module with field and group classes to test framework #26222

Merged

stratospher force-pushed the py-ellsq branch from 0650f1f to fe544ad Compare October 3, 2022 18:53

stratospher changed the title ~~test: add python implementation of Elligator squared~~ test: add python implementation of Elligator swift Oct 3, 2022

sipa reviewed Oct 3, 2022

View reviewed changes

test/functional/test_framework/ellswift.py Outdated Show resolved Hide resolved

DrahtBot mentioned this pull request Oct 5, 2022

script, test: python linter flake8 E275 fixup, update dependencies #26257

Merged

DrahtBot mentioned this pull request Nov 8, 2022

scripted diff: fix E275 lint #26468

Closed

DrahtBot mentioned this pull request Jun 9, 2023

[NO MERGE] BIP331 Ancestor Package Relay #27742

Closed

theStack reviewed Jun 22, 2023

View reviewed changes

test/functional/test_framework/ellswift.py Outdated Show resolved Hide resolved

DrahtBot mentioned this pull request Jun 23, 2023

test: cover addrv2 anchors by adding TorV3 to CAddress in messages.py #27452

Merged

stratospher force-pushed the py-ellsq branch from a250d70 to eeb44ff Compare June 28, 2023 18:44

stratospher force-pushed the py-ellsq branch from eeb44ff to afd762a Compare June 29, 2023 06:49

DrahtBot removed the CI failed label Jun 29, 2023

sipa reviewed Jun 29, 2023

View reviewed changes

test/functional/test_framework/ellswift.py Show resolved Hide resolved

test/functional/test_framework/ellswift.py Show resolved Hide resolved

theStack approved these changes Jun 29, 2023

View reviewed changes

test/functional/test_framework/ellswift.py Outdated Show resolved Hide resolved

stratospher and others added 3 commits June 29, 2023 23:32

test: Add python ellswift implementation to test framework

714fb2c

Co-authored-by: Pieter Wuille <pieter.wuille@gmail.com>

test: Add ellswift unit tests

a312877

remove util also since unit tests there were removed in bitcoin#27538 Co-authored-by: theStack <sebastian.falbesoner@gmail.com>

stratospher force-pushed the py-ellsq branch from afd762a to 4f4d039 Compare June 29, 2023 18:11

theStack approved these changes Jun 29, 2023

View reviewed changes

DrahtBot requested a review from sipa June 29, 2023 21:52

DrahtBot removed the request for review from sipa June 30, 2023 18:16

fanquake merged commit 61d59fe into bitcoin:master Jun 30, 2023

kwvg added a commit to kwvg/dash that referenced this pull request Feb 14, 2024

merge bitcoin#24005: add python implementation of Elligator swift

af2c149

kwvg added a commit to kwvg/dash that referenced this pull request Feb 14, 2024

merge bitcoin#24005: add python implementation of Elligator swift

a92fc01

kwvg added a commit to kwvg/dash that referenced this pull request Feb 14, 2024

merge bitcoin#24005: add python implementation of Elligator swift

f8061fd

kwvg added a commit to kwvg/dash that referenced this pull request Feb 15, 2024

merge bitcoin#24005: add python implementation of Elligator swift

cfc2c4e

PastaPastaPasta pushed a commit to kwvg/dash that referenced this pull request Feb 19, 2024

merge bitcoin#24005: add python implementation of Elligator swift

3710439

bitcoin locked and limited conversation to collaborators Jun 29, 2024

stratospher deleted the py-ellsq branch July 17, 2024 06:40

test: add python implementation of Elligator swift #24005

test: add python implementation of Elligator swift #24005

Uh oh!

Conversation

stratospher commented Jan 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sipa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stratospher commented Jan 8, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stratospher commented Jan 8, 2022

Uh oh!

DrahtBot commented Jan 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews

Conflicts

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stratospher commented Jan 8, 2022

Uh oh!

stratospher commented Feb 3, 2022

Uh oh!

stratospher commented Apr 2, 2022

Uh oh!

Uh oh!

Uh oh!

theStack commented Jul 17, 2022

Uh oh!

stratospher commented Oct 3, 2022

Uh oh!

Uh oh!

Uh oh!

sipa commented Jun 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stratospher commented Jun 28, 2023

Uh oh!

maflcko commented Jun 29, 2023

Uh oh!

sipa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

theStack left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stratospher commented Jun 29, 2023

Uh oh!

stratospher commented Jan 7, 2022 •

edited

Loading

DrahtBot commented Jan 8, 2022 •

edited

Loading

sipa commented Jun 28, 2023 •

edited

Loading