lcov: filter depends from coverage reports #17647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
a6a7c1b to
a5a705b
Compare
|
|
maflcko
reviewed
Dec 8, 2019
| LCOV_FILTER_PATTERN=-p "/usr/include/" -p "/usr/lib/" -p "src/leveldb/" -p "src/bench/" -p "src/univalue" -p "src/crypto/ctaes" -p "src/secp256k1" | ||
| LCOV_FILTER_PATTERN = \ | ||
| -p "/usr/include/" \ | ||
| -p "/usr/lib/" \ |
There was a problem hiding this comment.
Could you add a commit to also exclude lib64, please. This shows up when compiling with clang-8 for example:
https://pbs.twimg.com/media/ELKJFh3XsAAM6mJ?format=png&name=medium
There was a problem hiding this comment.
Done! Guessing that I should squash the commits too?
There was a problem hiding this comment.
I think it's fine to have these as separate commits, they're not really related
There was a problem hiding this comment.
Sounds good, will keep it as is! 👌
|
code review ACK f736f69 |
|
ACK f736f69 🐇 Show signature and timestampSignature: Timestamp of file with hash |
maflcko
pushed a commit
that referenced
this pull request
Dec 9, 2019
f736f69 lcov: filter /usr/lib64 from coverage report (nijynot) a5a705b lcov: filter depends from coverage report (nijynot) Pull request description: If you build the binaries with the `depends` folder and then generate coverage reports with `make cov`, `depends` will be included in the coverage reports. Coverage of the dependencies are not that interesting and should be filtered. ACKs for top commit: laanwj: code review ACK f736f69 MarcoFalke: ACK f736f69 🐇 Tree-SHA512: 57c3e09f32e71523afff6ddc4f92bc35ab7b783f26f7a7380ae7556222954111cccce4c6dbc99305c424818f91e15bf5fe3532a7dca1daaa8ad71315d1dd857c
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 9, 2019
f736f69 lcov: filter /usr/lib64 from coverage report (nijynot) a5a705b lcov: filter depends from coverage report (nijynot) Pull request description: If you build the binaries with the `depends` folder and then generate coverage reports with `make cov`, `depends` will be included in the coverage reports. Coverage of the dependencies are not that interesting and should be filtered. ACKs for top commit: laanwj: code review ACK f736f69 MarcoFalke: ACK f736f69 🐇 Tree-SHA512: 57c3e09f32e71523afff6ddc4f92bc35ab7b783f26f7a7380ae7556222954111cccce4c6dbc99305c424818f91e15bf5fe3532a7dca1daaa8ad71315d1dd857c
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Feb 20, 2020
Summary: ``` If you build the binaries with the depends folder and then generate coverage reports with make cov, depends will be included in the coverage reports. Coverage of the dependencies are not that interesting and should be filtered. ``` Backport of core [[bitcoin/bitcoin#17647 | PR17647]]. Depends on D5301. Test Plan: ../configure --prefix=$PWD/../depends/x86_64-linux-gnu --enable-lcov make make cov Check there is no `depends/` subdir under `total.coverage`. Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D5303
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
May 19, 2020
Summary: ``` If you build the binaries with the depends folder and then generate coverage reports with make cov, depends will be included in the coverage reports. Coverage of the dependencies are not that interesting and should be filtered. ``` Backport of core [[bitcoin/bitcoin#17647 | PR17647]]. Depends on D5301. Test Plan: ../configure --prefix=$PWD/../depends/x86_64-linux-gnu --enable-lcov make make cov Check there is no `depends/` subdir under `total.coverage`. Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D5303
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
f736f69 lcov: filter /usr/lib64 from coverage report (nijynot) a5a705b lcov: filter depends from coverage report (nijynot) Pull request description: If you build the binaries with the `depends` folder and then generate coverage reports with `make cov`, `depends` will be included in the coverage reports. Coverage of the dependencies are not that interesting and should be filtered. ACKs for top commit: laanwj: code review ACK f736f69 MarcoFalke: ACK f736f69 🐇 Tree-SHA512: 57c3e09f32e71523afff6ddc4f92bc35ab7b783f26f7a7380ae7556222954111cccce4c6dbc99305c424818f91e15bf5fe3532a7dca1daaa8ad71315d1dd857c
knst
pushed a commit
to knst/dash
that referenced
this pull request
May 26, 2022
f736f69 lcov: filter /usr/lib64 from coverage report (nijynot) a5a705b lcov: filter depends from coverage report (nijynot) Pull request description: If you build the binaries with the `depends` folder and then generate coverage reports with `make cov`, `depends` will be included in the coverage reports. Coverage of the dependencies are not that interesting and should be filtered. ACKs for top commit: laanwj: code review ACK f736f69 MarcoFalke: ACK f736f69 🐇 Tree-SHA512: 57c3e09f32e71523afff6ddc4f92bc35ab7b783f26f7a7380ae7556222954111cccce4c6dbc99305c424818f91e15bf5fe3532a7dca1daaa8ad71315d1dd857c
knst
pushed a commit
to knst/dash
that referenced
this pull request
May 27, 2022
f736f69 lcov: filter /usr/lib64 from coverage report (nijynot) a5a705b lcov: filter depends from coverage report (nijynot) Pull request description: If you build the binaries with the `depends` folder and then generate coverage reports with `make cov`, `depends` will be included in the coverage reports. Coverage of the dependencies are not that interesting and should be filtered. ACKs for top commit: laanwj: code review ACK f736f69 MarcoFalke: ACK f736f69 🐇 Tree-SHA512: 57c3e09f32e71523afff6ddc4f92bc35ab7b783f26f7a7380ae7556222954111cccce4c6dbc99305c424818f91e15bf5fe3532a7dca1daaa8ad71315d1dd857c
knst
pushed a commit
to knst/dash
that referenced
this pull request
May 30, 2022
f736f69 lcov: filter /usr/lib64 from coverage report (nijynot) a5a705b lcov: filter depends from coverage report (nijynot) Pull request description: If you build the binaries with the `depends` folder and then generate coverage reports with `make cov`, `depends` will be included in the coverage reports. Coverage of the dependencies are not that interesting and should be filtered. ACKs for top commit: laanwj: code review ACK f736f69 MarcoFalke: ACK f736f69 🐇 Tree-SHA512: 57c3e09f32e71523afff6ddc4f92bc35ab7b783f26f7a7380ae7556222954111cccce4c6dbc99305c424818f91e15bf5fe3532a7dca1daaa8ad71315d1dd857c
UdjinM6
added a commit
to dashpay/dash
that referenced
this pull request
Jun 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you build the binaries with the
dependsfolder and then generate coverage reports withmake cov,dependswill be included in the coverage reports. Coverage of the dependencies are not that interesting and should be filtered.