depends: add ability to skip building qrencode #17658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK. NO_BOOST next? 😄 |
|
Concept ACK Very nice! |
Likely because boost has its own scrapheap of a build system… this will need a specific change similar to #17466 for Qt. can you please create a new issue for this |
Gitian builds
|
|
ACK c8becb8. |
laanwj
added a commit
that referenced
this pull request
Dec 7, 2019
c8becb8 depends: add ability to skip building qrencode (fanquake) Pull request description: Similar to other depends packages, add the ability to skip building `qrencode` by passing `NO_QR=1`. Same as #16089. ACKs for top commit: promag: ACK c8becb8. hebasto: ACK c8becb8, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: 86c7a87a31b1b2e65be2b79f533ce49f8b0074cf31331411cb3d32bb542d0b99e69605482ad75e4d1be5f2c8c613f17ba9ff17195a6b48f45365f5eb35df8bf9
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 7, 2019
c8becb8 depends: add ability to skip building qrencode (fanquake) Pull request description: Similar to other depends packages, add the ability to skip building `qrencode` by passing `NO_QR=1`. Same as bitcoin#16089. ACKs for top commit: promag: ACK c8becb8. hebasto: ACK c8becb8, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: 86c7a87a31b1b2e65be2b79f533ce49f8b0074cf31331411cb3d32bb542d0b99e69605482ad75e4d1be5f2c8c613f17ba9ff17195a6b48f45365f5eb35df8bf9
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Apr 3, 2020
Summary: ``` Similar to other depends packages, add the ability to skip building qrencode by passing NO_QR=1. ``` Backport of core [[bitcoin/bitcoin#17658 | PR17658]]. Test Plan: make build-osx NO_QR=1 Check the qrencode lib is not built. Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5664
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
c8becb8 depends: add ability to skip building qrencode (fanquake) Pull request description: Similar to other depends packages, add the ability to skip building `qrencode` by passing `NO_QR=1`. Same as bitcoin#16089. ACKs for top commit: promag: ACK c8becb8. hebasto: ACK c8becb8, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: 86c7a87a31b1b2e65be2b79f533ce49f8b0074cf31331411cb3d32bb542d0b99e69605482ad75e4d1be5f2c8c613f17ba9ff17195a6b48f45365f5eb35df8bf9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to other depends packages, add the ability to skip building
qrencodeby passingNO_QR=1. Same as #16089.