Make env data logging optional #17699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK 0ccad08 -- less noise is good and diff looks correct |
|
ACK 0ccad08 |
|
ACK 0ccad08. |
laanwj
added a commit
that referenced
this pull request
Dec 9, 2019
0ccad08 Make env data logging optional (Pieter Wuille) Pull request description: The dynamic env feeding logging is a bit chatty, make it dependent on `-debug=rand`. ACKs for top commit: practicalswift: ACK 0ccad08 -- less noise is good and diff looks correct laanwj: ACK 0ccad08 promag: ACK 0ccad08. jonatack: ACK 0ccad08, was considering to propose this. Tree-SHA512: 01d7f9ac134852c2c0d5f66f96ee4395f0ff7a60573e648f3d01054073624042148c8e8b9f69a29c9a41c296e1f4be77c2015a642ee4113a2fd8779b62aa137d
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
May 31, 2020
Summary: ``` The dynamic env feeding logging is a bit chatty, make it dependent on -debug=rand. ``` Backport of core [[bitcoin/bitcoin#17699 | PR17699]]. Test Plan: Run `bitcoind` and check the log is much more quite. Run `bitcoind -debug=rand` and check the log has the same output as before this diff. Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6306
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamic env feeding logging is a bit chatty, make it dependent on
-debug=rand.