Remove redundant class file include from test_bitcoin msvc project #17404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Nov 7, 2019
|
ACK b80f7db 🔅 Show signature and timestampSignature: Timestamp of file with hash |
fanquake
added a commit
that referenced
this pull request
Nov 7, 2019
…svc project b80f7db Remove redundant class file includes from test_bitcoin project. (Aaron Clauson) Pull request description: #17364 & #17384 overlapped and both added the same line of `..\..\src\test\util\*.cpp` to `test_bitcoin.vcxproj`. This didn't break the build but does result in duplicate symbol warnings. This PR cleans it up and removes the additional redundant line of `..\..\src\test\util\setup_common.cpp` which will also be covered by the wildcard include. ACKs for top commit: MarcoFalke: ACK b80f7db 🔅 fanquake: ACK b80f7db - tested a build on a Windows machine. No longer see the warnings shown below: Tree-SHA512: 55960821480483c517b475f2a6871cd7d4033d086db3fd679aa0de362e4f7e2c3ac7967ca278cc3728cc765ba23d4441ec769d83d7a47e7a3fa2f09de2bbc145
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17364 & #17384 overlapped and both added the same line of
..\..\src\test\util\*.cpptotest_bitcoin.vcxproj. This didn't break the build but does result in duplicate symbol warnings. This PR cleans it up and removes the additional redundant line of..\..\src\test\util\setup_common.cppwhich will also be covered by the wildcard include.