Skip to content

tests: Add AddressSanitizer (ASan) Travis build #14794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 27, 2018
Merged

tests: Add AddressSanitizer (ASan) Travis build #14794

merged 3 commits into from
Nov 27, 2018

Conversation

practicalswift
Copy link
Contributor

Add ASan Travis build.

maflcko
maflcko reviewed Nov 23, 2018
View reviewed changes
@fanquake fanquake added the Tests label Nov 23, 2018
@sipa
Copy link
Member

sipa commented Nov 24, 2018

Any reason to not enable ASan and UBSan in the same test?

@practicalswift practicalswift force-pushed the asan-in-travis branch 3 times, most recently from 7fdb0a7 to 7e5e3fa Compare November 25, 2018 22:03
maflcko
maflcko reviewed Nov 25, 2018
View reviewed changes
@practicalswift practicalswift force-pushed the asan-in-travis branch 7 times, most recently from 64b8928 to 0a88263 Compare November 26, 2018 11:10
@practicalswift practicalswift changed the title [wip] Add ASan Travis build Add ASan Travis build Nov 26, 2018
@practicalswift
Copy link
Contributor Author

@sipa I was afraid the combined runtime would be too long, but it appears to work. The two Travis jobs have now been merged. Please review.

@MarcoFalke Now running also with LSan (LeakSanitizer). Please review :-)

@maflcko
Copy link
Member

maflcko commented Nov 26, 2018

Could squash everything except the changes in test/functional?

@practicalswift practicalswift changed the title Add ASan Travis build Add AddressSanitizer (ASan) Travis build Nov 26, 2018
@practicalswift
Copy link
Contributor Author

@MarcoFalke Done! Please re-review :-)

maflcko
maflcko approved these changes Nov 26, 2018
View reviewed changes
@maflcko maflcko changed the title Add AddressSanitizer (ASan) Travis build tests: Add AddressSanitizer (ASan) Travis build Nov 26, 2018
@practicalswift
Copy link
Contributor Author

@MarcoFalke Added comments as suggested. Please re-review :-)

maflcko
maflcko previously requested changes Nov 26, 2018
View reviewed changes
@practicalswift practicalswift force-pushed the asan-in-travis branch 2 times, most recently from 78a62b6 to 65b019a Compare November 26, 2018 22:31
vijaydasmp added a commit to vijaydasmp/dash that referenced this pull request Oct 1, 2021
@vijaydasmp
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build …
8b879c0 
…(Git add)
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Oct 2, 2021
@vijaydasmp
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
3d9ac56 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
vijaydasmp added a commit to vijaydasmp/dash that referenced this pull request Oct 2, 2021
@vijaydasmp
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build …
0a5485a 
…(clang-8)
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Oct 4, 2021
@vijaydasmp
Merge bitcoin#18288: build: Add MemorySanitizer (MSan) in Travis to d…
dfa262c 
…etect use of uninitialized memory

870f0cd build: Add MemorySanitizer (MSan) in Travis to detect use of uninitialized memory (practicalswift)

Pull request description:

  Add MemorySanitizer (MSan) in Travis to detect use of uninitialized memory.

  First UBSan, then ASan followed by TSan... and now: yes, the wait is over -- **MSan is finally here!** :)

  Some historical context:
  * 2017: Continuous compilation with Clang Thread Safety analysis enabled (bitcoin#10866, bitcoin#10923)
  * 2018: Continuous testing with trapping on signed integer overflows (`-ftrapv`) (bitcoin#12686)
  * 2018: Continuous testing of use of locale dependent functions (bitcoin#13041)
  * 2018: Continuous testing of format strings (bitcoin#13705)
  * 2018: Continuous compilation with MSVC `TreatWarningAsError` (bitcoin#14151)
  * 2018: Continuous testing under UndefinedBehaviorSanitizer – UBSan (bitcoin#14252, bitcoin#14673, bitcoin#17006)
  * 2018: Continuous testing under AddressSanitizer – ASan (bitcoin#14794, bitcoin#17205, bitcoin#17674)
  * 2018: Continuous testing under ThreadSanitizer – TSan (bitcoin#14829)
  * 2019: Continuous testing in an unsigned char environment (`-funsigned-char`) (bitcoin#15134)
  * 2019: Continuous compile-time testing of assumptions we're making (bitcoin#15391)
  * 2019: Continuous testing of fuzz test cases under Valgrind (bitcoin#17633, bitcoin#18159, bitcoin#18166)
  * 2020: Finally... MemorySanitizer – MSAN! :)

  What is the next step? What tools should we add to CI to keep bugs from entering `master`? :)

ACKs for top commit:
  MarcoFalke:
    ACK 870f0cd

Tree-SHA512: 38327c8b75679d97d469fe42e704cacd1217447a5a603701dd8a58ee50b3be2c10248f8d68a479ed081c0c4b254589d3081c9183f991640b06ef689061f75578
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Dec 28, 2021
@Munkybooty
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
4a8fed4 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Dec 28, 2021
@Munkybooty
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
787b098 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Dec 28, 2021
@Munkybooty
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
ef37894 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Dec 28, 2021
@Munkybooty
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
4a1ded4 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Dec 28, 2021
@Munkybooty
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
d63f010 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Jan 3, 2022
@Munkybooty
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
6a9b1e8 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Feb 1, 2022
@Munkybooty
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
b58970a 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Feb 16, 2022
@Munkybooty
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
eb1ddaf 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Feb 24, 2022
@Munkybooty
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
3a2135f 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Feb 24, 2022
@Munkybooty
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
1bed846 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Mar 6, 2022
@Munkybooty
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
e7efb94 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Mar 20, 2022
@Munkybooty
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
99ef216 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
kwvg added a commit to kwvg/dash that referenced this pull request Mar 25, 2022
@kwvg
merge bitcoin#14794: Add AddressSanitizer (ASan) Travis build
8b6ae1e
kwvg added a commit to kwvg/dash that referenced this pull request Apr 7, 2022
@kwvg
merge bitcoin#14794: Add AddressSanitizer (ASan) Travis build
274d35d
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Apr 21, 2022
@Munkybooty
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
81578b3 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Apr 26, 2022
@Munkybooty
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
b03cd82 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Apr 29, 2022
@Munkybooty
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
b3ceb1a 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request May 10, 2022
@Munkybooty
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
10d3657 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request May 12, 2022
@Munkybooty
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
6b2a408 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request May 12, 2022
@Munkybooty
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
bf18695 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request May 17, 2022
@Munkybooty
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
f6ddf04 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request May 23, 2022
@Munkybooty
Merge bitcoin#14794: tests: Add AddressSanitizer (ASan) Travis build
22ae9fd 
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
kwvg added a commit to kwvg/dash that referenced this pull request Jun 22, 2022
@kwvg
merge bitcoin#14794: Add AddressSanitizer (ASan) Travis build
0730f62
kwvg added a commit to kwvg/dash that referenced this pull request Jul 1, 2022
@kwvg
merge bitcoin#14794: Add AddressSanitizer (ASan) Travis build
e22b5b7
UdjinM6 added a commit to dashpay/dash that referenced this pull request Jul 2, 2022
@UdjinM6
Merge pull request #4741 from kittywhiskers/ci2
ef8cf4b 
backport: bitcoin#16597, bitcoin#17176, bitcoin#14794, bitcoin#17205, bitcoin#17240, bitcoin#17367, bitcoin#18862, bitcoin#21405 (ci reworking: part 2)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@maflcko maflcko maflcko left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@practicalswift @sipa @maflcko @fanquake