Skip to content

tests: Add --valgrind option to test/fuzz/test_runner.py for running fuzzing test cases under valgrind #18159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2020
Merged

tests: Add --valgrind option to test/fuzz/test_runner.py for running fuzzing test cases under valgrind #18159

merged 1 commit into from
Feb 16, 2020

Conversation

practicalswift
Copy link
Contributor

Add --valgrind option to test/fuzz/test_runner.py for running fuzzing test cases under valgrind.

Test this PR using:

$ make distclean
$ ./autogen.sh
$ CC=clang CXX=clang++ ./configure --enable-fuzz --with-sanitizers=fuzzer
$ make
$ git clone https://github.com/bitcoin-core/qa-assets
$ test/fuzz/test_runner.py --valgrind -l DEBUG qa-assets/fuzz_seed_corpus/

@fanquake fanquake added the Tests label Feb 16, 2020
@maflcko
Copy link
Member

maflcko commented Feb 16, 2020

ACK 1b068c5 🌒

Show signature and timestamp

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK 1b068c50dd1522990cc33e1aca444741c7e5a747 🌒
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUgwZQv/bc2caVBOx/avzGhRDQsY199zXEEdjHnhcTNhy+ogQgM53H6qZnUMV4Ol
WLH8QWQmE1qqO1uO3By+U7LA345sxmWEoYnIV3Ljb6edg3X/dH1YhaUuimxpGpiV
hCvWybBOWbqmTbKgiFiI36SaUs6wTJxN4Lh05CblvApm4qXddZ9RqNUwVbjXxF+G
n9tq0ruCEIpCkjYHKgcpAzW+EG4m87HGcgEMEPOwwoVe5V/PpLIvtHCTJPPRT5Ex
JNMT1RBh4IvuzMUJriIIJfQSnOOEUj6PCuDZkiP9TFrFQZq/CEDtiaqUXpsAMI4m
AjXcfkx8gklQahKgZMdF3xMcyJkSxzBDMnyBngMuAt9kHJizey6cTU6rdX/QE2eK
PIXxIlwmeC297WyUkBDI4xhx77YAina2DVYPhn1lFSttx8jeTzQz2OicDP/OMCin
+yYkIYwrdZfzTOKy4hr9tGwVO2JnH/Ht4p/fQeXySOxGvoRcvsyjIi1/KVjEH91R
noxw90D8
=FBbk
-----END PGP SIGNATURE-----

Timestamp of file with hash ddcb8cf04268c7e800aa92e0e54bb0702e059d70226eb2d7ec32ccfb05899b21 -

maflcko pushed a commit that referenced this pull request Feb 16, 2020
Merge #18159: tests: Add --valgrind option to test/fuzz/test_runner.p…
94c0287 
…y for running fuzzing test cases under valgrind

1b068c5 tests: Add --valgrind option to test/fuzz/test_runner.py for running fuzzing test cases under valgrind (practicalswift)

Pull request description:

  Add `--valgrind` option to `test/fuzz/test_runner.py` for running fuzzing test cases under `valgrind`.

  Test this PR using:

  ```
  $ make distclean
  $ ./autogen.sh
  $ CC=clang CXX=clang++ ./configure --enable-fuzz --with-sanitizers=fuzzer
  $ make
  $ git clone https://github.com/bitcoin-core/qa-assets
  $ test/fuzz/test_runner.py --valgrind -l DEBUG qa-assets/fuzz_seed_corpus/
  ```

ACKs for top commit:
  MarcoFalke:
    ACK 1b068c5 🌒

Tree-SHA512: e6eb99af1bceaa6f36f49092a05de415848099ccc1497cc098a62e925954c978cb37a46410b44ed5eef2c6464ca4ecb06397b75b5d35701f5a8525436e47b9fd
@maflcko maflcko merged commit 1b068c5 into bitcoin:master Feb 16, 2020
@jonatack
Copy link
Member

Code review ACK 1b068c5

@practicalswift practicalswift mentioned this pull request Mar 7, 2020
Merged
@MarkLTZ MarkLTZ mentioned this pull request Apr 4, 2020
Closed
maflcko pushed a commit that referenced this pull request Jul 2, 2020
Merge #18288: build: Add MemorySanitizer (MSan) in Travis to detect u…
7027c67 
…se of uninitialized memory

870f0cd build: Add MemorySanitizer (MSan) in Travis to detect use of uninitialized memory (practicalswift)

Pull request description:

  Add MemorySanitizer (MSan) in Travis to detect use of uninitialized memory.

  First UBSan, then ASan followed by TSan... and now: yes, the wait is over -- **MSan is finally here!** :)

  Some historical context:
  * 2017: Continuous compilation with Clang Thread Safety analysis enabled (#10866, #10923)
  * 2018: Continuous testing with trapping on signed integer overflows (`-ftrapv`) (#12686)
  * 2018: Continuous testing of use of locale dependent functions (#13041)
  * 2018: Continuous testing of format strings (#13705)
  * 2018: Continuous compilation with MSVC `TreatWarningAsError` (#14151)
  * 2018: Continuous testing under UndefinedBehaviorSanitizer – UBSan (#14252, #14673, #17006)
  * 2018: Continuous testing under AddressSanitizer – ASan (#14794, #17205, #17674)
  * 2018: Continuous testing under ThreadSanitizer – TSan (#14829)
  * 2019: Continuous testing in an unsigned char environment (`-funsigned-char`) (#15134)
  * 2019: Continuous compile-time testing of assumptions we're making (#15391)
  * 2019: Continuous testing of fuzz test cases under Valgrind (#17633, #18159, #18166)
  * 2020: Finally... MemorySanitizer – MSAN! :)

  What is the next step? What tools should we add to CI to keep bugs from entering `master`? :)

ACKs for top commit:
  MarcoFalke:
    ACK 870f0cd

Tree-SHA512: 38327c8b75679d97d469fe42e704cacd1217447a5a603701dd8a58ee50b3be2c10248f8d68a479ed081c0c4b254589d3081c9183f991640b06ef689061f75578
@practicalswift practicalswift mentioned this pull request Oct 1, 2020
Merged
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Nov 2, 2020
@practicalswift @Fabcien
tests: Add --valgrind option to test/fuzz/test_runner.py for running …
70df496 
…fuzzing test cases under valgrind

Summary:
```
Add --valgrind option to test/fuzz/test_runner.py for running fuzzing
test cases under valgrind.
```

Backport of core [[ bitcoin/bitcoin#18159 | PR18159 ]].

Test Plan:
  ninja bitcoin-fuzzers
  ./test/fuzz/test_runner.py --vagrind <path_to_corpus>

Reviewers: #bitcoin_abc, PiRK

Reviewed By: PiRK

Differential Revision: https://reviews.bitcoinabc.org/D8221
@practicalswift practicalswift deleted the fuzzers-valgrind branch April 10, 2021 19:39
kwvg added a commit to kwvg/dash that referenced this pull request Aug 15, 2021
@kwvg
bitcoin#18159: Add --valgrind option to test/fuzz/test_runner.py for …
6943768 
…running fuzzing test cases under valgrind
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 17, 2021
@PastaPastaPasta
Merge bitcoin#18159: tests: Add --valgrind option to test/fuzz/test_r…
ef675d9 
…unner.py for running fuzzing test cases under valgrind

1b068c5 tests: Add --valgrind option to test/fuzz/test_runner.py for running fuzzing test cases under valgrind (practicalswift)

Pull request description:

  Add `--valgrind` option to `test/fuzz/test_runner.py` for running fuzzing test cases under `valgrind`.

  Test this PR using:

  ```
  $ make distclean
  $ ./autogen.sh
  $ CC=clang CXX=clang++ ./configure --enable-fuzz --with-sanitizers=fuzzer
  $ make
  $ git clone https://github.com/bitcoin-core/qa-assets
  $ test/fuzz/test_runner.py --valgrind -l DEBUG qa-assets/fuzz_seed_corpus/
  ```

ACKs for top commit:
  MarcoFalke:
    ACK 1b068c5 🌒

Tree-SHA512: e6eb99af1bceaa6f36f49092a05de415848099ccc1497cc098a62e925954c978cb37a46410b44ed5eef2c6464ca4ecb06397b75b5d35701f5a8525436e47b9fd
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 18, 2021
@PastaPastaPasta
Merge bitcoin#18159: tests: Add --valgrind option to test/fuzz/test_r…
fae0e0b 
…unner.py for running fuzzing test cases under valgrind

1b068c5 tests: Add --valgrind option to test/fuzz/test_runner.py for running fuzzing test cases under valgrind (practicalswift)

Pull request description:

  Add `--valgrind` option to `test/fuzz/test_runner.py` for running fuzzing test cases under `valgrind`.

  Test this PR using:

  ```
  $ make distclean
  $ ./autogen.sh
  $ CC=clang CXX=clang++ ./configure --enable-fuzz --with-sanitizers=fuzzer
  $ make
  $ git clone https://github.com/bitcoin-core/qa-assets
  $ test/fuzz/test_runner.py --valgrind -l DEBUG qa-assets/fuzz_seed_corpus/
  ```

ACKs for top commit:
  MarcoFalke:
    ACK 1b068c5 🌒

Tree-SHA512: e6eb99af1bceaa6f36f49092a05de415848099ccc1497cc098a62e925954c978cb37a46410b44ed5eef2c6464ca4ecb06397b75b5d35701f5a8525436e47b9fd
thelazier pushed a commit to thelazier/dash that referenced this pull request Sep 25, 2021
@thelazier
Merge bitcoin#18159: tests: Add --valgrind option to test/fuzz/test_r…
682007b 
…unner.py for running fuzzing test cases under valgrind

1b068c5 tests: Add --valgrind option to test/fuzz/test_runner.py for running fuzzing test cases under valgrind (practicalswift)

Pull request description:

  Add `--valgrind` option to `test/fuzz/test_runner.py` for running fuzzing test cases under `valgrind`.

  Test this PR using:

  ```
  $ make distclean
  $ ./autogen.sh
  $ CC=clang CXX=clang++ ./configure --enable-fuzz --with-sanitizers=fuzzer
  $ make
  $ git clone https://github.com/bitcoin-core/qa-assets
  $ test/fuzz/test_runner.py --valgrind -l DEBUG qa-assets/fuzz_seed_corpus/
  ```

ACKs for top commit:
  MarcoFalke:
    ACK 1b068c5 🌒

Tree-SHA512: e6eb99af1bceaa6f36f49092a05de415848099ccc1497cc098a62e925954c978cb37a46410b44ed5eef2c6464ca4ecb06397b75b5d35701f5a8525436e47b9fd
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Oct 4, 2021
@vijaydasmp
Merge bitcoin#18288: build: Add MemorySanitizer (MSan) in Travis to d…
dfa262c 
…etect use of uninitialized memory

870f0cd build: Add MemorySanitizer (MSan) in Travis to detect use of uninitialized memory (practicalswift)

Pull request description:

  Add MemorySanitizer (MSan) in Travis to detect use of uninitialized memory.

  First UBSan, then ASan followed by TSan... and now: yes, the wait is over -- **MSan is finally here!** :)

  Some historical context:
  * 2017: Continuous compilation with Clang Thread Safety analysis enabled (bitcoin#10866, bitcoin#10923)
  * 2018: Continuous testing with trapping on signed integer overflows (`-ftrapv`) (bitcoin#12686)
  * 2018: Continuous testing of use of locale dependent functions (bitcoin#13041)
  * 2018: Continuous testing of format strings (bitcoin#13705)
  * 2018: Continuous compilation with MSVC `TreatWarningAsError` (bitcoin#14151)
  * 2018: Continuous testing under UndefinedBehaviorSanitizer – UBSan (bitcoin#14252, bitcoin#14673, bitcoin#17006)
  * 2018: Continuous testing under AddressSanitizer – ASan (bitcoin#14794, bitcoin#17205, bitcoin#17674)
  * 2018: Continuous testing under ThreadSanitizer – TSan (bitcoin#14829)
  * 2019: Continuous testing in an unsigned char environment (`-funsigned-char`) (bitcoin#15134)
  * 2019: Continuous compile-time testing of assumptions we're making (bitcoin#15391)
  * 2019: Continuous testing of fuzz test cases under Valgrind (bitcoin#17633, bitcoin#18159, bitcoin#18166)
  * 2020: Finally... MemorySanitizer – MSAN! :)

  What is the next step? What tools should we add to CI to keep bugs from entering `master`? :)

ACKs for top commit:
  MarcoFalke:
    ACK 870f0cd

Tree-SHA512: 38327c8b75679d97d469fe42e704cacd1217447a5a603701dd8a58ee50b3be2c10248f8d68a479ed081c0c4b254589d3081c9183f991640b06ef689061f75578
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@practicalswift @maflcko @jonatack @fanquake