Travis: run full test suite on native macOS #16597

Sjors · 2019-08-13T17:36:25Z

Adds an additional Travis machine to run the functional test suite on native macOS

Homebrew is not particularly Travis compatible, but I found some useful hints here: https://discourse.brew.sh/t/best-practice-for-homebrew-on-travis-brew-update-is-5min-to-build-time/5215/11

DrahtBot · 2019-08-13T22:11:36Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#12134 (Build previous releases and run functional tests by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

cvengler · 2019-08-13T23:17:27Z

Are there travis tests which can proof it? Like your fork?
But I generally like this idea as the current situation with tuxes on the side is a bit confusing

.travis.yml

fanquake · 2019-08-14T03:46:27Z

Concept ACK. Will take a look at the base PR first.

Sjors · 2019-08-14T08:21:24Z

Travis is ignoring this PR and my branch atm.

cvengler · 2019-08-14T17:58:09Z

Can you enable travis for your forked repository?

Sjors · 2019-08-15T10:45:43Z

@emilengler I tried that, but it wasn't building there either. I'll wait until the previous PR is merged and then try again.

cvengler · 2019-08-15T14:43:39Z

@Sjors Ok I will fork your repository, then remove it from the parent and try to enable travis then

cvengler · 2019-08-15T15:34:24Z

@Sjors Doesn't work, take a look https://travis-ci.org/emilengler/bitcoin-sjors-test/requests.
I also forked your repo here as a playgroud, I also invited you for commit access, will delete it once it is done.

fanquake · 2019-10-13T13:40:11Z

ci/test/00_setup_env_mac_functional.sh

+export LC_ALL=C.UTF-8
+
+export HOST=x86_64-apple-darwin14
+export BREW_PACKAGES="automake berkeley-db4 libtool boost miniupnpc openssl pkg-config protobuf qt qrencode librsvg pyenv ccache"


No reason to install protobuf if we're not enabling BIP70.

Dropped (in other branch, will push later)

If we're building/testing only once natively, we should enable everything...

I added it back and enabled BIP70 in the build.

ci/test/00_setup_env_mac_functional.sh

Sjors · 2019-10-14T06:55:17Z

Travis macOS passed! I added pip install zmq for the functional ZMQ tests...

pyenv was causing more headaches than it solved. There doesn't appear to be any `language: python python: '3.x'. packages available, so I'm installing via homebrew instead.

maflcko

ACK 26068f3 (looked at the diff on GitHub)

ci/test/04_install.sh

ci/lint/04_install.sh

Sjors · 2019-10-14T18:58:48Z

ci/test/04_install.sh

+  cd /usr/local/Homebrew || exit 1
+  git reset --hard origin/master
+  ${CI_RETRY_EXE} brew update


@MarcoFalke brew update blew up on a previous run (can't find it anymore) and recommended these two lines to "fix" it.

It might be worth rebasing the PR for a while to see if any other surprises show up.

Sjors · 2019-10-14T19:17:19Z

ci/test/06_script_b.sh

+# Temporarily disable errexit, because Travis macOS fails without error message
+set +o errexit


This is where your sanity gives in...

Review hint: git show -w Co-authored-by: MarcoFalke <falke.marco@gmail.com> Co-authored-by: keneanung <keneanung@googlemail.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>

maflcko · 2019-10-15T15:59:37Z

re-ACK 1f6c650

maflcko · 2019-10-15T16:00:08Z

ci/test/04_install.sh

+  set +o errexit
+  pushd /usr/local/Homebrew || exit 1
+  git reset --hard origin/master
+  popd || exit 1
+  set -o errexit


What happens if you remove this?

Nothing initially because the brew cache is in a good state. But at some random other moment homebrew will be in a bad state and you'll need this.

maflcko · 2019-10-16T13:05:07Z

.travis.yml

+  # Cache only .git files under "/usr/local/Homebrew" so "brew update" does not take 5min every build
+  # - if [ "${TRAVIS_OS_NAME}" = "osx" ]; then find /usr/local/Homebrew \! -regex ".+\.git.+" -delete; fi


Is this still needed?

The whole process takes 2 min without it: https://travis-ci.org/bitcoin/bitcoin/jobs/597848502#L100

I don't know if it builds up any cruft over time, but if time doesn't creep up, then we can drop this.

Well it is commented out already, so I removed it in #17176

1f6c650 travis: run tests on macOS native (Sjors Provoost) Pull request description: Adds an additional Travis machine to run the functional test suite on native macOS Homebrew is not particularly Travis compatible, but I found some useful hints here: https://discourse.brew.sh/t/best-practice-for-homebrew-on-travis-brew-update-is-5min-to-build-time/5215/11 ACKs for top commit: MarcoFalke: re-ACK 1f6c650 Tree-SHA512: 3f19a1695fac53d4d6c2033a9c20be69294e3a798c84fd9bf6ae2aa7a6d92aa1dad1f62f4ee1ada9413fe7d05ee974050fa030fd2c547f33e0d5c0a3e74f64db

ryanofsky

Post merge code review ACK 1f6c650

Since this adds homebrew, I wonder if it fixes the scripted diff lint error I ran into #13728 (comment)

ryanofsky · 2019-10-17T14:51:06Z

ci/test/06_script_a.sh

+# Temporarily disable errexit, because Travis macOS fails without error message
+set +o errexit
 cd build || (echo "could not enter build directory"; exit 1)
+set -o errexit


The cd command succeeds and returns an error code? I guess this is calling some travis-wrapped cd alias rather than the actual cd command? Could debug with type cd. If a workaround is necessary, it would seem nicer to wrap the workaround in a safe_cd function than repeat this errexit stuff different places.

Filed as good first issue. See #17178

ryanofsky · 2019-10-17T15:01:55Z

ci/test/05_before_script.sh


-mkdir -p depends/SDKs depends/sdk-sources
+if [ "$TRAVIS_OS_NAME" != "osx" ]; then


Maybe should add a comment explaining this check. I'm confused about why all of this is skipped on osx. Does the depends build not work there? It would seem cleaner to use NO_DEPENDS variable to skip depends steps than to tie the decision to the travis operating system name.

Thanks for the review @ryanofsky . This check looks indeed redundant. Removed in #17176

1f6c650 travis: run tests on macOS native (Sjors Provoost) Pull request description: Adds an additional Travis machine to run the functional test suite on native macOS Homebrew is not particularly Travis compatible, but I found some useful hints here: https://discourse.brew.sh/t/best-practice-for-homebrew-on-travis-brew-update-is-5min-to-build-time/5215/11 ACKs for top commit: MarcoFalke: re-ACK 1f6c650 Tree-SHA512: 3f19a1695fac53d4d6c2033a9c20be69294e3a798c84fd9bf6ae2aa7a6d92aa1dad1f62f4ee1ada9413fe7d05ee974050fa030fd2c547f33e0d5c0a3e74f64db

Sjors force-pushed the 2019/08/travis-macos branch 4 times, most recently from c155de1 to f6014d8 Compare August 13, 2019 18:05

fanquake added the Tests label Aug 13, 2019

Sjors changed the title ~~Travis: run full test suite on native macOS~~ [WIP] Travis: run full test suite on native macOS Aug 13, 2019

Sjors marked this pull request as ready for review August 13, 2019 18:36

Sjors force-pushed the 2019/08/travis-macos branch 7 times, most recently from c9c9198 to 4f602ce Compare August 13, 2019 19:31

fanquake reviewed Aug 14, 2019

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

Sjors force-pushed the 2019/08/travis-macos branch 3 times, most recently from 1e64a41 to 468621a Compare August 14, 2019 08:18

DrahtBot added the Needs rebase label Aug 15, 2019

Sjors force-pushed the 2019/08/travis-macos branch from 468621a to c74fbe3 Compare September 16, 2019 15:04

DrahtBot added Needs rebase and removed Needs rebase labels Sep 16, 2019

Sjors force-pushed the 2019/08/travis-macos branch 2 times, most recently from cf63f09 to c2e4c57 Compare October 13, 2019 13:27

fanquake reviewed Oct 13, 2019

View reviewed changes

Sjors force-pushed the 2019/08/travis-macos branch from c2e4c57 to e1e6d22 Compare October 13, 2019 20:17

Sjors changed the title ~~[WIP] Travis: run full test suite on native macOS~~ Travis: run full test suite on native macOS Oct 13, 2019

Sjors force-pushed the 2019/08/travis-macos branch 2 times, most recently from cb6b7a4 to 185c201 Compare October 14, 2019 06:48

Sjors force-pushed the 2019/08/travis-macos branch from 185c201 to 26068f3 Compare October 14, 2019 09:15

maflcko reviewed Oct 14, 2019

View reviewed changes

ci/test/04_install.sh Outdated Show resolved Hide resolved

ci/test/04_install.sh Outdated Show resolved Hide resolved

Sjors force-pushed the 2019/08/travis-macos branch 2 times, most recently from e7e3301 to 092d388 Compare October 14, 2019 16:46

maflcko reviewed Oct 14, 2019

View reviewed changes

ci/lint/04_install.sh Outdated Show resolved Hide resolved

Sjors force-pushed the 2019/08/travis-macos branch from 092d388 to 3cd5e59 Compare October 14, 2019 18:48

Sjors commented Oct 14, 2019

View reviewed changes

Sjors force-pushed the 2019/08/travis-macos branch from 3cd5e59 to 21c1601 Compare October 14, 2019 19:15

Sjors commented Oct 14, 2019

View reviewed changes

Sjors force-pushed the 2019/08/travis-macos branch from 21c1601 to f2d3839 Compare October 14, 2019 19:33

travis: run tests on macOS native

1f6c650

Review hint: git show -w Co-authored-by: MarcoFalke <falke.marco@gmail.com> Co-authored-by: keneanung <keneanung@googlemail.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>

Sjors force-pushed the 2019/08/travis-macos branch from f2d3839 to 1f6c650 Compare October 14, 2019 21:12

maflcko reviewed Oct 15, 2019

View reviewed changes

maflcko reviewed Oct 16, 2019

View reviewed changes

maflcko merged commit 1f6c650 into bitcoin:master Oct 17, 2019

ryanofsky reviewed Oct 17, 2019

View reviewed changes

maflcko mentioned this pull request Oct 17, 2019

ci: Cleanup macOS runs #17176

Merged

MarkLTZ mentioned this pull request Apr 4, 2020

Bitcoin PR tracking litecoinz-core/litecoinz#14

Closed

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021

		# Temporarily disable errexit, because Travis macOS fails without error message
		set +o errexit

		# Cache only .git files under "/usr/local/Homebrew" so "brew update" does not take 5min every build
		# - if [ "${TRAVIS_OS_NAME}" = "osx" ]; then find /usr/local/Homebrew \! -regex ".+\.git.+" -delete; fi


		mkdir -p depends/SDKs depends/sdk-sources
		if [ "$TRAVIS_OS_NAME" != "osx" ]; then

Travis: run full test suite on native macOS #16597

Travis: run full test suite on native macOS #16597

Uh oh!

Conversation

Sjors commented Aug 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Aug 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

cvengler commented Aug 13, 2019

Uh oh!

Uh oh!

fanquake commented Aug 14, 2019

Uh oh!

Sjors commented Aug 14, 2019

Uh oh!

cvengler commented Aug 14, 2019

Uh oh!

Sjors commented Aug 15, 2019

Uh oh!

cvengler commented Aug 15, 2019

Uh oh!

cvengler commented Aug 15, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Sjors commented Oct 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maflcko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maflcko commented Oct 15, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ryanofsky left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Sjors commented Aug 13, 2019 •

edited

Loading

DrahtBot commented Aug 13, 2019 •

edited

Loading

Sjors commented Oct 14, 2019 •

edited

Loading