Move util files to directory #14555

jimpo · 2018-10-23T17:13:09Z

As discussed here, this establishes a util/ directory to introduce more organizational structure and have a clear place for new util files. It's really not scary to review, it's just one big scripted diff.

maflcko · 2018-10-23T18:11:36Z

The scripted diff will also run on non-git files that happen to be in the folder. Imo, this should be avoided by using a git ls-files with a filter or something.

DrahtBot · 2018-10-23T21:58:37Z

Reviewers, this pull request conflicts with the following ones:

refactor: remove usage of locale dependent std::isspace #14585 (refactor: remove usage of locale dependent std::isspace by practicalswift)
Use RPCHelpMan to generate RPC doc strings #14530 (Use RPCHelpMan to generate RPC doc strings by MarcoFalke)
qt, docs: Fix bitcoin-qt -version output formatting #14521 (qt, docs: Fix bitcoin-qt -version output formatting by hebasto)
Fire TransactionRemovedFromMempool callbacks from mempool #14384 (Resolve validationinterface circular dependencies by 251Labs)
Document intentional and unintentional unsigned integer overflows (wraparounds) using annotations #14224 (Document intentional and unintentional unsigned integer overflows (wraparounds) using annotations by practicalswift)
Add HKDF_HMAC256_L32 and method to negate a private key #14047 (Add HKDF_HMAC256_L32 and method to negate a private key by jonasschnelli)
refactor: Fix the chainparamsbase -> util circular dependency #14045 (refactor: Fix the chainparamsbase -> util circular dependency by Empact)
Utxoscriptindex #14035 (Utxoscriptindex by mgrychow)
util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool #13815 (util: Add [[nodiscard]] to all {Decode,Parse}... functions returning bool by practicalswift)
Utils and libraries: Drops the boost/algorithm/string/split.hpp dependency #13751 (Utils and libraries: Drops the boost/algorithm/string/split.hpp dependency by 251Labs)
-masterdatadir for datadir bootstrapping #13746 (-masterdatadir for datadir bootstrapping by kallewoof)
RPC: Add ancestor{count,size,fees} to listunspent output #12677 (RPC: Add ancestor{count,size,fees} to listunspent output by luke-jr)
Raise the open fd limit to the maximum allowed #11785 (Raise the open fd limit to the maximum allowed by vii)
Add fee_est tool for debugging fee estimation code #10443 (Add fee_est tool for debugging fee estimation code by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

promag · 2018-10-24T08:54:33Z

IMO scripted diff commit could have the mv commands to avoid having a bad commit.

ken2812221 · 2018-10-25T04:00:47Z

Could you please apply this as the second commit? Thanks

diff --git a/build_msvc/libbitcoinconsensus/libbitcoinconsensus.vcxproj b/build_msvc/libbitcoinconsensus/libbitcoinconsensus.vcxproj
index 0be7e7e43..2c6c0a8b7 100644
--- a/build_msvc/libbitcoinconsensus/libbitcoinconsensus.vcxproj
+++ b/build_msvc/libbitcoinconsensus/libbitcoinconsensus.vcxproj
@@ -40,7 +40,7 @@
     <ClCompile Include="..\..\src\script\script.cpp" />
     <ClCompile Include="..\..\src\script\script_error.cpp" />
     <ClCompile Include="..\..\src\uint256.cpp" />
-    <ClCompile Include="..\..\src\utilstrencodings.cpp" />
+    <ClCompile Include="..\..\src\util\strencodings.cpp" />
   </ItemGroup>
   <ItemGroup>
     <None Include="packages.config" />

ken2812221 · 2018-10-26T09:19:29Z

utACK d0f883e9c5c7dd1ac9efcd69eb0065e47376afef

promag · 2018-10-26T09:25:34Z

utACK d0f883e, sorry conflicts..

maflcko · 2018-10-26T11:40:40Z

utACK d0f883e9c5c7dd1ac9efcd69eb0065e47376afef

scravy · 2018-10-26T11:43:50Z

utACK d0f883e

meshcollider · 2018-11-03T05:15:31Z

utACK d0f883e
After rebase this is probably mergeable

promag · 2018-11-04T18:17:00Z

After rebase:

diff --git a/src/base58.cpp b/src/base58.cpp
index eac763394..e3d285339 100644
--- a/src/base58.cpp
+++ b/src/base58.cpp
@@ -6,7 +6,7 @@
 
 #include <hash.h>
 #include <uint256.h>
-#include <utilstrencodings.h>
+#include <util/strencodings.h>
 
 #include <assert.h>
 #include <string.h>

-BEGIN VERIFY SCRIPT- mkdir -p src/util git mv src/util.h src/util/system.h git mv src/util.cpp src/util/system.cpp git mv src/utilmemory.h src/util/memory.h git mv src/utilmoneystr.h src/util/moneystr.h git mv src/utilmoneystr.cpp src/util/moneystr.cpp git mv src/utilstrencodings.h src/util/strencodings.h git mv src/utilstrencodings.cpp src/util/strencodings.cpp git mv src/utiltime.h src/util/time.h git mv src/utiltime.cpp src/util/time.cpp sed -i 's/<util\.h>/<util\/system\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmemory\.h>/<util\/memory\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmoneystr\.h>/<util\/moneystr\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilstrencodings\.h>/<util\/strencodings\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utiltime\.h>/<util\/time\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/BITCOIN_UTIL_H/BITCOIN_UTIL_SYSTEM_H/g' src/util/system.h sed -i 's/BITCOIN_UTILMEMORY_H/BITCOIN_UTIL_MEMORY_H/g' src/util/memory.h sed -i 's/BITCOIN_UTILMONEYSTR_H/BITCOIN_UTIL_MONEYSTR_H/g' src/util/moneystr.h sed -i 's/BITCOIN_UTILSTRENCODINGS_H/BITCOIN_UTIL_STRENCODINGS_H/g' src/util/strencodings.h sed -i 's/BITCOIN_UTILTIME_H/BITCOIN_UTIL_TIME_H/g' src/util/time.h sed -i 's/ util\.$h\|cpp$/ util\/system\.\1/g' src/Makefile.am sed -i 's/utilmemory\.$h\|cpp$/util\/memory\.\1/g' src/Makefile.am sed -i 's/utilmoneystr\.$h\|cpp$/util\/moneystr\.\1/g' src/Makefile.am sed -i 's/utilstrencodings\.$h\|cpp$/util\/strencodings\.\1/g' src/Makefile.am sed -i 's/utiltime\.$h\|cpp$/util\/time\.\1/g' src/Makefile.am sed -i 's/-> util ->/-> util\/system ->/' test/lint/lint-circular-dependencies.sh sed -i 's/src\/util\.cpp/src\/util\/system\.cpp/g' test/lint/lint-format-strings.py test/lint/lint-locale-dependence.sh sed -i 's/src\/utilmoneystr\.cpp/src\/util\/moneystr\.cpp/g' test/lint/lint-locale-dependence.sh sed -i 's/src\/utilstrencodings\.$h\|cpp$/src\/util\/strencodings\.\1/g' test/lint/lint-locale-dependence.sh sed -i 's/src\\utilstrencodings\.cpp/src\\util\\strencodings\.cpp/' build_msvc/libbitcoinconsensus/libbitcoinconsensus.vcxproj -END VERIFY SCRIPT-

ken2812221 · 2018-11-05T07:13:26Z

utACK 2068f08

fanquake · 2018-11-05T08:52:40Z

tACK 2068f08
make check and ran the functional tests.

Might be a good to merge this now, to save the constant rebasing. Doesn't look like this will break any ready to merge/PRs with ACKs etc.

promag · 2018-11-05T09:02:33Z

Agree with @fanquake, ACK 2068f08.

laanwj · 2018-11-05T10:34:19Z

utACK 2068f08

util/system.h is great naming, yes, the file is for os/system utilities
We need to come up with guidelines (in the developer notes) what to put in src/compat versus src/support versus src/util, all three are more or less utilities. But that can be done later.

2068f08 scripted-diff: Move util files to separate directory. (Jim Posen) Pull request description: As discussed [here](#14074 (comment)), this establishes a `util/` directory to introduce more organizational structure and have a clear place for new util files. It's really not scary to review, it's just one big scripted diff. Tree-SHA512: 39cf15480d7d35e987b6088d52a857a2d5b1802e36c6b815eb42718d80cd95e669757af9bcc7c04426cd8523662cb1050b8da1e2377d3730672820ed298b894b

(script modified to account for Dash backports) ------------- BEGIN SCRIPT --------------- mkdir -p src/util git mv src/util.h src/util/system.h git mv src/util.cpp src/util/system.cpp git mv src/utilmemory.h src/util/memory.h git mv src/utilmoneystr.h src/util/moneystr.h git mv src/utilmoneystr.cpp src/util/moneystr.cpp git mv src/utilstrencodings.h src/util/strencodings.h git mv src/utilstrencodings.cpp src/util/strencodings.cpp git mv src/utiltime.h src/util/time.h git mv src/utiltime.cpp src/util/time.cpp git mv src/utilasmap.h src/util/asmap.h git mv src/utilasmap.cpp src/util/asmap.cpp git mv src/utilstring.h src/util/string.h git mv src/utilstring.cpp src/util/string.cpp gsed -i 's/<util\.h>/<util\/system\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/<utilmemory\.h>/<util\/memory\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/<utilmoneystr\.h>/<util\/moneystr\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/<utilstrencodings\.h>/<util\/strencodings\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/<utiltime\.h>/<util\/time\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/<utilasmap\.h>/<util\/asmap\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/<utilstring\.h>/<util\/string\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/BITCOIN_UTIL_H/BITCOIN_UTIL_SYSTEM_H/g' src/util/system.h gsed -i 's/BITCOIN_UTILMEMORY_H/BITCOIN_UTIL_MEMORY_H/g' src/util/memory.h gsed -i 's/BITCOIN_UTILMONEYSTR_H/BITCOIN_UTIL_MONEYSTR_H/g' src/util/moneystr.h gsed -i 's/BITCOIN_UTILSTRENCODINGS_H/BITCOIN_UTIL_STRENCODINGS_H/g' src/util/strencodings.h gsed -i 's/BITCOIN_UTILTIME_H/BITCOIN_UTIL_TIME_H/g' src/util/time.h gsed -i 's/BITCOIN_UTILASMAP_H/BITCOIN_UTIL_ASMAP_H/g' src/util/time.h gsed -i 's/BITCOIN_UTILSTRING_H/BITCOIN_UTIL_STRING_H/g' src/util/time.h gsed -i 's/ util\.$h\|cpp$/ util\/system\.\1/g' src/Makefile.am gsed -i 's/utilmemory\.$h\|cpp$/util\/memory\.\1/g' src/Makefile.am gsed -i 's/utilmoneystr\.$h\|cpp$/util\/moneystr\.\1/g' src/Makefile.am gsed -i 's/utilstrencodings\.$h\|cpp$/util\/strencodings\.\1/g' src/Makefile.am gsed -i 's/utiltime\.$h\|cpp$/util\/time\.\1/g' src/Makefile.am gsed -i 's/utilasmap\.$h\|cpp$/util\/asmap\.\1/g' src/Makefile.am gsed -i 's/utilstring\.$h\|cpp$/util\/string\.\1/g' src/Makefile.am gsed -i 's/-> util ->/-> util\/system ->/' test/lint/lint-circular-dependencies.sh gsed -i 's/src\/util\.cpp/src\/util\/system\.cpp/g' test/lint/lint-format-strings.py test/lint/lint-locale-dependence.sh gsed -i 's/src\/utilmoneystr\.cpp/src\/util\/moneystr\.cpp/g' test/lint/lint-locale-dependence.sh gsed -i 's/src\/utilstrencodings\.$h\|cpp$/src\/util\/strencodings\.\1/g' test/lint/lint-locale-dependence.sh ------------- END SCRIPT ---------------

(script modified to account for Dash backports) ------------- BEGIN SCRIPT --------------- mkdir -p src/util git mv src/util.h src/util/system.h git mv src/util.cpp src/util/system.cpp git mv src/utilmemory.h src/util/memory.h git mv src/utilmoneystr.h src/util/moneystr.h git mv src/utilmoneystr.cpp src/util/moneystr.cpp git mv src/utilstrencodings.h src/util/strencodings.h git mv src/utilstrencodings.cpp src/util/strencodings.cpp git mv src/utiltime.h src/util/time.h git mv src/utiltime.cpp src/util/time.cpp git mv src/utilasmap.h src/util/asmap.h git mv src/utilasmap.cpp src/util/asmap.cpp git mv src/utilstring.h src/util/string.h git mv src/utilstring.cpp src/util/string.cpp gsed -i 's/<util\.h>/<util\/system\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/<utilmemory\.h>/<util\/memory\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/<utilmoneystr\.h>/<util\/moneystr\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/<utilstrencodings\.h>/<util\/strencodings\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/<utiltime\.h>/<util\/time\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/<utilasmap\.h>/<util\/asmap\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/<utilstring\.h>/<util\/string\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/BITCOIN_UTIL_H/BITCOIN_UTIL_SYSTEM_H/g' src/util/system.h gsed -i 's/BITCOIN_UTILMEMORY_H/BITCOIN_UTIL_MEMORY_H/g' src/util/memory.h gsed -i 's/BITCOIN_UTILMONEYSTR_H/BITCOIN_UTIL_MONEYSTR_H/g' src/util/moneystr.h gsed -i 's/BITCOIN_UTILSTRENCODINGS_H/BITCOIN_UTIL_STRENCODINGS_H/g' src/util/strencodings.h gsed -i 's/BITCOIN_UTILTIME_H/BITCOIN_UTIL_TIME_H/g' src/util/time.h gsed -i 's/BITCOIN_UTILASMAP_H/BITCOIN_UTIL_ASMAP_H/g' src/util/asmap.h gsed -i 's/BITCOIN_UTILSTRING_H/BITCOIN_UTIL_STRING_H/g' src/util/string.h gsed -i 's/ util\.$h\|cpp$/ util\/system\.\1/g' src/Makefile.am gsed -i 's/utilmemory\.$h\|cpp$/util\/memory\.\1/g' src/Makefile.am gsed -i 's/utilmoneystr\.$h\|cpp$/util\/moneystr\.\1/g' src/Makefile.am gsed -i 's/utilstrencodings\.$h\|cpp$/util\/strencodings\.\1/g' src/Makefile.am gsed -i 's/utiltime\.$h\|cpp$/util\/time\.\1/g' src/Makefile.am gsed -i 's/utilasmap\.$h\|cpp$/util\/asmap\.\1/g' src/Makefile.am gsed -i 's/utilstring\.$h\|cpp$/util\/string\.\1/g' src/Makefile.am gsed -i 's/-> util ->/-> util\/system ->/' test/lint/lint-circular-dependencies.sh gsed -i 's/src\/util\.cpp/src\/util\/system\.cpp/g' test/lint/lint-format-strings.py test/lint/lint-locale-dependence.sh gsed -i 's/src\/utilmoneystr\.cpp/src\/util\/moneystr\.cpp/g' test/lint/lint-locale-dependence.sh gsed -i 's/src\/utilstrencodings\.$h\|cpp$/src\/util\/strencodings\.\1/g' test/lint/lint-locale-dependence.sh ------------- END SCRIPT ---------------

(script modified to account for Dash backports, doesn't account for rebasing) ------------- BEGIN SCRIPT --------------- mkdir -p src/util git mv src/util.h src/util/system.h git mv src/util.cpp src/util/system.cpp git mv src/utilmemory.h src/util/memory.h git mv src/utilmoneystr.h src/util/moneystr.h git mv src/utilmoneystr.cpp src/util/moneystr.cpp git mv src/utilstrencodings.h src/util/strencodings.h git mv src/utilstrencodings.cpp src/util/strencodings.cpp git mv src/utiltime.h src/util/time.h git mv src/utiltime.cpp src/util/time.cpp git mv src/utilasmap.h src/util/asmap.h git mv src/utilasmap.cpp src/util/asmap.cpp git mv src/utilstring.h src/util/string.h git mv src/utilstring.cpp src/util/string.cpp gsed -i 's/<util\.h>/<util\/system\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/<utilmemory\.h>/<util\/memory\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/<utilmoneystr\.h>/<util\/moneystr\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/<utilstrencodings\.h>/<util\/strencodings\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/<utiltime\.h>/<util\/time\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/<utilasmap\.h>/<util\/asmap\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/<utilstring\.h>/<util\/string\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') gsed -i 's/BITCOIN_UTIL_H/BITCOIN_UTIL_SYSTEM_H/g' src/util/system.h gsed -i 's/BITCOIN_UTILMEMORY_H/BITCOIN_UTIL_MEMORY_H/g' src/util/memory.h gsed -i 's/BITCOIN_UTILMONEYSTR_H/BITCOIN_UTIL_MONEYSTR_H/g' src/util/moneystr.h gsed -i 's/BITCOIN_UTILSTRENCODINGS_H/BITCOIN_UTIL_STRENCODINGS_H/g' src/util/strencodings.h gsed -i 's/BITCOIN_UTILTIME_H/BITCOIN_UTIL_TIME_H/g' src/util/time.h gsed -i 's/BITCOIN_UTILASMAP_H/BITCOIN_UTIL_ASMAP_H/g' src/util/asmap.h gsed -i 's/BITCOIN_UTILSTRING_H/BITCOIN_UTIL_STRING_H/g' src/util/string.h gsed -i 's/ util\.$h\|cpp$/ util\/system\.\1/g' src/Makefile.am gsed -i 's/utilmemory\.$h\|cpp$/util\/memory\.\1/g' src/Makefile.am gsed -i 's/utilmoneystr\.$h\|cpp$/util\/moneystr\.\1/g' src/Makefile.am gsed -i 's/utilstrencodings\.$h\|cpp$/util\/strencodings\.\1/g' src/Makefile.am gsed -i 's/utiltime\.$h\|cpp$/util\/time\.\1/g' src/Makefile.am gsed -i 's/utilasmap\.$h\|cpp$/util\/asmap\.\1/g' src/Makefile.am gsed -i 's/utilstring\.$h\|cpp$/util\/string\.\1/g' src/Makefile.am gsed -i 's/-> util ->/-> util\/system ->/' test/lint/lint-circular-dependencies.sh gsed -i 's/src\/util\.cpp/src\/util\/system\.cpp/g' test/lint/lint-format-strings.py test/lint/lint-locale-dependence.sh gsed -i 's/src\/utilmoneystr\.cpp/src\/util\/moneystr\.cpp/g' test/lint/lint-locale-dependence.sh gsed -i 's/src\/utilstrencodings\.$h\|cpp$/src\/util\/strencodings\.\1/g' test/lint/lint-locale-dependence.sh ------------- END SCRIPT ---------------

partial bitcoin#15638, bitcoin#21966, bitcoin#16889, merge bitcoin#14555, bitcoin#20499, bitcoin#14074, bitcoin#17073: util refactoring

This was referenced Oct 23, 2018

Use RPCHelpMan to generate RPC doc strings #14530

Merged

qt, docs: Fix bitcoin-qt -version output formatting #14521

Merged

fanquake added the Utils/log/libs label Oct 23, 2018

jimpo force-pushed the util-cleanup branch 4 times, most recently from 5fba16e to ad2d7c8 Compare October 25, 2018 02:21

jimpo force-pushed the util-cleanup branch from ad2d7c8 to d0f883e Compare October 26, 2018 05:53

DrahtBot mentioned this pull request Oct 26, 2018

refactor: remove usage of locale dependent std::isspace #14585

Merged

DrahtBot added the Needs rebase label Oct 28, 2018

jimpo force-pushed the util-cleanup branch from d0f883e to feb73f1 Compare November 4, 2018 02:48

DrahtBot removed the Needs rebase label Nov 4, 2018

jimpo force-pushed the util-cleanup branch from feb73f1 to 2068f08 Compare November 5, 2018 06:46

laanwj merged commit 2068f08 into bitcoin:master Nov 5, 2018

laanwj mentioned this pull request Nov 6, 2018

Return of the Banman #14605

Merged

ryanofsky mentioned this pull request Nov 6, 2018

Refactor: separate wallet from node #10973

Merged

kwvg mentioned this pull request Jun 15, 2021

partial bitcoin#15638, #21966, #16889, merge #14555, #20499, #14074, #17073: util refactoring dashpay/dash#4197

Merged

UdjinM6 added a commit to dashpay/dash that referenced this pull request Jun 27, 2021

Merge pull request #4197 from kittywhiskers/utilRefactor

7d664c7

partial bitcoin#15638, bitcoin#21966, bitcoin#16889, merge bitcoin#14555, bitcoin#20499, bitcoin#14074, bitcoin#17073: util refactoring

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move util files to directory #14555

Move util files to directory #14555

Uh oh!

jimpo commented Oct 23, 2018 •

edited

Loading

Uh oh!

maflcko commented Oct 23, 2018

Uh oh!

DrahtBot commented Oct 23, 2018 •

edited

Loading

Uh oh!

promag commented Oct 24, 2018

Uh oh!

ken2812221 commented Oct 25, 2018

Uh oh!

ken2812221 commented Oct 26, 2018

Uh oh!

promag commented Oct 26, 2018

Uh oh!

maflcko commented Oct 26, 2018

Uh oh!

scravy commented Oct 26, 2018

Uh oh!

meshcollider commented Nov 3, 2018 •

edited

Loading

Uh oh!

promag commented Nov 4, 2018

Uh oh!

ken2812221 commented Nov 5, 2018

Uh oh!

fanquake commented Nov 5, 2018

Uh oh!

promag commented Nov 5, 2018

Uh oh!

laanwj commented Nov 5, 2018

Uh oh!

Uh oh!

Move util files to directory #14555

Move util files to directory #14555

Uh oh!

Conversation

jimpo commented Oct 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maflcko commented Oct 23, 2018

Uh oh!

DrahtBot commented Oct 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

promag commented Oct 24, 2018

Uh oh!

ken2812221 commented Oct 25, 2018

Uh oh!

ken2812221 commented Oct 26, 2018

Uh oh!

promag commented Oct 26, 2018

Uh oh!

maflcko commented Oct 26, 2018

Uh oh!

scravy commented Oct 26, 2018

Uh oh!

meshcollider commented Nov 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

promag commented Nov 4, 2018

Uh oh!

ken2812221 commented Nov 5, 2018

Uh oh!

fanquake commented Nov 5, 2018

Uh oh!

promag commented Nov 5, 2018

Uh oh!

laanwj commented Nov 5, 2018

Uh oh!

Uh oh!

jimpo commented Oct 23, 2018 •

edited

Loading

DrahtBot commented Oct 23, 2018 •

edited

Loading

meshcollider commented Nov 3, 2018 •

edited

Loading