Skip to content

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Oct 7, 2019

Really dumb move-only stolen from #16805. Some of my pull requests also depend on this, so I split it up to not depend on #16805.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0d86f4d, I have reviewed the code and it looks OK, I agree it can be merged.

Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0d86f4d.

@practicalswift
Copy link
Contributor

ACK 0d86f4d -- diff looks correct

laanwj added a commit that referenced this pull request Oct 8, 2019
0d86f4d refactor: consolidate PASTE macros (James O'Beirne)

Pull request description:

  Really dumb move-only stolen from #16805. Some of my pull requests also depend on this, so I split it up to not depend on #16805.

ACKs for top commit:
  practicalswift:
    ACK 0d86f4d -- diff looks correct
  hebasto:
    ACK 0d86f4d, I have reviewed the code and it looks OK, I agree it can be merged.
  promag:
    ACK 0d86f4d.

Tree-SHA512: 19208a8cbf83034b1ef25138d8f08d8f32ace7775f654b1597fc4599dd576f0758145f592f161cfdcaaa29d4907ac9aa5553f6f524e2b960205c760605a05901
@laanwj laanwj merged commit 0d86f4d into bitcoin:master Oct 8, 2019
@maflcko maflcko deleted the 1909-jamesPastemoveonly branch October 8, 2019 13:14
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Oct 8, 2019
0d86f4d refactor: consolidate PASTE macros (James O'Beirne)

Pull request description:

  Really dumb move-only stolen from bitcoin#16805. Some of my pull requests also depend on this, so I split it up to not depend on bitcoin#16805.

ACKs for top commit:
  practicalswift:
    ACK 0d86f4d -- diff looks correct
  hebasto:
    ACK 0d86f4d, I have reviewed the code and it looks OK, I agree it can be merged.
  promag:
    ACK 0d86f4d.

Tree-SHA512: 19208a8cbf83034b1ef25138d8f08d8f32ace7775f654b1597fc4599dd576f0758145f592f161cfdcaaa29d4907ac9aa5553f6f524e2b960205c760605a05901
MarkLTZ added a commit to litecoinz-core/litecoinz that referenced this pull request Nov 17, 2019
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Apr 26, 2020
Summary: This is a backport of Core [[bitcoin/bitcoin#17073 | PR17073]]

Test Plan:
  make check

Reviewers: #bitcoin_abc, majcosta

Reviewed By: majcosta

Differential Revision: https://reviews.bitcoinabc.org/D5845
kwvg added a commit to kwvg/dash that referenced this pull request Jun 16, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Jun 16, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Jun 24, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Jun 25, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Jun 25, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Jun 26, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Jun 26, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Jun 27, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Jun 27, 2021
UdjinM6 added a commit to dashpay/dash that referenced this pull request Jun 27, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants