Utxoscriptindex #14035

mgrychow · 2018-08-23T19:34:19Z

Yet another attempt to introduce UTxO index by script. Based on #9806 with review remarks and new index framework introduced in #13033 taken into account.

DrahtBot · 2018-08-23T22:03:15Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#14942 (wallet: Return a ScanResult from CWallet::RescanFromTime by Empact)
#14384 (Resolve validationinterface circular dependencies by 251Labs)
#14121 (Index for BIP 157 block filters by jimpo)
#14111 (index: Create IndexRunner class for activing indexes. by jimpo)
#13949 (Introduce MempoolObserver interface to break "policy/fees -> txmempool -> policy/fees" circular dependency by Empact)
#13743 (refactor: Replace boost::bind with std::bind by ken2812221)
#13088 (Log early messages with -printtoconsole by ajtowns)
#10973 (Refactor: separate wallet from node by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

instagibbs · 2018-08-24T16:23:37Z

src/rpc/blockchain.cpp

+        ScriptPubKeyToUniv(coin.out.scriptPubKey, oScriptPubKey, true);
+
+        UniValue o(UniValue::VOBJ);
+        o.push_back(Pair("confirmations", nConfirmations));


note: "push_back(Pair" is deprecated in favor of pushKV

instagibbs · 2018-08-24T16:25:59Z

Might be wortwhile to update it to using output descriptors, like scantxoutset: https://github.com/bitcoin/bitcoin/blob/master/src/rpc/blockchain.cpp#L2035

mgrychow · 2018-08-24T18:08:59Z

@instagibbs Thanks for the remarks, how about adding support for descriptors in separate PR?

marcinja · 2018-08-24T18:57:29Z

@mgrychow, I recently started working on an address-based index (not just for UTXOs) at #14053. I can improve my PR quite a bit using your changes to the ValidationInterface. If you separated that change (adding CBlockUndo's) into it's own commit this PR would be a bit cleaner, and I could use it for the address index :)

Anyway, will be reviewing this since it's pretty similar to the PR I just made.

instagibbs · 2018-08-24T18:59:37Z

@mgrychow Not going to bikeshed this PR to death, just noting it in case you've missed it.

src/index/utxoscriptindex.cpp

…d, copyrights, minor cleanup

mgrychow · 2018-11-14T10:39:19Z

Rebased

DrahtBot · 2018-12-29T16:28:58Z

Needs rebase

Changes cherry-picked from bitcoin#14035. Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

maflcko · 2019-04-19T17:37:46Z

There hasn't been much activity lately and the patch still needs rebase, so I am closing this for now. Please let me know when you want to continue working on this, so the pull request can be re-opened.

Changes cherry-picked from bitcoin#14035. Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

mgrychow force-pushed the utxoscriptindex branch 2 times, most recently from 0d539fb to bb9f28b Compare August 23, 2018 20:41

mgrychow force-pushed the utxoscriptindex branch 2 times, most recently from 15ddf9f to ebe3d1f Compare August 24, 2018 01:07

instagibbs reviewed Aug 24, 2018

View reviewed changes

marcinja mentioned this pull request Aug 24, 2018

Add address-based index (attempt 4?) #14053

Closed

marcinja suggested changes Aug 24, 2018

View reviewed changes

src/index/utxoscriptindex.cpp Show resolved Hide resolved

src/index/utxoscriptindex.cpp Show resolved Hide resolved

laanwj added the UTXO Db and Indexes label Aug 25, 2018

DrahtBot mentioned this pull request Aug 25, 2018

build: generate MSVC project files via python script #14062

Merged

DrahtBot added the Needs rebase label Aug 25, 2018

mgrychow force-pushed the utxoscriptindex branch from 37562b7 to 9eeb194 Compare August 27, 2018 12:20

DrahtBot removed the Needs rebase label Aug 27, 2018

DrahtBot mentioned this pull request Aug 30, 2018

index: Create IndexRunner class for activing indexes. #14111

Closed

jimpo mentioned this pull request Aug 31, 2018

Index for BIP 157 block filters #14121

Merged

DrahtBot mentioned this pull request Sep 12, 2018

build: Move interfaces/* to libbitcoin_server #14204

Merged

DrahtBot added the Needs rebase label Sep 12, 2018

mgrychow force-pushed the utxoscriptindex branch from 9eeb194 to 3b6f42c Compare September 14, 2018 13:54

DrahtBot removed the Needs rebase label Sep 14, 2018

mgrychow force-pushed the utxoscriptindex branch from 3b6f42c to a8294c2 Compare September 14, 2018 14:19

DrahtBot mentioned this pull request Sep 15, 2018

tests: Reorder tests and move most of extended tests up to normal tests #14225

Merged

DrahtBot added the Needs rebase label Nov 5, 2018

mgrychow added 3 commits November 13, 2018 17:43

utxoscriptindex: draft

e3165d0

utxoscriptindex: utxoindex to utxoscriptindex rename, unit tests adde…

e6aaa3a

…d, copyrights, minor cleanup

whitespace fix + msvc build fix

1d4eb29

mgrychow force-pushed the utxoscriptindex branch from a81937d to 94c1d5c Compare November 13, 2018 18:29

DrahtBot removed the Needs rebase label Nov 13, 2018

utxoscriptindex: rework - push(Pair) replaced with pushKV

34c8e8e

mgrychow force-pushed the utxoscriptindex branch from 94c1d5c to 34c8e8e Compare November 13, 2018 18:49

DrahtBot added the Needs rebase label Dec 29, 2018

marcinja added a commit to marcinja/bitcoin that referenced this pull request Jan 22, 2019

Add CBlockUndo data to BlockConnected callbacks

8c07159

Changes cherry-picked from bitcoin#14035. Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

marcinja added a commit to marcinja/bitcoin that referenced this pull request Jan 22, 2019

Add CBlockUndo data to BlockConnected callbacks

d04d72b

Changes cherry-picked from bitcoin#14035. Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

marcinja added a commit to marcinja/bitcoin that referenced this pull request Jan 30, 2019

Add CBlockUndo data to BlockConnected callbacks

3fb4c5b

Changes cherry-picked from bitcoin#14035. Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

marcinja added a commit to marcinja/bitcoin that referenced this pull request Jan 30, 2019

Add CBlockUndo data to BlockConnected callbacks

d4d30e0

Changes cherry-picked from bitcoin#14035. Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

marcinja added a commit to marcinja/bitcoin that referenced this pull request Mar 6, 2019

Add CBlockUndo data to BlockConnected callbacks

cce0e5c

Changes cherry-picked from bitcoin#14035. Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

marcinja added a commit to marcinja/bitcoin that referenced this pull request Mar 20, 2019

Add CBlockUndo data to BlockConnected callbacks

8de4da0

Changes cherry-picked from bitcoin#14035. Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

marcinja added a commit to marcinja/bitcoin that referenced this pull request Mar 20, 2019

Add CBlockUndo data to BlockConnected callbacks

0840d8e

Changes cherry-picked from bitcoin#14035. Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

marcinja added a commit to marcinja/bitcoin that referenced this pull request Mar 20, 2019

Add CBlockUndo data to BlockConnected callbacks

68f2a7e

Changes cherry-picked from bitcoin#14035. Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

marcinja added a commit to marcinja/bitcoin that referenced this pull request Mar 20, 2019

Add CBlockUndo data to BlockConnected callbacks

1d5e31f

Changes cherry-picked from bitcoin#14035. Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

maflcko closed this Apr 19, 2019

marcinja added a commit to marcinja/bitcoin that referenced this pull request Aug 16, 2019

Add CBlockUndo data to BlockConnected callbacks

dcae6bf

Changes cherry-picked from bitcoin#14035. Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

marcinja added a commit to marcinja/bitcoin that referenced this pull request Aug 16, 2019

Add CBlockUndo data to BlockConnected callbacks

e26decf

Changes cherry-picked from bitcoin#14035. Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

marcinja added a commit to marcinja/bitcoin that referenced this pull request Aug 16, 2019

Add CBlockUndo data to BlockConnected callbacks

820d566

Changes cherry-picked from bitcoin#14035. Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

fjahr pushed a commit to fjahr/bitcoin that referenced this pull request Aug 26, 2019

Add CBlockUndo data to BlockConnected callbacks

d852088

Changes cherry-picked from bitcoin#14035. Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

laanwj removed the Needs rebase label Oct 24, 2019

bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Utxoscriptindex #14035

Utxoscriptindex #14035

Uh oh!

mgrychow commented Aug 23, 2018

Uh oh!

DrahtBot commented Aug 23, 2018 •

edited

Loading

Uh oh!

instagibbs Aug 24, 2018

Uh oh!

mgrychow Aug 24, 2018

Uh oh!

instagibbs commented Aug 24, 2018

Uh oh!

mgrychow commented Aug 24, 2018

Uh oh!

marcinja commented Aug 24, 2018

Uh oh!

instagibbs commented Aug 24, 2018

Uh oh!

Uh oh!

Uh oh!

mgrychow commented Nov 14, 2018

Uh oh!

DrahtBot commented Dec 29, 2018

Uh oh!

maflcko commented Apr 19, 2019

Uh oh!

Uh oh!

Utxoscriptindex #14035

Utxoscriptindex #14035

Uh oh!

Conversation

mgrychow commented Aug 23, 2018

Uh oh!

DrahtBot commented Aug 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

instagibbs Aug 24, 2018

Choose a reason for hiding this comment

Uh oh!

mgrychow Aug 24, 2018

Choose a reason for hiding this comment

Uh oh!

instagibbs commented Aug 24, 2018

Uh oh!

mgrychow commented Aug 24, 2018

Uh oh!

marcinja commented Aug 24, 2018

Uh oh!

instagibbs commented Aug 24, 2018

Uh oh!

Uh oh!

Uh oh!

mgrychow commented Nov 14, 2018

Uh oh!

DrahtBot commented Dec 29, 2018

Uh oh!

maflcko commented Apr 19, 2019

Uh oh!

Uh oh!

DrahtBot commented Aug 23, 2018 •

edited

Loading