Update MCP options for rover dev #2661
Conversation
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 7 changed, 0 removedBuild ID: d676400e03a45d58c3cef379 URL: https://www.apollographql.com/docs/deploy-preview/d676400e03a45d58c3cef379 |
src/command/dev/mcp.rs
Outdated
| explorer: bool, | ||
|
|
||
| /// Change the level at which the MCP Server logs, possible values | ||
| #[arg(long = "mcp-log", default_value_t = Level::INFO)] |
There was a problem hiding this comment.
I don't think we need this - it should just pass through the rover log level. IIRC, this is what it does for router.
There was a problem hiding this comment.
Sorry @pubmodmatt, I'm not familiar with the logging mechanism in Rover. What do I need to do to see the debug logs of the MCP server when I run it using rover dev?
There was a problem hiding this comment.
Rover has its own -l DEBUG which should turn on MCP debug and router debug when using rover dev. But I think currently that only works for router - we need to have it pass through that value to the MCP server.
There was a problem hiding this comment.
That explains why I couldn't see the debug logs! I've removed this. I'll create a backlog ticket.
| #[arg(long = "mcp-uplink")] | ||
| uplink: bool, | ||
| /// Enable use of uplink to get persisted queries (requires APOLLO_KEY and APOLLO_GRAPH_REF) | ||
| #[arg(long = "mcp-uplink-manifest")] |
There was a problem hiding this comment.
I think you'd want to keep the old name but hide it, as is done in apollo-mcp-server, to avoid a breaking change here.
There was a problem hiding this comment.
Thanks for the feedback! I made mcp-uplink-manifest compatible with mcp-uplink.
# [0.35.0] - 2025-07-30 ## ❗ BREAKING ❗ - **use config file for MCP server - @nicholascioli PR #2665** ## 🚀 Features - **Update MCP options for rover dev - @DaleSeo PR #2661** - **Add schema name step to Connectors init workflow - @alyssahursh PR #2647** - **Allow running rover dev without --supergraph-config if you have a rover.yaml in the current directory - @dylan-apollo PR #2650** - **Updating output for init & renaming generated "supergraph.yaml" -> "rover.yaml" - @tayrrible PR #2651** - **Adds support for .env file for use with rover dev - @DMallare PR #2646** - **Add graph_ref to and remove federation_version from subgraph.yaml - @alyssahursh PR #2649** - **Hackathon improvements to supergraph.yaml - @dylan-apollo PR #2648** - **Adding link to studio for graph & showing each step in creation process via spinners - @tayrrible PR #2657** - **Generates .env file with rover init - @DMallare PR #2652** - **Remove use case guard clause in schema name prompt - @alyssahursh PR #2655** - **Set APOLLO_GRAPH_REF from rover.yaml's graph_ref - @dylan-apollo PR #2653** - **Adding apollo.config.yaml file for connectors projects - @tayrrible PR #2658** - **add a note about the need for APOLLO_KEY and APOLLO_GRAPH_REF when using router features or connect - @the-gigi-apollo PR #2677** - **Update Studio Client after loading .env in rover dev - @dylan-apollo PR #2654** - **Exposing org selector for all runs of init and changing prompt order - @tayrrible PR #2656** ## 🛠 Maintenance - **upgrade schemars and apollo-federation-types - @DaleSeo PR #2676**
This PR updates the MCP options for
rover devas follows:--mcp-uplinkis deprecated in favor of--mcp-uplink-manifest.--mcp-explorerandoptions have been added.--mcp-log