Remove use case guard clause in schema name prompt #2655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tayrrible
approved these changes
Jul 10, 2025
Merged
DaleSeo
added a commit
that referenced
this pull request
Jul 30, 2025
# [0.35.0] - 2025-07-30 ## ❗ BREAKING ❗ - **use config file for MCP server - @nicholascioli PR #2665** ## 🚀 Features - **Update MCP options for rover dev - @DaleSeo PR #2661** - **Add schema name step to Connectors init workflow - @alyssahursh PR #2647** - **Allow running rover dev without --supergraph-config if you have a rover.yaml in the current directory - @dylan-apollo PR #2650** - **Updating output for init & renaming generated "supergraph.yaml" -> "rover.yaml" - @tayrrible PR #2651** - **Adds support for .env file for use with rover dev - @DMallare PR #2646** - **Add graph_ref to and remove federation_version from subgraph.yaml - @alyssahursh PR #2649** - **Hackathon improvements to supergraph.yaml - @dylan-apollo PR #2648** - **Adding link to studio for graph & showing each step in creation process via spinners - @tayrrible PR #2657** - **Generates .env file with rover init - @DMallare PR #2652** - **Remove use case guard clause in schema name prompt - @alyssahursh PR #2655** - **Set APOLLO_GRAPH_REF from rover.yaml's graph_ref - @dylan-apollo PR #2653** - **Adding apollo.config.yaml file for connectors projects - @tayrrible PR #2658** - **add a note about the need for APOLLO_KEY and APOLLO_GRAPH_REF when using router features or connect - @the-gigi-apollo PR #2677** - **Update Studio Client after loading .env in rover dev - @dylan-apollo PR #2654** - **Exposing org selector for all runs of init and changing prompt order - @tayrrible PR #2656** ## 🛠 Maintenance - **upgrade schemars and apollo-federation-types - @DaleSeo PR #2676**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use case guard clause in the schema name prompt. When the original work to add the schema name prompt was written (#2647), I made the incorrect assumption that we would only want to prompt for a schema name in the Connector use case. My changes were tested with and intended to work with this PR: apollographql/rover-init-starters#51
Because this work was done as part of the 2025 Hackathon project, a different commit to
rover-init-starterswas merged instead: apollographql/rover-init-starters#52 This version assumes that the schema prompt will happen regardless of project type. This PR adapts 2467 to work with the work that was merged inrover-init-startersTesting
cargo buildto build theseroverchangescargo rovertolocalroverwithalias localrover='cargo run --manifest-path=/Users/alyssahursh/code/rover/Cargo.toml --bin rover --'localrover initsupergraph.yamlfile was created using the newly provided schema name