Skip to content

Conversation

dylan-apollo
Copy link
Member

@dylan-apollo dylan-apollo commented Jul 9, 2025

  1. Use a local struct for supergraph.yaml ser/de instead of apollo-federation-types
  2. Add a graph_ref property to supergraph.yaml which works like --graph-ref
  3. Load federation version from GraphOS when --graph-ref or graph_ref is set
  4. Refactorings to support the above

@dylan-apollo dylan-apollo requested review from a team as code owners July 9, 2025 22:37
@apollo-librarian
Copy link
Contributor

apollo-librarian bot commented Jul 9, 2025

⚠️ Docs preview not attached to branch

The preview was not built because the PR's base branch release-0.35.0-beta is not in the list of sources.

An Apollo team member can comment one of the following commands to dictate which branch to attach the preview to:

  • !docs set-base-branch main

Build ID: 2047ecf895e03cd91bafdf14

…eration-types`.

Also some code simplification as I explored:
1. Remove some unused trait indirection to make jumping to/from usages easier during iteration
2. Collapse part of `SupergraphConfigResolver` since loading remote subgraphs won't be one-time anymore
3. Turn some `pub` into `pub(crate)` for better dead code detection as I change things
4. Remove some unnecessary cloning by getting rid of some buildstructors that were only creating simple structs
@dylan-apollo dylan-apollo merged commit 092ac64 into release-0.35.0-beta Jul 9, 2025
32 checks passed
@dylan-apollo dylan-apollo deleted the dylan/rover-yaml branch July 9, 2025 22:50
@dylan-apollo dylan-apollo restored the dylan/rover-yaml branch July 9, 2025 22:50
@DaleSeo DaleSeo added this to the v0.35.0 milestone Jul 30, 2025
@DaleSeo DaleSeo added the feature 🎉 new commands, flags, functionality, and improved error messages label Jul 30, 2025
@DaleSeo DaleSeo mentioned this pull request Jul 30, 2025
DaleSeo added a commit that referenced this pull request Jul 30, 2025
# [0.35.0] - 2025-07-30

## ❗ BREAKING ❗

- **use config file for MCP server - @nicholascioli PR #2665**

## 🚀 Features

- **Update MCP options for rover dev - @DaleSeo PR #2661**
- **Add schema name step to Connectors init workflow - @alyssahursh PR
#2647**
- **Allow running rover dev without --supergraph-config if you have a
rover.yaml in the current directory - @dylan-apollo PR #2650**
- **Updating output for init & renaming generated "supergraph.yaml" ->
"rover.yaml" - @tayrrible PR #2651**
- **Adds support for .env file for use with rover dev - @DMallare PR
#2646**
- **Add graph_ref to and remove federation_version from subgraph.yaml -
@alyssahursh PR #2649**
- **Hackathon improvements to supergraph.yaml - @dylan-apollo PR #2648**
- **Adding link to studio for graph & showing each step in creation
process via spinners - @tayrrible PR #2657**
- **Generates .env file with rover init - @DMallare PR #2652**
- **Remove use case guard clause in schema name prompt - @alyssahursh PR
#2655**
- **Set APOLLO_GRAPH_REF from rover.yaml's graph_ref - @dylan-apollo PR
#2653**
- **Adding apollo.config.yaml file for connectors projects - @tayrrible
PR #2658**
- **add a note about the need for APOLLO_KEY and APOLLO_GRAPH_REF when
using router features or connect - @the-gigi-apollo PR #2677**
- **Update Studio Client after loading .env in rover dev - @dylan-apollo
PR #2654**
- **Exposing org selector for all runs of init and changing prompt order
- @tayrrible PR #2656**


## 🛠 Maintenance

- **upgrade schemars and apollo-federation-types - @DaleSeo PR #2676**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants