This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Fix lints by removing superfluous var type from var instantiation #4917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
721091f to
e1414bc
Compare
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
e1414bc to
376ccab
Compare
Codecov Report
@@ Coverage Diff @@
## main #4917 +/- ##
==========================================
+ Coverage 68.63% 68.65% +0.02%
==========================================
Files 220 220
Lines 15942 15944 +2
==========================================
+ Hits 10942 10947 +5
+ Misses 4948 4945 -3
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
keithmattix
approved these changes
Jul 19, 2022
shashankram
approved these changes
Jul 19, 2022
trstringer
pushed a commit
that referenced
this pull request
Jul 20, 2022
* chore(cmd/cli): Reduce cyclomatic complexity of uninstall command (#4825) * chore(cmd/cli): Reduce cyclomatic complexity of uninstall command Separate code into functions to reduce the cyclomatic complexity And adds unit tests to functions created Helps unblock #4555 Signed-off-by: Shalier Xia <shalierxia@microsoft.com> (cherry picked from commit d5d3a25) * Golang errors pkg (#4904) This PR partially resolves #4524 * Removes "github.com/pkg/errors" package from the repo * Wrap errors wherever possible rather than using the string format of the error as part of the message Signed-off-by: Allen Leigh <allenlsy@gmail.com> (cherry picked from commit 8030047) * fix golints and security scan issues (#4915) fix golints and security for: 1. G112 (ReadHeaderTimeout) 2. prometheus client_go version pinned to bad version Signed-off-by: Sean Teeling <seanteeling@microsoft.com> (cherry picked from commit f768f64) * Fix lints by removing superfluous var type from var instantiation (#4917) Remove unnecessary var types during instantiation to fix lints Signed-off-by: Sean Teeling <seanteeling@microsoft.com> (cherry picked from commit 9e9f712) Co-authored-by: Shalier Xia <69616256+shalier@users.noreply.github.com> Co-authored-by: allenlsy <allenlsy@gmail.com> Co-authored-by: steeling <seanteeling@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary var types during instantiation to fix lints