Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

Conversation

steeling
Copy link
Contributor

  1. Bump prom client
  2. Add ReadHeaderTimeout of 10s

Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
Copy link
Contributor

@keithmattix keithmattix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that read header timeout is high, but I'm fine with leaving it for now

Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
@jaellio jaellio mentioned this pull request Jul 19, 2022
@steeling steeling merged commit f768f64 into openservicemesh:main Jul 19, 2022
@steeling steeling deleted the feature/lints-sec branch July 19, 2022 16:39
trstringer pushed a commit that referenced this pull request Jul 20, 2022
* chore(cmd/cli): Reduce cyclomatic complexity of uninstall command (#4825)

* chore(cmd/cli): Reduce cyclomatic complexity of uninstall command

Separate code into functions to reduce the cyclomatic complexity
And adds unit tests to functions created
Helps unblock #4555

Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
(cherry picked from commit d5d3a25)

* Golang errors pkg (#4904)

This PR partially resolves #4524

* Removes "github.com/pkg/errors" package from the repo
* Wrap errors wherever possible rather than using the string format of the error as part of the message

Signed-off-by: Allen Leigh <allenlsy@gmail.com>
(cherry picked from commit 8030047)

* fix golints and security scan issues (#4915)

fix golints and security for:

1. G112 (ReadHeaderTimeout)
2. prometheus client_go version pinned to bad version

Signed-off-by: Sean Teeling <seanteeling@microsoft.com>

(cherry picked from commit f768f64)

* Fix lints by removing superfluous var type from var instantiation (#4917)

Remove unnecessary var types during instantiation to fix lints

Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
(cherry picked from commit 9e9f712)

Co-authored-by: Shalier Xia <69616256+shalier@users.noreply.github.com>
Co-authored-by: allenlsy <allenlsy@gmail.com>
Co-authored-by: steeling <seanteeling@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants