Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

chore(release): add missing cherry picks #4932

Merged
merged 4 commits into from
Jul 20, 2022
Merged

chore(release): add missing cherry picks #4932

merged 4 commits into from
Jul 20, 2022

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Jul 20, 2022 •
edited
Loading

Description: Add missing cherry-picks for v1.2:

Testing done:

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?

  2. Is this a breaking change?

  3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

shalier and others added 3 commits July 20, 2022 14:07
@shalier @nojnhuh
chore(cmd/cli): Reduce cyclomatic complexity of uninstall command (#4825
6450183 
)

* chore(cmd/cli): Reduce cyclomatic complexity of uninstall command

Separate code into functions to reduce the cyclomatic complexity
And adds unit tests to functions created
Helps unblock #4555

Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
(cherry picked from commit d5d3a25)
@allenlsy @nojnhuh
Golang errors pkg (#4904)
d9aa4bd 
This PR partially resolves #4524

* Removes "github.com/pkg/errors" package from the repo
* Wrap errors wherever possible rather than using the string format of the error as part of the message

Signed-off-by: Allen Leigh <allenlsy@gmail.com>
(cherry picked from commit 8030047)
@steeling @nojnhuh
fix golints and security scan issues (#4915)
69d6cf7 
fix golints and security for:

1. G112 (ReadHeaderTimeout)
2. prometheus client_go version pinned to bad version

Signed-off-by: Sean Teeling <seanteeling@microsoft.com>

(cherry picked from commit f768f64)
trstringer
trstringer previously approved these changes Jul 20, 2022
View reviewed changes
jaellio
jaellio previously approved these changes Jul 20, 2022
View reviewed changes
keithmattix
keithmattix previously approved these changes Jul 20, 2022
View reviewed changes
@steeling @nojnhuh
Fix lints by removing superfluous var type from var instantiation (#4917
b86df01 
)

Remove unnecessary var types during instantiation to fix lints

Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
(cherry picked from commit 9e9f712)
@nojnhuh nojnhuh dismissed stale reviews from keithmattix, jaellio, and trstringer via b86df01 July 20, 2022 19:27
@trstringer trstringer merged commit 4c832d1 into openservicemesh:release-v1.2 Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shashankram shashankram Awaiting requested review from shashankram

@snehachhabria snehachhabria Awaiting requested review from snehachhabria

@draychev draychev Awaiting requested review from draychev

@steeling steeling Awaiting requested review from steeling

3 more reviewers

@trstringer trstringer trstringer approved these changes

@keithmattix keithmattix keithmattix approved these changes

@jaellio jaellio jaellio left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nojnhuh @trstringer @keithmattix @jaellio @shalier @allenlsy @steeling