[RFC] Add TermClose event #3653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| terminal_close(data->term, | ||
| _("\r\n[Program exited, press any key to close]")); | ||
| char *msg = xmalloc(24); | ||
| sprintf(msg, "[Process exited <%d>]", proc->status); |
There was a problem hiding this comment.
I wish we had an asprintf() wrapper... oh well.
edit: after trying this out, I don't think the angle brackets are needed; [Process exited 255] is perfectly clear IMO.
There was a problem hiding this comment.
👍 I did not mean to suggest literal brackets.
|
Vim_diff.txt is mostly for backward incompatible changes... |
1a34089 to
c32e3f6
Compare
|
@justinmk There is a section “new features” there. |
|
(Also you may consider this backward incompatible: pretend that there are scripts which parse the whole |
3afcd77 to
bb0311b
Compare
A terminal buffer now exits with: [Process exited <return value>]
You can hook into it. E.g. :au TermClose * call feedkeys('<cr>')
Closes neovim#2293.
4090f2e to
2f2e57b
Compare
2f2e57b to
ec847af
Compare
mhinz
added a commit
that referenced
this pull request
Nov 15, 2015
justinmk
added a commit
that referenced
this pull request
Dec 5, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #2293
A terminal buffer now exits with:
[Process exited <return value>].You can hook into it, e.g.
:autocmd TermClose * call feedkeys('<cr>').