[RDY] Store last search direction when writing ShaDa files #3581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
@ZyX-I can you rebase this? I just merged the ShaDa editing plugin |
|
@fmoralesc Rebased. |
Note: it looks like viminfo files do not store search direction intentionally. After reading viminfo file search direction was considered to be “forward”. Note 2: all files created on earlier Neovim version will automatically receive “forward” direction. Fixes neovim#3580
|
Thanks, @ZyX-I. LGTM, I'll mark as RDY and wait for someone else to comment, but I think we can merge this. |
|
👍 |
|
OK, merging. |
fmoralesc
added a commit
that referenced
this pull request
Nov 23, 2015
Store last search direction when writing ShaDa files
justinmk
added a commit
that referenced
this pull request
Dec 5, 2015
sakhnik
added a commit
to sakhnik/neovim
that referenced
this pull request
Dec 9, 2018
Problem: Internal diff fails when diffing a context diff. (Hirohito Higashi) Solution: Only use callback calls with one line. (closes neovim#3581) vim/vim@f080d70
sakhnik
added a commit
to sakhnik/neovim
that referenced
this pull request
Dec 9, 2018
Problem: Internal diff fails when diffing a context diff. (Hirohito Higashi) Solution: Only use callback calls with one line. (closes neovim#3581) vim/vim@f080d70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3580.
Note that there is behaviour change compared to Vim: Vim does not store the direction, it always assumes “forward”.
Blocked by #3270 (new key support was added also to runtime files from #3270). Also bringing that PR to attention: I would really like to see it in before the release since it contains support code for one of the major features. Also because #3580 is only a minor inconvenience.
Feel free to cherry-pick last commit without changes to files from #3270 if latter is unacceptable for some reason.