Skip to content

[RDY] Add plugin for editing ShaDa files #3270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 22, 2015
Merged

[RDY] Add plugin for editing ShaDa files #3270

merged 7 commits into from
Nov 22, 2015

Conversation

ZyX-I
Copy link
Contributor

@ZyX-I ZyX-I commented Aug 30, 2015

Wondering whether test/functional/plugin is the right place for testing plugin files.

Note: this is not blocked by #2506 since I do not plan any format changes.

TODO:

  • Runtime files.
  • autoload/msgpack.vim tests.
  • autoload/shada.vim tests.
  • ftplugin/shada.vim + plugin/shada.vim tests.
  • syntax/shada.vim tests.
  • Documentation for autoload/msgpack.vim.
  • Documentation for */shada.vim.

@ZyX-I ZyX-I added the runtime funtime label Aug 30, 2015
@marvim marvim added the WIP label Aug 30, 2015
@ZyX-I ZyX-I force-pushed the shada-support branch 5 times, most recently from 6ab7f2b to 7342648 Compare September 5, 2015 17:41
@ZyX-I
Copy link
Contributor Author

ZyX-I commented Sep 6, 2015

Actually it is better to make this blocked by #2506 because I need some helper functions from there for plugin/shada.vim tests (but not for other files).

@ZyX-I ZyX-I force-pushed the shada-support branch 2 times, most recently from 8c672ce to 1460229 Compare September 6, 2015 22:25
fmoralesc
fmoralesc reviewed Sep 7, 2015
View reviewed changes
runtime/doc/pi_msgpack.txt
@@ -0,0 +1,139 @@
*pi_msgpack.txt* For NeoVim version 7.4.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the version is appropriate.

@ZyX-I ZyX-I force-pushed the shada-support branch 2 times, most recently from 04c3bff to 383f042 Compare September 9, 2015 19:13
@ZyX-I
Copy link
Contributor Author

ZyX-I commented Sep 9, 2015

@justinmk So “Update branch” button adds merge commit (merged master into my branch). It is interesting whether merging it afterwards will produce another merge commit or not.

@ZyX-I
Copy link
Contributor Author

ZyX-I commented Sep 9, 2015

(I have already removed the merge commit by force-push, so you will not see it here.)

@ZyX-I ZyX-I changed the title [WIP] Add plugin for editing ShaDa files [RFC] Add plugin for editing ShaDa files Sep 11, 2015
@ZyX-I
Copy link
Contributor Author

ZyX-I commented Sep 11, 2015

This PR is ready, but SourceCmd event cannot be tested without #2506 and there is also some common code.

@marvim marvim added RFC and removed WIP labels Sep 11, 2015
@justinmk
Copy link
Member

I haven't had any problems with #2506 since you fixed the last memory access issue. I think we should aim to merge it by Monday.

ZyX-I referenced this pull request in tarruda/neovim Sep 15, 2015
@tarruda
loop: Free the parent queue last when destroying the loop
f532a43 
Close neovim#3334
@tarruda
Copy link
Member

tarruda commented Sep 16, 2015

@ZyX-I the #3334 fix is merged, you can rebase to make the tests pass.

@ZyX-I ZyX-I mentioned this pull request Sep 16, 2015
Closed
@ZyX-I ZyX-I mentioned this pull request Oct 5, 2015
Closed
@ZyX-I
Copy link
Contributor Author

ZyX-I commented Oct 16, 2015

I have updated the PR and it is now ready for merging.

@ZyX-I ZyX-I mentioned this pull request Oct 17, 2015
Closed
@ZyX-I ZyX-I mentioned this pull request Nov 1, 2015
Merged
@ZyX-I
Copy link
Contributor Author

ZyX-I commented Nov 1, 2015

Wondering why it fails with

make: *** No rule to make target `unittest'.  Stop.
make: Leaving directory `/home/travis/build/neovim/neovim/build'

And non-failing builds did not run unit or functional tests at all, only old tests.

@ZyX-I
Copy link
Contributor Author

ZyX-I commented Nov 1, 2015

And #3581 does run unit and functional tests. Will try restarting the whole build.

@fmoralesc
Copy link
Contributor

@ZyX-I I found that locally too, wonder what is going on.

@ZyX-I
Copy link
Contributor Author

ZyX-I commented Nov 1, 2015

@fmoralesc Unable to reproduce this locally. Also I see that https://travis-ci.org/neovim/neovim/jobs/88665063 is no longer affected.

@fmoralesc
Copy link
Contributor

Maybe a temporary thing. This is the sort of thing I've seen happen when
travis messes up somehow.

On Sun, Nov 1, 2015 at 7:57 PM, Nikolai Aleksandrovich Pavlov <
notifications@github.com> wrote:

@fmoralesc https://github.com/fmoralesc Unable to reproduce this
locally. Also I see that https://travis-ci.org/neovim/neovim/jobs/88665063
is no longer affected.

—
Reply to this email directly or view it on GitHub
#3270 (comment).

@fmoralesc
Copy link
Contributor

Bump. Anything else to be done here?

@ZyX-I
Copy link
Contributor Author

ZyX-I commented Nov 22, 2015

Nothing. I have already reported this as ready in #3270 (comment).

@fmoralesc
Copy link
Contributor

OK, then. It looks good. I'll wait for @justinmk or @tarruda to comment, but I think we might just merge this later today (and then, #3581)

@fmoralesc fmoralesc changed the title [RFC] Add plugin for editing ShaDa files [RDY] Add plugin for editing ShaDa files Nov 22, 2015
@mhinz
Copy link
Member

mhinz commented Nov 22, 2015

👍

fmoralesc added a commit that referenced this pull request Nov 22, 2015
@fmoralesc
Merge pull request #3270 from ZyX-I/shada-support
321db59 
Add plugin for editing ShaDa files
@fmoralesc fmoralesc merged commit 321db59 into neovim:master Nov 22, 2015
@jszakmeister jszakmeister removed the RFC label Nov 22, 2015
@ZyX-I ZyX-I deleted the shada-support branch November 23, 2015 13:56
justinmk added a commit that referenced this pull request Dec 5, 2015
@justinmk
Nvim 0.1.1
4a1c36e 
- shada/msgpack editor plugin #3270
- VimL Dict notifications #3603
    - Note: API for this feature may change.
- :profile dump, :profile stop #2427
- :oldfiles! #3611
- TermOpen, TermClose events #3653
- fix: shada/viminfo: Do not save unlisted and quickfix buffers #3581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
runtime funtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ZyX-I @justinmk @tarruda @fmoralesc @mhinz @jszakmeister @marvim