Refactoring Work on vim.h #7562
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. We generally don't want to spend time on style-only changes. Since this was easy to check, I merged it anyway. I had to fix some things though, so it was amended. |
sameedali
added a commit
to sameedali/neovim
that referenced
this pull request
Nov 19, 2017
* 'master' of https://github.com/neovim/neovim: (148 commits) vim-patch:8.0.0283 version bump NVIM v0.2.2 tui: setrgbf/setrgbb: emit semicolons for VTE 'viewoptions': add "curdir" flag neovim#7447 win: provider: Detect(): return *.cmd path (neovim#7577) os_nodetype: rework os_open, os_stat: UV_EINVAL on NULL filename tui: 'guicursor': use DECSCUSR for xterm-likes (neovim#7576) lint neovim#7562 :checkhealth: fix check for npm and yarn (neovim#7569) doc: Fix pathshorten() example (neovim#7571) health.vim: define highlights as `default` (neovim#7560) runtime: revert netrw update (neovim#7557) defaults: scrollback=10000 (neovim#7556) doc: test/README.md: migrate wiki info (neovim#7552) vim-patch:8.0.0227 (neovim#7548) test/unit/path_spec: expect correct buffer size (neovim#7514) health.vim: normalize slashes for script path (neovim#7525) :terminal : fix crash on resize (neovim#7547) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In vim.h, I checked few code lines which it don't follow Code Style(https://neovim.io/develop/style-guide.xml)
So I fixed some old code lines that do not fit the current code style.
(The old comments (/* */-> // or /// are all.)