:checkhealth: fix logic error when checking for npm and yarn #7569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug that checked for npm AND yarn, where we wanted npm OR yarn. But since we call `npm` exclusively, and it's highly unlikely you have yarn installed without npm, let's just remove the yarn check altogether. Addresses neovim/node-client#41
d56781c to
a7d1fe4
Compare
justinmk
reviewed
Nov 16, 2017
| @@ -496,7 +496,7 @@ function! s:check_node() abort | |||
| return | |||
| endif | |||
|
|
|||
| if !executable('node') || !executable('npm') || !executable('yarn') | |||
| if !executable('node') || !executable('npm') | |||
There was a problem hiding this comment.
So if yarn is available but not npm, it still fails?
There was a problem hiding this comment.
(I updated my commit msg, but not PR msg)
- yes, it's highly unlikely you have yarn installed but not npm
- we also only try to call
npm: https://github.com/neovim/neovim/blob/master/runtime/autoload/health/provider.vim#L516
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Nov 18, 2017
FEATURES: b6a603f neovim#7458 node.js remote-plugin support f5d4da0 :checkhealth : validate 'runtimepath' (neovim#7526) FIXES: e6beb60 :terminal : fix crash on resize (neovim#7547) 07931ed tui: 'guicursor': use DECSCUSR for xterm-likes (neovim#7576) f185c73 neovim#7561 'os_open: UV_EINVAL on NULL filename' e8af34d win: provider: Detect(): return *.cmd path (neovim#7577) eacd788 :checkhealth : fix check for npm and yarn (neovim#7569) a43a573 health.vim: normalize slashes for script path (neovim#7525) 69e3308 cmake: install runtime/rgb.txt d0b05e3 runtime: Fix syntax error in `runtime/syntax/tex.vim` (neovim#7518) 55d8967 tutor: some fixes (neovim#7510) CHANGES: 9837a9c remove legacy alias to `v:count` (neovim#7407) c5f001a runtime: revert netrw update (neovim#7557) 67e4529 defaults: scrollback=10000 (neovim#7556) 881f9e4 process_close(): uv_unref() detached processes (neovim#7539)
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Nov 18, 2017
FEATURES: a6de144 'viewoptions': add "curdir" flag neovim#7447 b6a603f node.js remote-plugin support neovim#7458 f5d4da0 :checkhealth : validate 'runtimepath' neovim#7526 FIXES: e6beb60 :terminal : fix crash on resize neovim#7547 f19e5d6 work around gnome-terminal memory leak neovim#7573 07931ed 'guicursor': use DECSCUSR for xterm-likes neovim#7576 f185c73 'os_open: UV_EINVAL on NULL filename' neovim#7561 e8af34d win: provider: Detect(): return *.cmd path neovim#7577 eacd788 :checkhealth : fix check for npm and yarn neovim#7569 a43a573 health.vim: normalize slashes for script path neovim#7525 69e3308 cmake: install runtime/rgb.txt d0b05e3 runtime: syntax error in `runtime/syntax/tex.vim` neovim#7518 55d8967 tutor: some fixes neovim#7510 CHANGES: 9837a9c remove legacy alias to `v:count` neovim#7407 c5f001a runtime: revert netrw update neovim#7557 67e4529 defaults: scrollback=10000 neovim#7556 881f9e4 process_close(): uv_unref() detached processes neovim#7539
sameedali
added a commit
to sameedali/neovim
that referenced
this pull request
Nov 19, 2017
* 'master' of https://github.com/neovim/neovim: (148 commits) vim-patch:8.0.0283 version bump NVIM v0.2.2 tui: setrgbf/setrgbb: emit semicolons for VTE 'viewoptions': add "curdir" flag neovim#7447 win: provider: Detect(): return *.cmd path (neovim#7577) os_nodetype: rework os_open, os_stat: UV_EINVAL on NULL filename tui: 'guicursor': use DECSCUSR for xterm-likes (neovim#7576) lint neovim#7562 :checkhealth: fix check for npm and yarn (neovim#7569) doc: Fix pathshorten() example (neovim#7571) health.vim: define highlights as `default` (neovim#7560) runtime: revert netrw update (neovim#7557) defaults: scrollback=10000 (neovim#7556) doc: test/README.md: migrate wiki info (neovim#7552) vim-patch:8.0.0227 (neovim#7548) test/unit/path_spec: expect correct buffer size (neovim#7514) health.vim: normalize slashes for script path (neovim#7525) :terminal : fix crash on resize (neovim#7547) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug that checked for npm AND yarn, where we wanted npm OR yarn.
But since we call
npmexclusively, and it's highly unlikely you haveyarn installed without npm, let's just remove the yarn check altogether.
Addresses neovim/node-client#41