test: calcuate correct buffer size for each test #7514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
reviewed
Nov 8, 2017
test/unit/path_spec.lua
Outdated
|
|
||
| local function vim_FullName(path, buflen) | ||
| buf = cstr(buflen, '') | ||
| return cimp.vim_FullName(to_cstr(path), buf, buflen, do_expand) |
There was a problem hiding this comment.
Lua has multi-return, so this could return buf, cimp.vim_..., then buf could stay local. And do_expand should just be a parameter (as it already was. Not in favor of shared-state to save a couple lines of code; tests especially should lean towards "explicit, self-contained" more than "DRY").
justinmk
reviewed
Nov 8, 2017
test/unit/path_spec.lua
Outdated
| eq(FAIL, result) | ||
| end) | ||
|
|
||
| itp('fails safely if given length is wrong #5737', function() | ||
| local force_expansion = 1 | ||
| local filename = 'foo/bar/bazzzzzzz/buz/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/a' | ||
| local path = 'foo/bar/bazzzzzzz/buz/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/a' |
There was a problem hiding this comment.
I intentionally avoid naming variables "path" (usually) since (1) it often means $PATH and (2) "filename" tends to be more common in most APIs I've seen. Sometimes filepath is ok in contexts where "filename" means only the tail.
6b0515f to
e628da2
Compare
Fixed-size buffers and lfs.currentdir().. does not compute. The tests would fail if the current working directory was longer than expected.
e628da2 to
6e4aa62
Compare
sameedali
added a commit
to sameedali/neovim
that referenced
this pull request
Nov 19, 2017
* 'master' of https://github.com/neovim/neovim: (148 commits) vim-patch:8.0.0283 version bump NVIM v0.2.2 tui: setrgbf/setrgbb: emit semicolons for VTE 'viewoptions': add "curdir" flag neovim#7447 win: provider: Detect(): return *.cmd path (neovim#7577) os_nodetype: rework os_open, os_stat: UV_EINVAL on NULL filename tui: 'guicursor': use DECSCUSR for xterm-likes (neovim#7576) lint neovim#7562 :checkhealth: fix check for npm and yarn (neovim#7569) doc: Fix pathshorten() example (neovim#7571) health.vim: define highlights as `default` (neovim#7560) runtime: revert netrw update (neovim#7557) defaults: scrollback=10000 (neovim#7556) doc: test/README.md: migrate wiki info (neovim#7552) vim-patch:8.0.0227 (neovim#7548) test/unit/path_spec: expect correct buffer size (neovim#7514) health.vim: normalize slashes for script path (neovim#7525) :terminal : fix crash on resize (neovim#7547) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed-size buffers and lfs.currentdir().. does not compute. The tests would fail
if the current working directory was longer than expected.