[FIXED] Truncate to removed block & hard kill recovery #7162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
af5ac7a to
399bf1e
Compare
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
399bf1e to
33bde8b
Compare
neilalexander
added a commit
that referenced
this pull request
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
panic fix: the panic was caused by trying to truncate a block that doesn't exist. This would fail silently before. The fix allows us to truncate to a sequence where the whole message block should be removed.
remove index.db first: part of the issue was that an old/ahead index.db would be preserved if we'd be hard killed halfway during truncation. Now remove that index first, so we recover based on the messages normally, and don't try to hold a last seq that's ahead and should have been truncated.
truncate to previous correct entry: the Raft logic would not truncate to the correct index on startup (off-by-one), this would result in the Wrong index and Resetting WAL state issues.
Signed-off-by: Maurice van Veen github@mauricevanveen.com