Skip to content

[FIXED] Health check consumer not found #7154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2025
Merged

[FIXED] Health check consumer not found #7154

merged 1 commit into from
Aug 7, 2025

Conversation

MauriceVanVeen
Copy link
Member

@MauriceVanVeen MauriceVanVeen commented Aug 6, 2025 •
edited
Loading

The health check gathers all assignments and does checking after. If the consumer was deleted in the meantime, it should not report an error.

Also, the health check could run earlier than we're able to create the consumer. In that case, wait before erroring.

Resolves #7149

Signed-off-by: Maurice van Veen github@mauricevanveen.com

@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner August 6, 2025 17:54
derekcollison
derekcollison approved these changes Aug 6, 2025
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MauriceVanVeen MauriceVanVeen force-pushed the maurice/consumer-health branch from 20187b2 to d2ba2d5 Compare August 7, 2025 07:33
@MauriceVanVeen
[FIXED] Health check consumer not found
70e1886 
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen force-pushed the maurice/consumer-health branch from d2ba2d5 to 70e1886 Compare August 7, 2025 07:34
neilalexander
neilalexander approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit af74402 into main Aug 7, 2025
69 of 70 checks passed
@neilalexander neilalexander deleted the maurice/consumer-health branch August 7, 2025 09:27
@neilalexander neilalexander mentioned this pull request Aug 13, 2025
Merged
neilalexander added a commit that referenced this pull request Aug 13, 2025
@neilalexander
Cherry-picks for 2.11.8-RC.1 (#7168)
031e636 
Includes the following:

- #7140
- #7142
- #7145
- #7150
- #7151
- #7154
- #7156
- #7122
- #7166 (excluding the Go
version bump)
- #7162
- #7165

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Random "consumer not found" healthcheck errors
3 participants
@MauriceVanVeen @derekcollison @neilalexander