Skip to content

Add support for illumos #7122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

Add support for illumos #7122

merged 1 commit into from
Aug 11, 2025

Conversation

jwntree
Copy link
Contributor

@jwntree jwntree commented Jul 30, 2025

This allow NATS Server to build under the illumos.

Signed-off-by: Jiwon Na jwntree@hotmail.com

@jwntree jwntree requested a review from a team as a code owner July 30, 2025 16:50
@jwntree jwntree mentioned this pull request Aug 2, 2025
Closed
@neilalexander
Copy link
Member

Indeed nice that this PR reports more thoroughly, any chance you can rebase on latest main & address the sign-off in the commit message too?

@jperkin
Copy link

jperkin commented Aug 7, 2025

Yeh this approach is better, however it does not currently support the illumos build tag. Please can you add it so that this change supports illumos as well as Solaris. Thanks.

@jwntree jwntree force-pushed the illumos branch 2 times, most recently from 20788a7 to 136ec3c Compare August 10, 2025 13:22
@jwntree
illumos build fix
52b5ea8 
Signed-off-by: Jiwon Na <jwntree@hotmail.com>
neilalexander
neilalexander approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@neilalexander neilalexander merged commit 833cc2a into nats-io:main Aug 11, 2025
86 of 89 checks passed
@neilalexander neilalexander mentioned this pull request Aug 13, 2025
Merged
neilalexander added a commit that referenced this pull request Aug 13, 2025
@neilalexander
Cherry-picks for 2.11.8-RC.1 (#7168)
031e636 
Includes the following:

- #7140
- #7142
- #7145
- #7150
- #7151
- #7154
- #7156
- #7122
- #7166 (excluding the Go
version bump)
- #7162
- #7165

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwntree @neilalexander @jperkin