Remove TestStoreProduct purchase check #2570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
commented
Jul 29, 2025
| null, | ||
| callback, | ||
| ) | ||
| purchase(PurchaseParams.Builder(activity, storeProduct).build(), callback) |
There was a problem hiding this comment.
This is unrelated... but I saw that we were using methods that could be made internal in purchasesOrchestrator and took the opportunity to refactor it.
| @@ -60,17 +59,6 @@ class PurchaseParams(val builder: Builder) { | |||
| constructor(activity: Activity, storeProduct: StoreProduct) : | |||
| this(activity, storeProduct.purchasingData, storeProduct.presentedOfferingContext, storeProduct) | |||
|
|
|||
| private fun ensureNoTestProduct(storeProduct: StoreProduct) { | |||
There was a problem hiding this comment.
This is the main change in this PR.
| @@ -1264,62 +1264,6 @@ internal class PurchasesOrchestrator( | |||
| } | |||
| } | |||
|
|
|||
| fun startDeprecatedProductChange( | |||
There was a problem hiding this comment.
This was unused... So took the opportunity to remove it
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2570 +/- ##
==========================================
+ Coverage 78.26% 78.36% +0.09%
==========================================
Files 291 291
Lines 10784 10746 -38
Branches 1507 1501 -6
==========================================
- Hits 8440 8421 -19
+ Misses 1692 1673 -19
Partials 652 652 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vegaro
approved these changes
Jul 29, 2025
tonidero
pushed a commit
that referenced
this pull request
Aug 1, 2025
**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * Add lifetime badge to customer center (#2565) via Cesar de la Vega (@vegaro) ### Customer Center #### ✨ New Features * Introduce custom actions for customer center (#2572) via Facundo Menzella (@facumenzella) ## RevenueCatUI SDK ### ✨ New Features * Add support for az-AZ locale (#2575) via Franco Correa (@francocorreasosa) ### Customer Center #### 🐞 Bugfixes * Display latest expired subscription if no active subscriptions (#2564) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * Expose getStorefront APIs in CustomEntitlementComputation flavor (#2579) via Toni Rico (@tonidero) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2578) via RevenueCat Git Bot (@RCGitBot) * Add missing dokka-hide-internal tests to CI and fix reported number of tests (#2569) via Cesar de la Vega (@vegaro) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2574) via RevenueCat Git Bot (@RCGitBot) * Convert WebBilling products into TestStoreProducts (#2573) via Toni Rico (@tonidero) * Add WebBillingGetProducts endpoint (#2571) via Toni Rico (@tonidero) * Remove TestStoreProduct purchase check (#2570) via Toni Rico (@tonidero) * Improve 9.0.0 changelog (#2568) via Toni Rico (@tonidero) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2567) via RevenueCat Git Bot (@RCGitBot) * Parallel test jobs (#2549) via Cesar de la Vega (@vegaro) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
tonidero
added a commit
that referenced
this pull request
Aug 25, 2025
Until now we had a check that threw an exception when trying to purchase using a TestStoreProduct. However, as part of supporting the Test store we want to remove this check. The purchase method would still fail later, when checking the purchase type in the Google/Amazon stores.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Until now we had a check that threw an exception when trying to purchase using a TestStoreProduct. However, as part of supporting the Test store we want to remove this check. The purchase method would still fail later, when checking the purchase type in the Google/Amazon stores.