Expose getStorefront APIs in CustomEntitlementComputation flavor #2579

tonidero · 2025-08-01T06:50:58Z

Description

While CEC already had the storefrontCountryCode, this also adds the APIs getStorefrontCountryCode and awaitStorefrontCountryCode to the CEC flavor.

tonidero · 2025-08-01T07:12:14Z

purchases/api-defauts.txt

    method @Deprecated public static void getSubscriptionSkusWith(com.revenuecat.purchases.Purchases, java.util.List<java.lang.String> skus, optional kotlin.jvm.functions.Function1<? super com.revenuecat.purchases.PurchasesError,kotlin.Unit> onError, kotlin.jvm.functions.Function1<? super java.util.List<? extends com.revenuecat.purchases.models.StoreProduct>,kotlin.Unit> onReceiveSkus);
+    method public static void getVirtualCurrenciesWith(com.revenuecat.purchases.Purchases, optional kotlin.jvm.functions.Function1<? super com.revenuecat.purchases.PurchasesError,kotlin.Unit> onError, kotlin.jvm.functions.Function1<? super com.revenuecat.purchases.virtualcurrencies.VirtualCurrencies,kotlin.Unit> onSuccess);


I'm confused why these are not updated nor found in the checks...

Yea it seems like we cannot rely on the check at all. I think we might need to go the git diff route?

codecov · 2025-08-01T07:25:21Z

Codecov Report

❌ Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.64%. Comparing base (51baa24) to head (3d46cea).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...revenuecat/purchases/CoroutinesExtensionsCommon.kt	0.00%	5 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2579   +/-   ##
=======================================
  Coverage   78.64%   78.64%           
=======================================
  Files         296      296           
  Lines       10888    10888           
  Branches     1520     1520           
=======================================
  Hits         8563     8563           
  Misses       1663     1663           
  Partials      662      662

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

JayShortway

Looks good!

JayShortway · 2025-08-01T07:47:59Z

purchases/api-defauts.txt

    method @Deprecated public static void getSubscriptionSkusWith(com.revenuecat.purchases.Purchases, java.util.List<java.lang.String> skus, optional kotlin.jvm.functions.Function1<? super com.revenuecat.purchases.PurchasesError,kotlin.Unit> onError, kotlin.jvm.functions.Function1<? super java.util.List<? extends com.revenuecat.purchases.models.StoreProduct>,kotlin.Unit> onReceiveSkus);
+    method public static void getVirtualCurrenciesWith(com.revenuecat.purchases.Purchases, optional kotlin.jvm.functions.Function1<? super com.revenuecat.purchases.PurchasesError,kotlin.Unit> onError, kotlin.jvm.functions.Function1<? super com.revenuecat.purchases.virtualcurrencies.VirtualCurrencies,kotlin.Unit> onSuccess);


Yea it seems like we cannot rely on the check at all. I think we might need to go the git diff route?

ajpallares

Makes sense! Thank you!

ajpallares · 2025-08-01T07:50:22Z

purchases/api-defauts.txt

I'm curious: what are these txt files for?

They have the public API for our libraries, both in the defaults flavor and the cec flavor. We're using metalava to generate them. Unfortunately, the check task itself doesn't seem to be working, so we might need to fallback to always dump these api files and compare using git.

These are "dumps" of our public API surface. We have them in other repos too, like purchases-kmp. The idea being that any PR would check if the committed text file is still valid. If not, the PR author should regenerate the file, which would add the diff to the PR, allowing us to review it.

In purchases-android we use Metalava for this (a Google tool), but the "check" task doesn't seem to work consistently. It overlooks changes to the public API, which becomes evident once we regenerate the files and see unrelated changes. (Virtual Currency stuff in this PR for instance.)

(Ha, I should have refreshed before hitting send 😅)

I understand now. Thank you both so much! 🫶
(two explanations is better than one 😄)

While CEC already had the `storefrontCountryCode`, this also adds the APIs `getStorefrontCountryCode` and `awaitStorefrontCountryCode` to the CEC flavor.

@vegaro

**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * Add lifetime badge to customer center (#2565) via Cesar de la Vega (@vegaro) ### Customer Center #### ✨ New Features * Introduce custom actions for customer center (#2572) via Facundo Menzella (@facumenzella) ## RevenueCatUI SDK ### ✨ New Features * Add support for az-AZ locale (#2575) via Franco Correa (@francocorreasosa) ### Customer Center #### 🐞 Bugfixes * Display latest expired subscription if no active subscriptions (#2564) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * Expose getStorefront APIs in CustomEntitlementComputation flavor (#2579) via Toni Rico (@tonidero) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2578) via RevenueCat Git Bot (@RCGitBot) * Add missing dokka-hide-internal tests to CI and fix reported number of tests (#2569) via Cesar de la Vega (@vegaro) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2574) via RevenueCat Git Bot (@RCGitBot) * Convert WebBilling products into TestStoreProducts (#2573) via Toni Rico (@tonidero) * Add WebBillingGetProducts endpoint (#2571) via Toni Rico (@tonidero) * Remove TestStoreProduct purchase check (#2570) via Toni Rico (@tonidero) * Improve 9.0.0 changelog (#2568) via Toni Rico (@tonidero) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2567) via RevenueCat Git Bot (@RCGitBot) * Parallel test jobs (#2549) via Cesar de la Vega (@vegaro) Co-authored-by: revenuecat-ops <ops@revenuecat.com>

While CEC already had the `storefrontCountryCode`, this also adds the APIs `getStorefrontCountryCode` and `awaitStorefrontCountryCode` to the CEC flavor.

tonidero added pr:other pr:force_patch Forces a patch release labels Aug 1, 2025

Expose getStorefront APIs in CustomEntitlementComputation flavor

142265f

tonidero force-pushed the expose-get-storefront-apis-cec-mode branch from a7a9da9 to 142265f Compare August 1, 2025 06:57

Update metalava

3d46cea

tonidero commented Aug 1, 2025

View reviewed changes

tonidero marked this pull request as ready for review August 1, 2025 07:37

tonidero requested a review from a team August 1, 2025 07:37

JayShortway approved these changes Aug 1, 2025

View reviewed changes

tonidero added this pull request to the merge queue Aug 1, 2025

ajpallares approved these changes Aug 1, 2025

View reviewed changes

Merged via the queue into main with commit f9edf9e Aug 1, 2025
20 checks passed

tonidero deleted the expose-get-storefront-apis-cec-mode branch August 1, 2025 08:08

tonidero mentioned this pull request Aug 1, 2025

Release/8.22.1 #2580

Closed

RCGitBot mentioned this pull request Aug 1, 2025

[AUTOMATIC] Release/9.2.0 #2581

Merged

tonidero mentioned this pull request Aug 25, 2025

Release/8.23.0 #2631

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Expose getStorefront APIs in CustomEntitlementComputation flavor #2579

Expose getStorefront APIs in CustomEntitlementComputation flavor #2579

Uh oh!

tonidero commented Aug 1, 2025

Uh oh!

tonidero Aug 1, 2025

Uh oh!

JayShortway Aug 1, 2025

Uh oh!

tonidero Aug 1, 2025

Uh oh!

codecov bot commented Aug 1, 2025 •

edited

Loading

Uh oh!

JayShortway left a comment

Uh oh!

JayShortway Aug 1, 2025

Uh oh!

ajpallares left a comment

Uh oh!

ajpallares Aug 1, 2025

Uh oh!

tonidero Aug 1, 2025

Uh oh!

JayShortway Aug 1, 2025

Uh oh!

JayShortway Aug 1, 2025

Uh oh!

ajpallares Aug 1, 2025

Uh oh!

Uh oh!

Uh oh!

		method @Deprecated public static void getSubscriptionSkusWith(com.revenuecat.purchases.Purchases, java.util.List<java.lang.String> skus, optional kotlin.jvm.functions.Function1<? super com.revenuecat.purchases.PurchasesError,kotlin.Unit> onError, kotlin.jvm.functions.Function1<? super java.util.List<? extends com.revenuecat.purchases.models.StoreProduct>,kotlin.Unit> onReceiveSkus);
		method public static void getVirtualCurrenciesWith(com.revenuecat.purchases.Purchases, optional kotlin.jvm.functions.Function1<? super com.revenuecat.purchases.PurchasesError,kotlin.Unit> onError, kotlin.jvm.functions.Function1<? super com.revenuecat.purchases.virtualcurrencies.VirtualCurrencies,kotlin.Unit> onSuccess);

Expose getStorefront APIs in CustomEntitlementComputation flavor #2579

Expose getStorefront APIs in CustomEntitlementComputation flavor #2579

Uh oh!

Conversation

tonidero commented Aug 1, 2025

Description

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JayShortway left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ajpallares left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Aug 1, 2025 •

edited

Loading