Parallel test jobs #2549
Merged
Parallel test jobs #2549
+174
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2549 +/- ##
=======================================
Coverage 78.26% 78.26%
=======================================
Files 291 291
Lines 10784 10784
Branches 1507 1507
=======================================
Hits 8440 8440
Misses 1692 1692
Partials 652 652 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 96ee669.
tonidero
approved these changes
Jul 24, 2025
| command: ./gradlew purchases:koverHtmlReportDefaultsRelease | ||
| - run: | ||
| name: Kover XML | ||
| name: Generate Kover XML |
There was a problem hiding this comment.
So we're only using Kover for the defaults release flavor right? I guess this could leave some paths untested even if they are actually tested... but I don't have a better idea right now, so I'm ok with this 😅
There was a problem hiding this comment.
right! I noticed that the other day as well, that's mainly why I asked about revisiting it. Let's leave it as is since that's what we had yeah
JayShortway
reviewed
Jul 24, 2025
Comment on lines
+316
to
332
| <<: *android-executor | ||
| shell: /bin/bash --login -o pipefail | ||
| steps: | ||
| - checkout | ||
| - attach_workspace: | ||
| at: . | ||
| - android/restore_gradle_cache | ||
| - run: | ||
| name: Run CEC Release Tests | ||
| command: ./gradlew testCustomEntitlementComputationReleaseUnitTest --parallel --no-daemon | ||
| - run: | ||
| name: Collect JUnit XMLs | ||
| command: | | ||
| mkdir -p build/test-results | ||
| find . -type f -regex ".*/build/test-results/.*xml" -exec cp --parents {} build/test-results/ \; | ||
| - store_test_results: | ||
| path: build/test-results |
There was a problem hiding this comment.
This job is copied a few times if I'm reading it correctly. Maybe we can extract it to a command, which takes a gradleTask parameter or something?
Comment on lines
+241
to
+244
| - persist_to_workspace: | ||
| root: . | ||
| paths: | ||
| - . |
There was a problem hiding this comment.
How long does this take? We could use save-incremental-gradle-build-to-workspace to only persist the relevant directories.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 31, 2025
…f tests (#2569) #2549 split tests but it had a difference missing around 3000 tests compared to the previous test logic. After some debugging I realized we were missing a module's test `dokka-hide-internal`. When adding that I realized that it was reporting 6 tests, but we only have 3 tests in there. That helped me realize we had an issue storing tests, and we were double counting them.
tonidero
pushed a commit
that referenced
this pull request
Aug 1, 2025
**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * Add lifetime badge to customer center (#2565) via Cesar de la Vega (@vegaro) ### Customer Center #### ✨ New Features * Introduce custom actions for customer center (#2572) via Facundo Menzella (@facumenzella) ## RevenueCatUI SDK ### ✨ New Features * Add support for az-AZ locale (#2575) via Franco Correa (@francocorreasosa) ### Customer Center #### 🐞 Bugfixes * Display latest expired subscription if no active subscriptions (#2564) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * Expose getStorefront APIs in CustomEntitlementComputation flavor (#2579) via Toni Rico (@tonidero) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2578) via RevenueCat Git Bot (@RCGitBot) * Add missing dokka-hide-internal tests to CI and fix reported number of tests (#2569) via Cesar de la Vega (@vegaro) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2574) via RevenueCat Git Bot (@RCGitBot) * Convert WebBilling products into TestStoreProducts (#2573) via Toni Rico (@tonidero) * Add WebBillingGetProducts endpoint (#2571) via Toni Rico (@tonidero) * Remove TestStoreProduct purchase check (#2570) via Toni Rico (@tonidero) * Improve 9.0.0 changelog (#2568) via Toni Rico (@tonidero) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2567) via RevenueCat Git Bot (@RCGitBot) * Parallel test jobs (#2549) via Cesar de la Vega (@vegaro) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
tonidero
pushed a commit
that referenced
this pull request
Aug 25, 2025
tonidero
pushed a commit
that referenced
this pull request
Aug 25, 2025
…f tests (#2569) #2549 split tests but it had a difference missing around 3000 tests compared to the previous test logic. After some debugging I realized we were missing a module's test `dokka-hide-internal`. When adding that I realized that it was reporting 6 tests, but we only have 3 tests in there. That helped me realize we had an issue storing tests, and we were double counting them.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build-test-deploytimes down to 17 min from 37 min