Update VC Caching Log Message #2552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2552 +/- ##
=======================================
Coverage 78.26% 78.26%
=======================================
Files 291 291
Lines 10784 10784
Branches 1507 1507
=======================================
Hits 8440 8440
Misses 1692 1692
Partials 652 652 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JayShortway
approved these changes
Jul 22, 2025
ajpallares
approved these changes
Jul 22, 2025
📸 Snapshot Test648 unchanged
🛸 Powered by Emerge Tools |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 23, 2025
**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * Resubscribe if cancelled (#2487) via Cesar de la Vega (@vegaro) ### Virtual Currency #### 🐞 Bugfixes * Update VC Caching Log Message (#2552) via Will Taylor (@fire-at-will) ## RevenueCatUI SDK ### Customer Center #### 🐞 Bugfixes * Update design of No Active subscriptions screen in Customer Center (#2559) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2561) via RevenueCat Git Bot (@RCGitBot) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2560) via RevenueCat Git Bot (@RCGitBot) * Bump danger from 9.5.1 to 9.5.3 (#2556) via dependabot[bot] (@dependabot[bot]) * Bump fastlane from 2.227.2 to 2.228.0 (#2557) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-revenuecat_internal from `9a29f63` to `7d97553` (#2558) via dependabot[bot] (@dependabot[bot]) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2555) via RevenueCat Git Bot (@RCGitBot) * Bump nokogiri from 1.18.8 to 1.18.9 (#2553) via dependabot[bot] (@dependabot[bot]) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2551) via RevenueCat Git Bot (@RCGitBot) * Fix paywall tester so customer center doesn't close when changing to dark mode (#2550) via Cesar de la Vega (@vegaro) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
tonidero
pushed a commit
that referenced
this pull request
Aug 25, 2025
### Description Android equivalent of RevenueCat/purchases-ios#5404 This PR updates the `VirtualCurrencyStrings.NO_CACHED_VIRTUAL_CURRENCIES` log message from `"No cached VirtualCurrencies, fetching from network."` to `"There are no cached VirtualCurrencies."`. The previous message stated that a network fetch would occur, which isn't always the case. There are two scenarios where this log may appear: - When fetching virtual currencies and the cache is not stale but contains no virtual currencies object (an edge case that shouldn't occur with normal usage). - When accessing the cache directly using `Purchases.cachedVirtualCurrencies` and it's empty - in this case, the SDK returns nil without initiating a network fetch. The updated message is more descriptive of what actually happens in the second scenario. In the first scenario, subsequent log messages state that the SDK is fetching VCs from the network.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Android equivalent of RevenueCat/purchases-ios#5404
This PR updates the
VirtualCurrencyStrings.NO_CACHED_VIRTUAL_CURRENCIESlog message from"No cached VirtualCurrencies, fetching from network."to"There are no cached VirtualCurrencies.".The previous message stated that a network fetch would occur, which isn't always the case.
There are two scenarios where this log may appear:
Purchases.cachedVirtualCurrenciesand it's empty - in this case, the SDK returns nil without initiating a network fetch.The updated message is more descriptive of what actually happens in the second scenario. In the first scenario, subsequent log messages state that the SDK is fetching VCs from the network.