Fix paywall tester so customer center doesn't close when changing to dark mode #2550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegaro
commented
Jul 18, 2025
| @@ -98,7 +98,7 @@ internal interface CustomerCenterViewModel { | |||
|
|
|||
| // trigger state refresh | |||
| fun refreshStateIfLocaleChanged() | |||
| fun refreshStateIfColorsChanged(colorScheme: ColorScheme, isDark: Boolean) | |||
| fun refreshStateIfColorsChanged(currentColorScheme: ColorScheme, isSystemInDarkTheme: Boolean) | |||
There was a problem hiding this comment.
this was just renames because I found them confusing
tonidero
approved these changes
Jul 18, 2025
| @@ -50,21 +50,22 @@ fun AppInfoScreen( | |||
| ), | |||
| ) { | |||
| var isDebugBottomSheetVisible by remember { mutableStateOf(false) } | |||
| var isCustomerCenterVisible by remember { mutableStateOf(false) } | |||
There was a problem hiding this comment.
I believe we could have just used rememberSaveable... But I'm ok to move the state to the View model :)
There was a problem hiding this comment.
Oh right! I overcomplicated it lol
Thank you!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2550 +/- ##
=======================================
Coverage 78.26% 78.26%
=======================================
Files 291 291
Lines 10782 10782
Branches 1507 1507
=======================================
Hits 8439 8439
Misses 1691 1691
Partials 652 652 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 23, 2025
**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * Resubscribe if cancelled (#2487) via Cesar de la Vega (@vegaro) ### Virtual Currency #### 🐞 Bugfixes * Update VC Caching Log Message (#2552) via Will Taylor (@fire-at-will) ## RevenueCatUI SDK ### Customer Center #### 🐞 Bugfixes * Update design of No Active subscriptions screen in Customer Center (#2559) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2561) via RevenueCat Git Bot (@RCGitBot) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2560) via RevenueCat Git Bot (@RCGitBot) * Bump danger from 9.5.1 to 9.5.3 (#2556) via dependabot[bot] (@dependabot[bot]) * Bump fastlane from 2.227.2 to 2.228.0 (#2557) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-revenuecat_internal from `9a29f63` to `7d97553` (#2558) via dependabot[bot] (@dependabot[bot]) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2555) via RevenueCat Git Bot (@RCGitBot) * Bump nokogiri from 1.18.8 to 1.18.9 (#2553) via dependabot[bot] (@dependabot[bot]) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2551) via RevenueCat Git Bot (@RCGitBot) * Fix paywall tester so customer center doesn't close when changing to dark mode (#2550) via Cesar de la Vega (@vegaro) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
tonidero
pushed a commit
that referenced
this pull request
Aug 25, 2025
…dark mode (#2550) The Customer Center was closing when switching between light and dark mode
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Customer Center was closing when switching between light and dark mode