Resubscribe if cancelled #2487
Merged
Resubscribe if cancelled #2487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 Snapshot Test648 unchanged
🛸 Powered by Emerge Tools |
JayShortway
approved these changes
Jul 10, 2025
Comment on lines
385
to
389
| private fun transformPathsOnSubscriptionState( | ||
| paths: List<HelpPath>, | ||
| selectedPurchaseInformation: PurchaseInformation?, | ||
| localization: CustomerCenterConfigData.Localization, | ||
| ): List<HelpPath> { |
There was a problem hiding this comment.
Minor, but we can make paths the receiver, so we don't need the let above:
private fun List<HelpPath>.transformPathsOnSubscriptionState(
selectedPurchaseInformation: PurchaseInformation?,
localization: CustomerCenterConfigData.Localization,
): List<HelpPath> {(You can press Option+Enter with your caret in the paths parameter, and click "Convert parameter to receiver" to do it automatically.)
| @@ -122,7 +121,7 @@ class CustomerCenterViewModelTests { | |||
| } | |||
|
|
|||
| @Test | |||
| fun `loadAndDisplayPromotionalOffer returns false when offer is not eligible`() = runTest { | |||
| fun `loadAndDisplayPromotionalOffer returns false when offer is not eligible`(): Unit = runBlocking { | |||
tonidero
approved these changes
Jul 10, 2025
...com/revenuecat/purchases/ui/revenuecatui/customercenter/viewmodel/CustomerCenterViewModel.kt
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2487 +/- ##
==========================================
- Coverage 78.10% 78.09% -0.01%
==========================================
Files 286 286
Lines 10573 10575 +2
Branches 1485 1485
==========================================
+ Hits 8258 8259 +1
- Misses 1668 1669 +1
Partials 647 647 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 23, 2025
**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * Resubscribe if cancelled (#2487) via Cesar de la Vega (@vegaro) ### Virtual Currency #### 🐞 Bugfixes * Update VC Caching Log Message (#2552) via Will Taylor (@fire-at-will) ## RevenueCatUI SDK ### Customer Center #### 🐞 Bugfixes * Update design of No Active subscriptions screen in Customer Center (#2559) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2561) via RevenueCat Git Bot (@RCGitBot) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2560) via RevenueCat Git Bot (@RCGitBot) * Bump danger from 9.5.1 to 9.5.3 (#2556) via dependabot[bot] (@dependabot[bot]) * Bump fastlane from 2.227.2 to 2.228.0 (#2557) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-revenuecat_internal from `9a29f63` to `7d97553` (#2558) via dependabot[bot] (@dependabot[bot]) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2555) via RevenueCat Git Bot (@RCGitBot) * Bump nokogiri from 1.18.8 to 1.18.9 (#2553) via dependabot[bot] (@dependabot[bot]) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2551) via RevenueCat Git Bot (@RCGitBot) * Fix paywall tester so customer center doesn't close when changing to dark mode (#2550) via Cesar de la Vega (@vegaro) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
tonidero
pushed a commit
that referenced
this pull request
Aug 25, 2025
If the subscription is already cancelled, it should say "Resubscribe" instead of "Cancel Subscription" It should also not open any feedback survey or promotional offer
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the subscription is already cancelled, it should say "Resubscribe" instead of "Cancel Subscription"
It should also not open any feedback survey or promotional offer