Skip to content

problem: kevent udata is now void* on NetBSD Current (10) #4326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2022
Merged

problem: kevent udata is now void* on NetBSD Current (10) #4326

merged 1 commit into from
Jan 3, 2022

Conversation

fanquake
Copy link
Contributor

@fanquake fanquake commented Jan 3, 2022

solution: check for the intptr_t variant in configure.

Building libzmq master (ee09926) on NETBSD Current fails with:

gmake[1]: Entering directory '/home/ec2-user/libzmq'
  CXX      src/libzmq_la-kqueue.lo
In file included from /usr/include/errno.h:42,
                 from src/../include/zmq.h:56,
                 from src/precompiled.hpp:57,
                 from src/kqueue.cpp:30:
src/kqueue.cpp: In member function 'void zmq::kqueue_t::kevent_add(zmq::fd_t, short int, void*)':
src/kqueue.cpp:79:5: error: invalid 'static_cast' from type 'intptr_t' {aka 'long int'} to type 'void*'
   79 |     EV_SET (&ev, fd_, filter_, EV_ADD, 0, 0, (kevent_udata_t) udata_);
      |     ^~~~~~
gmake[1]: *** [Makefile:5652: src/libzmq_la-kqueue.lo] Error 1

As of NetBSD/src@e5ead82, NetBSD has switched the type of the udata field in it's kevent struct from intptr_t to void * (to align with other BSDs).

@fanquake
problem: kevent udata is now void* on NetBSD Current (10)
129137d 
solution: check for the intptr_t variant in configure.
This was referenced Jan 3, 2022
Merged
Merged
@bluca bluca merged commit 6473bf4 into zeromq:master Jan 3, 2022
@fanquake fanquake deleted the netbsd_current_kevent_udata_void branch January 4, 2022 02:54
fanquake added a commit to bitcoin-core/gui that referenced this pull request Jan 20, 2022
@fanquake
Merge bitcoin/bitcoin#23956: build: use zeromq 4.3.4 in depends & fix…
7102f7d 
… NetBSD 10 build

6897c4b build: patch depends zeromq to fix building on NetBSD Current (fanquake)
ce6dd2f zeromq 4.3.4 (fanquake)

Pull request description:

  This is a prerequisite for #23955. It updates zeromq to the latest available version, and adds a patch, [that I've sent upstream](zeromq/libzmq#4326), to fix building on NetBSD Current (10).

ACKs for top commit:
  hebasto:
    ACK 6897c4b, I have reviewed the code and it looks OK, I agree it can be merged.

Tree-SHA512: d05d9753630faebe842e1ca70c8c4af660a38e7331a9d95e84df3a3b14564c5118ca41c4fc49fb71dfee563b63e1014e5a3f8874d652e26de59e8e188a12970e
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 20, 2022
@fanquake
Merge bitcoin#23956: build: use zeromq 4.3.4 in depends & fix NetBSD …
5025bfa 
…10 build

6897c4b build: patch depends zeromq to fix building on NetBSD Current (fanquake)
ce6dd2f zeromq 4.3.4 (fanquake)

Pull request description:

  This is a prerequisite for bitcoin#23955. It updates zeromq to the latest available version, and adds a patch, [that I've sent upstream](zeromq/libzmq#4326), to fix building on NetBSD Current (10).

ACKs for top commit:
  hebasto:
    ACK 6897c4b, I have reviewed the code and it looks OK, I agree it can be merged.

Tree-SHA512: d05d9753630faebe842e1ca70c8c4af660a38e7331a9d95e84df3a3b14564c5118ca41c4fc49fb71dfee563b63e1014e5a3f8874d652e26de59e8e188a12970e
@lyricidal lyricidal mentioned this pull request Mar 21, 2023
Merged
@tobtoht tobtoht mentioned this pull request Oct 9, 2023
Open
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 12, 2024
@fanquake @PastaPastaPasta
Merge bitcoin#23956: build: use zeromq 4.3.4 in depends & fix NetBSD …
eee30e8 
…10 build

6897c4b build: patch depends zeromq to fix building on NetBSD Current (fanquake)
ce6dd2f zeromq 4.3.4 (fanquake)

Pull request description:

  This is a prerequisite for bitcoin#23955. It updates zeromq to the latest available version, and adds a patch, [that I've sent upstream](zeromq/libzmq#4326), to fix building on NetBSD Current (10).

ACKs for top commit:
  hebasto:
    ACK 6897c4b, I have reviewed the code and it looks OK, I agree it can be merged.

Tree-SHA512: d05d9753630faebe842e1ca70c8c4af660a38e7331a9d95e84df3a3b14564c5118ca41c4fc49fb71dfee563b63e1014e5a3f8874d652e26de59e8e188a12970e
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 12, 2024
@fanquake @PastaPastaPasta
Merge bitcoin#23956: build: use zeromq 4.3.4 in depends & fix NetBSD …
b0589c6 
…10 build

6897c4b build: patch depends zeromq to fix building on NetBSD Current (fanquake)
ce6dd2f zeromq 4.3.4 (fanquake)

Pull request description:

  This is a prerequisite for bitcoin#23955. It updates zeromq to the latest available version, and adds a patch, [that I've sent upstream](zeromq/libzmq#4326), to fix building on NetBSD Current (10).

ACKs for top commit:
  hebasto:
    ACK 6897c4b, I have reviewed the code and it looks OK, I agree it can be merged.

Tree-SHA512: d05d9753630faebe842e1ca70c8c4af660a38e7331a9d95e84df3a3b14564c5118ca41c4fc49fb71dfee563b63e1014e5a3f8874d652e26de59e8e188a12970e
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 14, 2024
@fanquake @PastaPastaPasta
Merge bitcoin#23956: build: use zeromq 4.3.4 in depends & fix NetBSD …
53b1557 
…10 build

6897c4b build: patch depends zeromq to fix building on NetBSD Current (fanquake)
ce6dd2f zeromq 4.3.4 (fanquake)

Pull request description:

  This is a prerequisite for bitcoin#23955. It updates zeromq to the latest available version, and adds a patch, [that I've sent upstream](zeromq/libzmq#4326), to fix building on NetBSD Current (10).

ACKs for top commit:
  hebasto:
    ACK 6897c4b, I have reviewed the code and it looks OK, I agree it can be merged.

Tree-SHA512: d05d9753630faebe842e1ca70c8c4af660a38e7331a9d95e84df3a3b14564c5118ca41c4fc49fb71dfee563b63e1014e5a3f8874d652e26de59e8e188a12970e
JaredTate pushed a commit to DigiByte-Core/digibyte that referenced this pull request Jul 9, 2025
@fanquake @JaredTate
Merge bitcoin/bitcoin#23956: build: use zeromq 4.3.4 in depends & fix…
c2e4dbb 
… NetBSD 10 build

6897c4b build: patch depends zeromq to fix building on NetBSD Current (fanquake)
ce6dd2f zeromq 4.3.4 (fanquake)

Pull request description:

  This is a prerequisite for #23955. It updates zeromq to the latest available version, and adds a patch, [that I've sent upstream](zeromq/libzmq#4326), to fix building on NetBSD Current (10).

ACKs for top commit:
  hebasto:
    ACK 6897c4b, I have reviewed the code and it looks OK, I agree it can be merged.

Tree-SHA512: d05d9753630faebe842e1ca70c8c4af660a38e7331a9d95e84df3a3b14564c5118ca41c4fc49fb71dfee563b63e1014e5a3f8874d652e26de59e8e188a12970e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fanquake @bluca